public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/63303] Pointer subtraction is broken when using -fsanitize=undefined Date: Fri, 19 Sep 2014 13:47:00 -0000 [thread overview] Message-ID: <bug-63303-4-EYGUOQZE2w@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-63303-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63303 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jason at gcc dot gnu.org, | |jsm28 at gcc dot gnu.org, | |rguenth at gcc dot gnu.org --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- The problem is that we don't have a POINTER_DIFF_EXPR similar to POINTER_PLUS_EXPR, which would take two pointers and return an integer, and the FEs emit pointer difference as cast of both the pointers to signed integral type and subtracts the integers. If ssize_t foo (char *p, char *q) { return p - q; } is changed into ssize_t foo (char *p, char *q) { return (ssize_t) p - (ssize_t) q; } by the FE, then indeed if you have array starting at 0x7fff0000 and ending at 0x80010000 and subtract those two pointers, you get undefined behavior. That is undefined behavior not just for ubsan, but for anything else in the middle-end. So, if pointer difference is supposed to behave differently, then we'd either need to represent pointer difference as ssize_t foo (char *p, char *q) { return (ssize_t) ((size_t) p - (size_t) q); } (but we risk missed optimizations that way I'd say), or we'd need a better representation of it in the middle-end.
next prev parent reply other threads:[~2014-09-19 13:47 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-19 1:42 [Bug c/63303] New: " mikulas at artax dot karlin.mff.cuni.cz 2014-09-19 7:26 ` [Bug c/63303] " jakub at gcc dot gnu.org 2014-09-19 13:38 ` mikulas at artax dot karlin.mff.cuni.cz 2014-09-19 13:47 ` jakub at gcc dot gnu.org [this message] 2014-09-19 15:50 ` mikulas at artax dot karlin.mff.cuni.cz 2014-09-19 15:57 ` jakub at gcc dot gnu.org 2014-09-19 16:15 ` mikulas at artax dot karlin.mff.cuni.cz 2014-09-19 16:21 ` joseph at codesourcery dot com 2014-09-19 16:22 ` jakub at gcc dot gnu.org 2014-09-19 16:29 ` mikulas at artax dot karlin.mff.cuni.cz 2014-09-22 7:42 ` rguenth at gcc dot gnu.org 2014-09-22 14:31 ` mikulas at artax dot karlin.mff.cuni.cz 2015-10-19 11:03 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-63303-4-EYGUOQZE2w@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).