[Bug c/63336] New: cilkplus array notation ICE in find_rank

[Bug c/63336] New: cilkplus array notation ICE in find_rank

[tprince at computer dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

            Bug ID: 63336
           Summary: cilkplus array notation ICE in find_rank
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tprince at computer dot org

Created attachment 33534
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33534&action=edit
pre-processed C source with cilkplus array notation

$ gcc -std=c99  -c -fcilkplus  -v s422.i
Using built-in specs.
COLLECT_GCC=gcc
Target: x86_64-unknown-cygwin
Configured with: ../configure --prefix=/usr/local/gcc5.0 --enable-languages='c
c
++ fortran' --enable-libgomp --enable-threads=posix --disable-__cxa_atexit
--wit
h-dwarf2 --without-libiconv-prefix --without-libintl-prefix --with-system-zlib
-
-disable-werror --without-cloog --without-isl
Thread model: posix
gcc version 5.0.0 20140922 (experimental) (GCC)
COLLECT_GCC_OPTIONS='-std=c99' '-c' '-fcilkplus' '-v' '-mtune=generic'
'-march=x
86-64' '-pthread'
 /usr/local/gcc5.0/libexec/gcc/x86_64-unknown-cygwin/5.0.0/cc1.exe
-fpreprocesse
d s422.i -quiet -dumpbase s422.i -mtune=generic -march=x86-64 -auxbase s422
-std
=c99 -version -fcilkplus -o /tmp/ccCsOctk.s
GNU C (GCC) version 5.0.0 20140922 (experimental) (x86_64-unknown-cygwin)
        compiled by GNU C version 5.0.0 20140922 (experimental), GMP version
6.0
.0, MPFR version 3.1.2, MPC version 1.0.2
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C (GCC) version 5.0.0 20140922 (experimental) (x86_64-unknown-cygwin)
        compiled by GNU C version 5.0.0 20140922 (experimental), GMP version
6.0
.0, MPFR version 3.1.2, MPC version 1.0.2
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 418ff77cc465e61e11d739c56dbe80c7
s422.c: In function ‘s422_’:
s422.c:86:5: internal compiler error: in find_rank, at
c-family/array-notation-c
ommon.c:231
     }
     ^
Please submit a full bug report,
>From gcc-bugs-return-462283-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Sep 22 16:40:15 2014
Return-Path: <gcc-bugs-return-462283-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17086 invoked by alias); 22 Sep 2014 16:40:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17068 invoked by uid 48); 22 Sep 2014 16:40:10 -0000
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/63337] New: Hexadecimal exponent: improvements to error message
Date: Mon, 22 Sep 2014 16:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dmalcolm at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-63337-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-09/txt/msg02117.txt.bz2
Content-length: 1348

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc337

            Bug ID: 63337
           Summary: Hexadecimal exponent: improvements to error message
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dmalcolm at gcc dot gnu.org

As discussed in the thread here:
  https://gcc.gnu.org/ml/gcc/2014-09/msg00282.html
if the user mistakenly tries to use the "e" suffix for a exponent marker with a
hexadecimal constant, the warning could be improved.

$ cat /tmp/foo.c
float f = 0x3ffe+63;

$ gcc/cc1 /tmp/foo.c
/tmp/foo.c:1:11: error: invalid suffix "+63" on integer constant
 float f = 0x3ffe+63;
           ^

A better warning might be something like:
/tmp/foo.c:1:11: error: invalid suffix "+63" on integer constant
 float f = 0x3ffe+63;
           ^
/tmp/foo.c:1:11: hint: if you meant for "e" to be an exponent, use "p" as an
exponent suffix for hexadecimal constants:
 float f = 0x3ffe+63;
                ^
 float f = 0x3ffp+63;
                ^
or somesuch; maybe even just:
/tmp/foo.c:1:11: error: use "p" rather than "e" for exponents for hexadecimal
constants
 float f = 0x3ffe+63;
                ^
(how far can we go down the road of actually outputting a patch?)

[Bug c/63336] cilkplus array notation ICE in find_rank

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-12-17
                 CC|                            |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

[Bug c/63336] cilkplus array notation ICE in find_rank

[barnabe.marc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

Marc <barnabe.marc at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barnabe.marc at gmail dot com

--- Comment #2 from Marc <barnabe.marc at gmail dot com> ---
Same thing in GCC 5.2


Using built-in specs.
COLLECT_GCC=./../../miscTools/gcc/bin/g++
COLLECT_LTO_WRAPPER=/media/lingsrv/exp//miscTools/gcc/libexec/gcc/x86_64-unknown-linux-gnu/5.2.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ./configure --prefix=/media/lingsrv/exp//miscTools/gcc
--with-gmp=/media/lingsrv/exp/mbarnabe/miscTools/gmp_install/
--with-mpc=/media/lingsrv/exp//miscTools/mpc_install/
--with-mpfr=/media/lingsrv/exp//miscTools/mpfr_install/
Thread model: posix
gcc version 5.2.0 (GCC)

 uname -a
Linux technolin01 3.2.0-4-amd64 #1 SMP Debian 3.2.57-3 x86_64 GNU/Linux


CFLAGS = -D WEIGHTTYPE=float -lm -D THREAD  -O2 -Wall -ffast-math -fcilkplus
-std=c++11


rnnlmlib.cpp:1115:1: internal compiler error: in find_rank, at
c-family/array-notation-common.c:244
 }
 ^
0x74d4bc find_rank(unsigned int, tree_node*, tree_node*, bool, unsigned long*)
        ../.././gcc/c-family/array-notation-common.c:244
0x74d118 find_rank(unsigned int, tree_node*, tree_node*, bool, unsigned long*)
        ../.././gcc/c-family/array-notation-common.c:317
0x74d118 find_rank(unsigned int, tree_node*, tree_node*, bool, unsigned long*)
        ../.././gcc/c-family/array-notation-common.c:317
0x74d118 find_rank(unsigned int, tree_node*, tree_node*, bool, unsigned long*)
        ../.././gcc/c-family/array-notation-common.c:317
0x74d118 find_rank(unsigned int, tree_node*, tree_node*, bool, unsigned long*)
        ../.././gcc/c-family/array-notation-common.c:317
0x6f37de cp_expand_cond_array_notations
        ../.././gcc/cp/cp-array-notation.c:852
0x6f541f expand_array_notation_exprs(tree_node*)
        ../.././gcc/cp/cp-array-notation.c:1292
0x6f52e8 expand_array_notation_exprs(tree_node*)
        ../.././gcc/cp/cp-array-notation.c:1212
0x6f5633 expand_array_notation_exprs(tree_node*)
        ../.././gcc/cp/cp-array-notation.c:1185
0x6f5633 expand_array_notation_exprs(tree_node*)
        ../.././gcc/cp/cp-array-notation.c:1185
0x6f071f cp_genericize(tree_node*)
        ../.././gcc/cp/cp-gimplify.c:1406
0x60d75a finish_function(int)
        ../.././gcc/cp/decl.c:14328
0x6800e5 cp_parser_function_definition_after_declarator
        ../.././gcc/cp/parser.c:23527
0x680fe0 cp_parser_function_definition_from_specifiers_and_declarator
        ../.././gcc/cp/parser.c:23433
0x680fe0 cp_parser_init_declarator
        ../.././gcc/cp/parser.c:17096
0x681dd3 cp_parser_simple_declaration
        ../.././gcc/cp/parser.c:11607
0x66a033 cp_parser_block_declaration
        ../.././gcc/cp/parser.c:11481
0x6641e9 cp_parser_declaration
        ../.././gcc/cp/parser.c:11378
0x68af3a cp_parser_declaration_seq_opt
        ../.././gcc/cp/parser.c:11264
0x68b24f cp_parser_translation_unit
        ../.././gcc/cp/parser.c:4100
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug c/63336] cilkplus array notation ICE in find_rank

[barnabe.marc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

--- Comment #3 from Marc <barnabe.marc at gmail dot com> ---
Created attachment 36197
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36197&action=edit
GCC 5.2 preprocessed ICE code

xz file, because .ii is > 2 MB in size.

[Bug c/63336] cilkplus array notation ICE in find_rank

[bviyer at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

Balaji V. Iyer <bviyer at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bviyer at gmail dot com

--- Comment #4 from Balaji V. Iyer <bviyer at gmail dot com> ---
Hi Tim,
    Can you provide me a simple(r) test case for this?

Thanks,

Balaji V. Iyer.

[Bug c/63336] cilkplus array notation ICE in find_rank

[tprince at computer dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

--- Comment #5 from tprince at computer dot org ---
Created attachment 36294
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36294&action=edit
shortened c code

C source with external function calls removed

[Bug c/63336] cilkplus array notation ICE in find_rank

[tprince at computer dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

--- Comment #6 from tprince at computer dot org ---
Created attachment 36295
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36295&action=edit
pre-processed C source

pre-processed, without function calls

[Bug c/63336] cilkplus array notation ICE in find_rank

[jtamagnan at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63336

jtamagnan at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jtamagnan at gmail dot com

--- Comment #7 from jtamagnan at gmail dot com ---
I had the same error with the following code:

> class test{
> public:
>   int arr[2][2][2];
> 
>   test()
>   {
>     arr[0:2][0:2][0:2] = 1;
>   }
> };
> 
> 
> int main(){
>   test t;
>   return 1;
> }

And compiling with

> gcc cilk_test.cc -std-gnu++11 -fcilkplus

with gcc version: 

> gcc (Debian 5.2.1-21) 5.2.1 20151003

The full output from the compiler was:

> cilk_test.cc: In constructor ‘test::test()’:
> cilk_test.cc:8:3: internal compiler error: in find_rank, at c-family/array-notation-common.c:244
>    }
>    ^
> 0x7567cc find_rank(unsigned int, tree_node*, tree_node*, bool, unsigned long*)
>         ../../src/gcc/c-family/array-notation-common.c:244
> 0x6fd22b expand_an_in_modify_expr
>         ../../src/gcc/cp/cp-array-notation.c:576
> 0x6fe677 expand_array_notation_exprs(tree_node*)
>         ../../src/gcc/cp/cp-array-notation.c:1172
> 0x6fe4f8 expand_array_notation_exprs(tree_node*)
>         ../../src/gcc/cp/cp-array-notation.c:1252
> 0x6fe4f8 expand_array_notation_exprs(tree_node*)
>         ../../src/gcc/cp/cp-array-notation.c:1252
> 0x6fe4f8 expand_array_notation_exprs(tree_node*)
>         ../../src/gcc/cp/cp-array-notation.c:1252
> 0x6fe6c3 expand_array_notation_exprs(tree_node*)
>         ../../src/gcc/cp/cp-array-notation.c:1185
> 0x6f97af cp_genericize(tree_node*)
>         ../../src/gcc/cp/cp-gimplify.c:1406
> 0x61652a finish_function(int)
>         ../../src/gcc/cp/decl.c:14328
> 0x6890e5 cp_parser_function_definition_after_declarator
>         ../../src/gcc/cp/parser.c:23528
> 0x690e1c cp_parser_late_parsing_for_member
>         ../../src/gcc/cp/parser.c:24205
> 0x6703fd cp_parser_class_specifier_1
>         ../../src/gcc/cp/parser.c:20082
> 0x6703fd cp_parser_class_specifier
>         ../../src/gcc/cp/parser.c:20108
> 0x6703fd cp_parser_type_specifier
>         ../../src/gcc/cp/parser.c:14727
> 0x6851e7 cp_parser_decl_specifier_seq
>         ../../src/gcc/cp/parser.c:11958
> 0x68abf1 cp_parser_simple_declaration
>         ../../src/gcc/cp/parser.c:11535
> 0x673023 cp_parser_block_declaration
>         ../../src/gcc/cp/parser.c:11482
> 0x66d1d9 cp_parser_declaration
>         ../../src/gcc/cp/parser.c:11379
> 0x693f4a cp_parser_declaration_seq_opt
>         ../../src/gcc/cp/parser.c:11265
> 0x69425f cp_parser_translation_unit
>         ../../src/gcc/cp/parser.c:4100
> Please submit a full bug report,
> with preprocessed source if appropriate.
> Please include the complete backtrace with any bug report.
> See <file:///usr/share/doc/gcc-5/README.Bugs> for instructions.
>From gcc-bugs-return-500953-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 29 19:38:37 2015
Return-Path: <gcc-bugs-return-500953-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32910 invoked by alias); 29 Oct 2015 19:38:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32439 invoked by uid 55); 29 Oct 2015 19:38:32 -0000
From: "kargl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/67805] ICE on array constructor with wrong character specification
Date: Thu, 29 Oct 2015 19:38:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.2.1
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: kargl at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: kargl at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-67805-4-EzITa1TI6U@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-67805-4@http.gcc.gnu.org/bugzilla/>
References: <bug-67805-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-10/txt/msg02508.txt.bz2
Content-length: 1937

https://gcc.gnu.org/bugzilla/show_bug.cgi?idg805

--- Comment #6 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Thu Oct 29 19:37:59 2015
New Revision: 229553

URL: https://gcc.gnu.org/viewcvs?rev"9553&root=gcc&view=rev
Log:
2015-10-29  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/67805
        PR fortran/68108
        * array.c (gfc_match_array_constructor): Check for error from type
        spec matching.
        * decl.c (char_len_param_value): Check for valid of charlen parameter.
        Check for REF_ARRAY.  Reap dead code dating to 2008.
        match.c (gfc_match_type_spec): Special case the keyword use in REAL.

2015-10-29  Steven G. Kargl  <kargl@gcc.gnu.org>

        PR fortran/67805
        PR fortran/68108
        * gfortran.dg/pr67805.f90: New testcase.
        * gfortran.dg/pr67805_2.f90: New test.
        * gfortran.dg/array_constructor_26.f03: Update testcase.
        * gfortran.dg/array_constructor_27.f03: Ditto.
        * gfortran.dg/char_type_len_2.f90: Ditto.
        * gfortran.dg/pr67802.f90: Ditto.
        * gfortran.dg/used_before_typed_3.f90: Ditto.

Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr67805.f90
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr67805_2.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/array.c
    branches/gcc-5-branch/gcc/fortran/decl.c
    branches/gcc-5-branch/gcc/fortran/match.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/array_constructor_26.f03
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/array_constructor_27.f03
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/char_type_len_2.f90
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/large_real_kind_3.F90
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr67802.f90
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/used_before_typed_3.f90