public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tejohnson at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/63432] [5 Regression] profiledbootstrap failure with bootstrap-lto
Date: Mon, 13 Oct 2014 21:33:00 -0000	[thread overview]
Message-ID: <bug-63432-4-NUOdL6kWau@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63432-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63432

--- Comment #28 from Teresa Johnson <tejohnson at google dot com> ---
On Mon, Oct 13, 2014 at 8:53 AM, hjl.tools at gmail dot com
<gcc-bugzilla@gcc.gnu.org> wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63432
>
> --- Comment #27 from H.J. Lu <hjl.tools at gmail dot com> ---
> (In reply to Teresa Johnson from comment #24)
>
>> Arg, looks very similar so maybe another instance of the duplicate
>> threading is slipping through? My own lto profiled bootstrap succeeded
>> with my patch. I will try updating to r216039 and redo it to see if I
>> can provoke the same failure.
>>
>
> I sent you another testcase against r216150.

Thanks for the testcase, I reproduced it. It is a case of garbage in /
garbage out. The fre2 pass is introducing some big profile count
insanities, leading to the probability insanity being introduced when
we try to use the counts to compute the new probability in
recompute_probabilities. There is already handling for really large
probabilities due to this issue, and we need to add the same thing for
negative probabilities - essentially the patch you had originally
suggested for the first problem which wasn't necessary for that one
since that was an actually jump threading induced issue.

Will test that and send for review.

>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.


  parent reply	other threads:[~2014-10-13 21:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-63432-4@http.gcc.gnu.org/bugzilla/>
2014-10-01 16:25 ` tejohnson at google dot com
2014-10-03 15:59 ` hjl.tools at gmail dot com
2014-10-03 16:14 ` tejohnson at google dot com
2014-10-03 17:27 ` tejohnson at google dot com
2014-10-03 18:28 ` tejohnson at google dot com
2014-10-03 19:48 ` hjl.tools at gmail dot com
2014-10-03 19:58 ` hjl.tools at gmail dot com
2014-10-03 20:18 ` tejohnson at google dot com
2014-10-03 20:23 ` hjl.tools at gmail dot com
2014-10-03 22:35 ` tejohnson at google dot com
2014-10-04  6:16 ` tejohnson at google dot com
2014-10-04 15:34 ` tejohnson at google dot com
2014-10-04 19:30 ` tejohnson at google dot com
2014-10-07 15:54 ` tejohnson at google dot com
2014-10-07 18:09 ` law at redhat dot com
2014-10-07 18:58 ` tejohnson at google dot com
2014-10-09  4:39 ` tejohnson at gcc dot gnu.org
2014-10-09 20:38 ` tejohnson at google dot com
2014-10-10  2:12 ` tejohnson at google dot com
2014-10-10 15:15 ` hjl.tools at gmail dot com
2014-10-13 15:53 ` hjl.tools at gmail dot com
2014-10-13 21:33 ` tejohnson at google dot com [this message]
2014-10-14 14:42 ` tejohnson at google dot com
2014-10-15 15:46 ` tejohnson at gcc dot gnu.org
2014-11-19 13:30 ` rguenth at gcc dot gnu.org
2014-11-24 13:36 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63432-4-NUOdL6kWau@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).