[Bug c/63434] New: builtins.c has incorrect parameters for GEN_CALL_VALUE

[Bug c/63434] New: builtins.c has incorrect parameters for GEN_CALL_VALUE

[steve at hearnden dot org.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63434

            Bug ID: 63434
           Summary: builtins.c has incorrect parameters for GEN_CALL_VALUE
           Product: gcc
           Version: 4.8.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: steve at hearnden dot org.uk

When trying to compile a new machine description, I found that testsuite
testsuite/gcc.c-torture/compile/930623-1.c was crashing.  The machine
description needs a 4th parameter to be added.

On investigation of the cause, my 4th parameter to the call function (number of
registers) had been set to NULL.  With some searching, it appears that the
builtins don't work when the 4th Parameter is added, or require it to be
specially coded.  I believe the correct fix is described below - switching the
last two parameters



       emit_call_insn (GEN_CALL_VALUE (valreg,
                                      gen_rtx_MEM (FUNCTION_MODE, function),
-                                     const0_rtx, NULL_RTX, const0_rtx));
+                                     const0_rtx,  const0_rtx, NULL_RTX));

[Bug middle-end/63434] builtins.c has incorrect parameters for GEN_CALL_VALUE

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63434

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Patches should be sent to gcc-patches@

[Bug middle-end/63434] builtins.c has incorrect parameters for GEN_CALL_VALUE

[steve at hearnden dot org.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63434

--- Comment #2 from steve at hearnden dot org.uk ---
(In reply to Richard Biener from comment #1)
> Patches should be sent to gcc-patches@

I was trying to be sure that my understanding was correct before posting my
fix.  I have since found in the mmix config, a work around for what appears to 
be this bug, so I am fairly sure I am on the right lines.  If someone could
validate what the 4th and 5th parameters are meant to be, then I can post my
fix.

[Bug middle-end/63434] builtins.c has incorrect parameters for GEN_CALL_VALUE

[steve at hearnden dot org.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63434

--- Comment #3 from steve at hearnden dot org.uk ---
How do I get this bug confirmed?

[Bug middle-end/63434] builtins.c has incorrect parameters for GEN_CALL_VALUE

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63434

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Keywords|                            |ice-on-valid-code,
                   |                            |internal-improvement
   Last reconfirmed|                            |2021-08-28
             Status|UNCONFIRMED                 |NEW

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Still broken:
      emit_insn (targetm.gen_call_value (valreg,
                                         gen_rtx_MEM (FUNCTION_MODE, function),
                                         const0_rtx, NULL_RTX, const0_rtx));