[Bug libstdc++/63500] New: bug in debug version of std::make_move_iterator?

[Bug libstdc++/63500] New: bug in debug version of std::make_move_iterator?

[vermaelen.wouter at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

            Bug ID: 63500
           Summary: bug in debug version of std::make_move_iterator?
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vermaelen.wouter at gmail dot com

Is the following a bug in the debug version of std::make_move_iterator or is it
a bug in my code? It compiles fine with older gcc versions (both debug and
non-debug). But when using a fairly recent gcc-5.0 snapshot it fails to compile
when using -D_GLIBCXX_DEBUG, non-debug mode works fine.

---- 8< -------- 8< -------- 8< -------- 8< -------- 8< ----

// Compiles fine with:
//   g++-4.8      -std=c++11 -c -D_GLIBCXX_DEBUG bug.cc
//   g++-snapshot -std=c++11 -c                  bug.cc
// But this fails:
//   g++-snapshot -std=c++11 -c -D_GLIBCXX_DEBUG bug.cc

#include <iterator>
#include <memory>
#include <vector>

class Foo {};

std::vector<std::unique_ptr<Foo>> v;
std::vector<std::unique_ptr<Foo>> w;

void test() {
    v.insert(end(v),
             make_move_iterator(begin(w)),
             make_move_iterator(end  (w)));
}

[Bug libstdc++/63500] bug in debug version of std::make_move_iterator?

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

--- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> ---
(In reply to Wouter Vermaelen from comment #0)
> Is the following a bug in the debug version of std::make_move_iterator or is
> it a bug in my code? It compiles fine with older gcc versions (both debug
> and non-debug).

Hmm, earlier this year I modified move_iterator without touching the debug
version (I hadn't realized it existed), that could be related.

[Bug libstdc++/63500] [4.9/5 Regression] bug in debug version of std::make_move_iterator?

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-10-09
            Summary|bug in debug version of     |[4.9/5 Regression] bug in
                   |std::make_move_iterator?    |debug version of
                   |                            |std::make_move_iterator?
     Ever confirmed|0                           |1

--- Comment #2 from Marc Glisse <glisse at gcc dot gnu.org> ---
Ah, no, not my fault. The debug machinery wants at some point
__addressof(*iter) but addressof wants an lvalue reference so it is not happy
with a move iterator.

Note that the error message is confusing:

error: invalid initialization of non-const reference of type
'std::unique_ptr<Foo>&' from an rvalue of type 'std::unique_ptr<Foo>'

when it is really an xvalue of type unique_ptr<Foo>&&.

[Bug libstdc++/63500] [4.9/5 Regression] bug in debug version of std::make_move_iterator?

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fdumont at gcc dot gnu.org

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
François, is there a quick fix for this?
>From gcc-bugs-return-463706-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 09 19:01:49 2014
Return-Path: <gcc-bugs-return-463706-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 4255 invoked by alias); 9 Oct 2014 19:01:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 4216 invoked by uid 55); 9 Oct 2014 19:01:45 -0000
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libquadmath/63488] large errors in y0q
Date: Thu, 09 Oct 2014 19:01:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libquadmath
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: sgk at troutmask dot apl.washington.edu
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63488-4-3T4XN1s2me@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63488-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63488-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg00727.txt.bz2
Content-length: 1884

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc488

--- Comment #8 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Oct 09, 2014 at 06:27:08PM +0000, zimmerma+gcc at loria dot fr wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?idc488
>
> --- Comment #7 from Paul Zimmermann <zimmerma+gcc at loria dot fr> ---
> I agree that near zeroes we can expect large errors. However for
> other functions I got only small errors in ulps, maybe I was unlucky.
> Also the ultimate goal is to get correct rounding, even near zeroes.
>

I suspect you got lucky :-)  IIRC my testing correctly,
exhaustive testing of values in each interval shows
lgammaf(x) for x < 0 and not an integer also has major
accuracy issues:

Interval:                     Max ULP     Value
[-1.10000e+01, -1.00000e+01): 6.72889 -1.0000009e+01
[-1.00000e+01, -9.00000e+00): 83.4928 -9.0000029e+00
[-9.00000e+00, -8.00000e+00): 24615.2 -8.0000248e+00
[-8.00000e+00, -7.00000e+00): 22575.7 -7.9999752e+00
[-7.00000e+00, -6.00000e+00): 100393. -6.0013852e+00
[-6.00000e+00, -5.00000e+00): 36966.5 -5.0082183e+00
[-5.00000e+00, -4.00000e+00): 324309. -4.0393620e+00
[-4.00000e+00, -3.00000e+00): 2981098 -3.1435809e+00
[-3.00000e+00, -2.00000e+00): 7497618 -2.4570248e+00
[-2.00000e+00, -1.00000e+00): 4.18718 -1.7313151e+00
[-1.00000e+00, -4.76837e-07): 3.46651 -3.5002786e-01

troutmask:fvwm:kargl[209] ./testf -a -3.1435809e+00
libm: -2.38418579e-07, 1
mpfr: -1.96054615e-07, 1

The relevant code in testf is (RND is round-to-nearest).

            x = (float)strtof(optarg, NULL);
            y = lgammaf_r(x,&s);
            mpfr_inits2(DBL_MANT_DIG, t1, t2, NULL);
            mpfr_set_d(t1, (double)x, RND);
            mpfr_lgamma(t2, &si, t1, RND);
            printf("libm: %.8e, %d\n", y, s);
            mpfr_printf("mpfr: %.8Re, %d\n", t2, si);
            mpfr_clears(t1, t2, NULL);

[Bug libstdc++/63500] [4.9/5 Regression] bug in debug version of std::make_move_iterator?

[fdumont at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

--- Comment #6 from François Dumont <fdumont at gcc dot gnu.org> ---
Sorry, I reproduced the problem and it is not in _Safe_iterator operator-> so
my previous remark is out of subject.
>From gcc-bugs-return-463802-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Oct 10 20:37:11 2014
Return-Path: <gcc-bugs-return-463802-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7382 invoked by alias); 10 Oct 2014 20:37:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7332 invoked by uid 48); 10 Oct 2014 20:37:07 -0000
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/63415] [4.9/5 Regression] internal compiler error:=?UTF-8?Q? unexpected expression ‘static_cast?=<int>(std::is_same<T, A1>{})=?UTF-8?Q?’ of kind static_cast_expr?Date: Fri, 10 Oct 2014 20:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jason at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jason at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.2
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution assigned_to
Message-ID: <bug-63415-4-JYD7eFTpSU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63415-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63415-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg00823.txt.bz2
Content-length: 503

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc415

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed.

[Bug libstdc++/63500] [4.9/5 Regression] bug in debug version of std::make_move_iterator?

[fdumont at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

--- Comment #7 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Wed Oct 15 20:40:31 2014
New Revision: 216286

URL: https://gcc.gnu.org/viewcvs?rev=216286&root=gcc&view=rev
Log:
2014-10-15  François Dumont  <fdumont@gcc.gnu.org>
        Jonathan Wakely  <jwakely@redhat.com>

    PR libstdc++/63500
    * include/debug/functions.h (__foreign_iterator_aux2): Do not check for
    foreign iterators if input iterators returns rvalue reference.
    * testsuite/23_containers/vector/63500.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/23_containers/vector/63500.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/debug/functions.h
>From gcc-bugs-return-464176-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 15 20:44:30 2014
Return-Path: <gcc-bugs-return-464176-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31186 invoked by alias); 15 Oct 2014 20:44:30 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31130 invoked by uid 48); 15 Oct 2014 20:44:26 -0000
From: "fdumont at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/63500] [4.9/5 Regression] bug in debug version of std::make_move_iterator?
Date: Wed, 15 Oct 2014 20:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fdumont at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution target_milestone
Message-ID: <bug-63500-4-H4kVjuZYFm@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63500-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63500-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg01197.txt.bz2
Content-length: 594

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

François Dumont <fdumont at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.0

--- Comment #8 from François Dumont <fdumont at gcc dot gnu.org> ---
For now we just skip the check when input iterator do not expose lvalue
reference.

Thanks for the report.
>From gcc-bugs-return-464177-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 15 21:09:39 2014
Return-Path: <gcc-bugs-return-464177-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21335 invoked by alias); 15 Oct 2014 21:09:39 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21268 invoked by uid 55); 15 Oct 2014 21:09:34 -0000
From: "paolo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/53000] Conditional operator does not behave as standardized
Date: Wed, 15 Oct 2014 21:09:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.7.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: paolo at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-53000-4-77awX6kZOW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-53000-4@http.gcc.gnu.org/bugzilla/>
References: <bug-53000-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg01198.txt.bz2
Content-length: 569

https://gcc.gnu.org/bugzilla/show_bug.cgi?idS000

--- Comment #30 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> ---
Author: paolo
Date: Wed Oct 15 21:08:59 2014
New Revision: 216287

URL: https://gcc.gnu.org/viewcvs?rev!6287&root=gcc&view=rev
Log:
2014-10-15  Daniel Krugler  <daniel.kruegler@gmail.com>

    * testsuite/20_util/common_type/requirements/sfinae_friendly_1.cc:
    Enable tests predicated on PR c++/53000.


Modified:
    trunk/libstdc++-v3/ChangeLog

trunk/libstdc++-v3/testsuite/20_util/common_type/requirements/sfinae_friendly_1.cc

[Bug libstdc++/63500] [4.9/5 Regression] bug in debug version of std::make_move_iterator?

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63500

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dushistov at mail dot ru

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 63711 has been marked as a duplicate of this bug. ***