public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ccoutant at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/63504] [5 Regression] Issues found by --enable-checking=valgrind
Date: Tue, 27 Jan 2015 20:17:00 -0000	[thread overview]
Message-ID: <bug-63504-4-DH0daM6SOy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63504-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63504

--- Comment #14 from ccoutant at google dot com ---
> But then there is (question mainly on Cary) the .debug_types checksumming:
>
>     case dw_val_class_const_double:
>       CHECKSUM_ULEB128 (DW_FORM_block);
>       CHECKSUM_ULEB128 (sizeof (at->dw_attr_val.v.val_double));
>       CHECKSUM (at->dw_attr_val.v.val_double);
>       break;
>
>     case dw_val_class_wide_int:
>       CHECKSUM_ULEB128 (DW_FORM_block);
>       CHECKSUM_ULEB128 (sizeof (*at->dw_attr_val.v.val_wide));
>       CHECKSUM (*at->dw_attr_val.v.val_wide);
>       break;
>
> and that one ought to be governed by the DWARF standard, so I wonder how it can
> get away without converting for endianity etc.

There shouldn't be any location lists in .debug_types, so I don't
think the DWARF standard really matters for this case, and it would be
reasonable to use the same hashing you use for other purposes. Some
may slip through, unfortunately, so I covered this case just for
completeness.

-cary


  parent reply	other threads:[~2015-01-27 20:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10  6:34 [Bug other/63504] New: " trippels at gcc dot gnu.org
2014-10-10  7:35 ` [Bug other/63504] " rguenth at gcc dot gnu.org
2014-10-10  7:37 ` trippels at gcc dot gnu.org
2014-10-10  8:53 ` trippels at gcc dot gnu.org
2014-10-10  9:03 ` trippels at gcc dot gnu.org
2014-10-11  8:04 ` trippels at gcc dot gnu.org
2014-10-11  8:04 ` trippels at gcc dot gnu.org
2014-10-12 14:16 ` trippels at gcc dot gnu.org
2014-10-12 18:13 ` trippels at gcc dot gnu.org
2014-11-20 12:14 ` rguenth at gcc dot gnu.org
2015-01-26 17:57 ` jakub at gcc dot gnu.org
2015-01-26 18:35 ` jakub at gcc dot gnu.org
2015-01-27 19:24 ` jakub at gcc dot gnu.org
2015-01-27 20:17 ` ccoutant at google dot com [this message]
2015-01-28 20:31 ` jakub at gcc dot gnu.org
2015-02-03  9:40 ` jakub at gcc dot gnu.org
2015-02-03  9:40 ` jakub at gcc dot gnu.org
2015-03-09 20:49 ` trippels at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63504-4-DH0daM6SOy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).