[Bug sanitizer/63559] New: -fsanitize=thread sets no preprocessor flags

[Bug sanitizer/63559] New: -fsanitize=thread sets no preprocessor flags

[rogero at howzatt dot demon.co.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63559

            Bug ID: 63559
           Summary: -fsanitize=thread sets no preprocessor flags
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rogero at howzatt dot demon.co.uk
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

When -fsanitize=address is supplied the builtin __SANITIZE_ADDRESS__ is
defined. There does not appear to be an equivalent for -fsanitize=thread, which
could be used for conditionally compiling code to avoid tsan reporting false
positives.

[Bug sanitizer/63559] -fsanitize=thread sets no preprocessor flags

[dvyukov at google dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63559

Dmitry Vyukov <dvyukov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dvyukov at google dot com

--- Comment #1 from Dmitry Vyukov <dvyukov at google dot com> ---
Hi Roger,

Please also report the false positives themselves to
thread-sanitizer@googlegroups.com or
https://groups.google.com/forum/#!forum/thread-sanitizer

We would like to fix them as well.

[Bug sanitizer/63559] -fsanitize=thread sets no preprocessor flags

[rogero at howzatt dot demon.co.uk]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63559

--- Comment #2 from Roger Orr <rogero at howzatt dot demon.co.uk> ---
Hi Dmitry,
the false positives I've investigated seem to be down to spin-locked queues and
use of intel tbb concurrency data structures - AFAICT we don't have source for
the latter so I wouldn't expect tsan to resolve either of them.

[Bug sanitizer/63559] -fsanitize=thread sets no preprocessor flags

[dvyukov at google dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63559

--- Comment #3 from Dmitry Vyukov <dvyukov at google dot com> ---
Ah, OK, thanks.

FWIW, TBB is open-source. However it uses hand-rolled atomic operations, so
tsan won't work out-of-the box anyway.

[Bug sanitizer/63559] -fsanitize=thread sets no preprocessor flags

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63559

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |7.0
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed for GCC 7 by r7-886-gf3510625cf2035 so this is a dup of PR 64354.

*** This bug has been marked as a duplicate of bug 64354 ***