[Bug ipa/63566] New: [5 Regression] i686 bootstrap fails: ICE RTL flag check: INSN_UID used with unexpected rtx code 'set' in INSN_UID, at rtl.h:1326

["mliska at suse dot cz" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63566

            Bug ID: 63566
           Summary: [5 Regression] i686 bootstrap fails: ICE RTL flag
                    check: INSN_UID used with unexpected rtx code 'set' in
                    INSN_UID, at rtl.h:1326
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mliska at suse dot cz

After introduction of IPA ICF in r216305, i686 fails to bootstrap.
I reduced IPA ICF to just merge a single function:
Semantic equality hit:void mark_oprs_set(rtx_insn*)->void
make_set_regs_unavailable(rtx_insn*).

With this change applied, stage2 compiler is miscompiled and following error
occurs:
../../../libgcc/config/libbid/bid_round.c: In function ‘__bid_round64_2_18’:
../../../libgcc/config/libbid/bid_round.c:210:1: internal compiler error: RTL
flag check: INSN_UID used with unexpected rtx code 'set' in INSN_UID, at
rtl.h:1326

Comparison of object files (compiled with stage1 compiler with and w/o
-fipa-icf) show following difference:

With IPA ICF (cprop.o):
contains .set
_ZL25make_set_regs_unavailableP8rtx_insn,_ZL13mark_oprs_setP8rtx_insn

and the only difference is in usage of the function (IPA ICF):
.L633:
    subl    $12, %esp
    .cfi_def_cfa_offset 108
    pushl    %ebx
    .cfi_def_cfa_offset 112
    call    _ZL25make_set_regs_unavailableP8rtx_insn
    movzwl    (%ebx), %edx
    addl    $16, %esp
    .cfi_def_cfa_offset 96
    cmpb    $0, rtx_length(%edx)
    jne    .L643

while original usage (-fno-ipa-icf) contains:
.L644:
    movl    %ebx, %eax
    call    _ZL25make_set_regs_unavailableP8rtx_insn
    movzwl    (%ebx), %edx
    cmpb    $0, rtx_length(%edx)
    jne    .L654

I am not familiar with x86 calling conventions for aliases, but I suspect this
chunk of code.

Does anyone can see a problem in this chunk?
Thank you for help,
Martin
>From gcc-bugs-return-464291-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 16 22:19:28 2014
Return-Path: <gcc-bugs-return-464291-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6801 invoked by alias); 16 Oct 2014 22:19:28 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6780 invoked by uid 48); 16 Oct 2014 22:19:24 -0000
From: "mliska at suse dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/63566] [5 Regression] i686 bootstrap fails: ICE RTL flag check: INSN_UID used with unexpected rtx code 'set' in INSN_UID, at rtl.h:1326
Date: Thu, 16 Oct 2014 22:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mliska at suse dot cz
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-63566-4-GoM9gK6hjF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63566-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63566-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg01312.txt.bz2
Content-length: 279

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63566

--- Comment #1 from Martin Liška <mliska at suse dot cz> ---
Created attachment 33738
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33738&action=edit
Patch that enables just a single function merge operation.
>From gcc-bugs-return-464292-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Oct 16 22:20:11 2014
Return-Path: <gcc-bugs-return-464292-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7652 invoked by alias); 16 Oct 2014 22:20:10 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7583 invoked by uid 48); 16 Oct 2014 22:20:07 -0000
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63534] [5 Regression] Bootstrap failure on x86_64/i686-linux
Date: Thu, 16 Oct 2014 22:20:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63534-4-7aY3iJ7ouN@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63534-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63534-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg01313.txt.bz2
Content-length: 983

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc534

--- Comment #22 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #17)
> (In reply to Dominique d'Humieres from comment #16)
> > > Created attachment 33733 [details]
> > > patch to fix darwin bootstrap
> > >
> > > With pseudo GOT register we don't need to set GOT register after any jump,
> > > and therefore don't need "nonlocal_goto_receiver" and "builtin_setjmp_receiver"
> > > for i386.
> > >
> > > Please try attached patch (just removing "nonlocal_goto_receiver" and
> > > "builtin_setjmp_receiver" from i386.md).
> >
> > With the patch bootstrap fails with
>
> > ld: illegal text reloc in 'std::strstream::strstream()' to 'construction
> > vtable for std::basic_ostream<char, std::char_traits<char>
> > >-in-std::strstream' for architecture x86_64
> > collect2: error: ld returned 1 exit status

This fail above ^ is caused by r216305 (which seems to be being investigated
elsewhere)