[Bug tree-optimization/63593] New: ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[Bug tree-optimization/63593] New: ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

            Bug ID: 63593
           Summary: ICE: verify_gimple failed: incompatible types in PHI
                    argument 0 with -O3 -fno-tree-vectorize
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz

Created attachment 33757
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33757&action=edit
reduced testcase

Compiler output [5.0]:
$ gcc -O3 -fno-tree-vectorize testcase.c 
testcase.c: In function 'foo':
testcase.c:5:1: error: incompatible types in PHI argument 0
 foo (void)
 ^
int

unsigned int

_101 = PHI <ivtmp_136(3)>
testcase.c:5:1: internal compiler error: verify_gimple failed
0xbecd3e verify_gimple_in_cfg(function*, bool)
        /mnt/svn/gcc-trunk/gcc/tree-cfg.c:5025
0xabbad6 execute_function_todo
        /mnt/svn/gcc-trunk/gcc/passes.c:1755
0xabc513 execute_todo
        /mnt/svn/gcc-trunk/gcc/passes.c:1812
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.


Compiler output [4.9/4.8/4.7]:
$ gcc -O3 -fno-tree-vectorize testcase.c      
testcase.c: In function 'foo':
testcase.c:5:1: error: no immediate_use list
 foo (void)
 ^
for SSA_NAME: _15 in statement:
_5 = PHI <pretmp_99(8), _15(4)>
PHI argument
_15
for PHI node
_5 = PHI <pretmp_99(8), _15(4)>
testcase.c:5:1: internal compiler error: verify_ssa failed
0xce6d1b verify_ssa(bool)
        /mnt/svn/gcc-4_9/gcc/tree-ssa.c:1096
0xc60286 verify_loop_closed_ssa(bool)
        /mnt/svn/gcc-4_9/gcc/tree-ssa-loop-manip.c:601
0xc6069f gimple_duplicate_loop_to_header_edge(loop*, edge_def*, unsigned int,
simple_bitmap_def*, edge_def*, vec<edge_def*, va_heap, vl_ptr>*, int)
        /mnt/svn/gcc-4_9/gcc/tree-ssa-loop-manip.c:772
0xc610d7 tree_transform_and_unroll_loop(loop*, unsigned int, edge_def*,
tree_niter_desc*, void (*)(loop*, void*), void*)
        /mnt/svn/gcc-4_9/gcc/tree-ssa-loop-manip.c:1190
0xbd6a14 tree_predictive_commoning_loop
        /mnt/svn/gcc-4_9/gcc/tree-predcom.c:2517
0xbd6a14 tree_predictive_commoning()
        /mnt/svn/gcc-4_9/gcc/tree-predcom.c:2552
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.


Compiler output [4.6]:
$ gcc -O3 -fno-tree-vectorize testcase.c -wrapper valgrind,-q
==21897== Invalid read of size 2
==21897==    at 0x742BBC: is_gimple_reg_type (gimple.c:2818)
==21897==    by 0x742BBC: is_gimple_val (gimple.c:2886)
==21897==    by 0x8E76E5: verify_gimple_phi (tree-cfg.c:3938)
==21897==    by 0x8F3497: verify_stmts (tree-cfg.c:4330)
==21897==    by 0xA0A50C: verify_ssa (tree-ssa.c:920)
==21897==    by 0x9B6DC3: verify_loop_closed_ssa (tree-ssa-loop-manip.c:456)
==21897==    by 0x9B72DC: gimple_duplicate_loop_to_header_edge
(tree-ssa-loop-manip.c:622)
==21897==    by 0x9B7C9D: tree_transform_and_unroll_loop
(tree-ssa-loop-manip.c:1046)
==21897==    by 0x945094: tree_predictive_commoning_loop (tree-predcom.c:2543)
==21897==    by 0x946390: tree_predictive_commoning (tree-predcom.c:2580)
==21897==    by 0x7F5B75: execute_one_pass (passes.c:1556)
==21897==    by 0x7F5E74: execute_pass_list (passes.c:1611)
==21897==    by 0x7F5E86: execute_pass_list (passes.c:1612)
==21897==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==21897== 
testcase.c: In function 'foo':
testcase.c:5:1: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r216429 - ICE
4_9 r213788 - ICE
4_8 r213789 - ICE
4_7 r211571 - ICE
4_6 r197894 - ICE

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-24
                 CC|                            |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.8.4
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
It appears this is a predcom bug.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
So it seems like tree_transform_and_unroll_loop creates a wrong PHI:
_101 = PHI <pretmp_103(8), ivtmp_47(4)>
where the type of _101 and pretmp_103 is int, and ivtmp_47 is unsigned.  How
that ivtmp_47 gets there is a mystery to me, but it happens during
duplicate_block.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Ok, one issue is that predictive commoning removes statements and releases
SSA names while they are still in use, and then allocates new SSA names before
eventually releasing the using stmts.

Delaying that keeps released SSA names in the IL (better than filled with
invalid re-used ones) after the transform callback.  Now we enter
gimple_duplicate_loop_to_header_edge with that "invalid" IL...

But at least it fixes this testcase and the related one.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Mon Feb 16 14:52:14 2015
New Revision: 220734

URL: https://gcc.gnu.org/viewcvs?rev=220734&root=gcc&view=rev
Log:
2015-02-16  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/63593
    * tree-predcom.c (execute_pred_commoning_chain): Delay removing
    stmts and releasing SSA names until...
    (execute_pred_commoning): ... after processing all chains.

    * gcc.dg/pr63593.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/pr63593.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-predcom.c

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |5.0
      Known to fail|5.0                         |

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Fri Feb 20 07:32:08 2015
New Revision: 220835

URL: https://gcc.gnu.org/viewcvs?rev=220835&root=gcc&view=rev
Log:
2015-02-20  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2015-01-12  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/64530
    * tree-loop-distribution.c (pg_add_dependence_edges): Shuffle
    back dr1.

    * gfortran.dg/pr64530.f90: New testcase.

    2015-02-13  Richard Biener  <rguenther@suse.de>

    PR lto/64373
    * lto-streamer-out.c (tree_is_indexable): Guard for NULL
    DECL_CONTEXT.

    * gcc.dg/lto/pr64373_0.c: New testcase.

    2015-02-16  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/63593
    * tree-predcom.c (execute_pred_commoning_chain): Delay removing
    stmts and releasing SSA names until...
    (execute_pred_commoning): ... after processing all chains.

    * gcc.dg/pr63593.c: New testcase.

    2015-02-18  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/65063
    * tree-predcom.c (determine_unroll_factor): Return 1 if we
    have replaced looparound PHIs.

    * gcc.dg/pr65063.c: New testcase.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/lto/pr64373_0.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr63593.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr65063.c
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/pr64530.f90
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/lto-streamer-out.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/tree-loop-distribution.c
    branches/gcc-4_9-branch/gcc/tree-predcom.c

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 47738 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Wed Feb 25 10:28:01 2015
New Revision: 220960

URL: https://gcc.gnu.org/viewcvs?rev=220960&root=gcc&view=rev
Log:
2015-02-25  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2015-02-16  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/63593
    * tree-predcom.c (execute_pred_commoning_chain): Delay removing
    stmts and releasing SSA names until...
    (execute_pred_commoning): ... after processing all chains.

    * gcc.dg/pr63593.c: New testcase.

    2015-02-18  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/65063
    * tree-predcom.c (determine_unroll_factor): Return 1 if we
    have replaced looparound PHIs.

    * gcc.dg/pr65063.c: New testcase.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/pr63593.c
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/pr65063.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-predcom.c

[Bug tree-optimization/63593] ICE: verify_gimple failed: incompatible types in PHI argument 0 with -O3 -fno-tree-vectorize

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63593

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |4.8.5
         Resolution|---                         |FIXED

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.