[Bug rtl-optimization/63618] New: CSE at IRA pass delete SET_GOT which is used later

[Bug rtl-optimization/63618] New: CSE at IRA pass delete SET_GOT which is used later

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

            Bug ID: 63618
           Summary: CSE at IRA pass delete SET_GOT which is used later
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: evstupac at gmail dot com

Test failed on execution compiled with:
gcc elim_set_got.c -fPIE -m32 -msse4.2 -O2 -fno-inline -mtune=corei7
./a.out
Segmentation fault (core dumped)

That occurs because CSE delete SET_GOT at IRA as it has no uses.
However the instruction:

(insn 20 17 21 3 (set (mem:TF (pre_dec:SI (reg/f:SI 7 sp)) [2  S16 A128])
        (const_double:TF 1.0e+9 [0x0.ee6b28p+30])) elim_setgot.c:26 121
{*pushtf} 
     (expr_list:REG_ARGS_SIZE (const_int 16 [0x10]) 
        (nil))) 

have hidden use of GOT register as it is split into:

(insn 45 47 46 3 (set (reg:SI 0 ax [92]) 
        (plus:SI (reg:SI 0 ax [87]) 
            (const:SI (unspec:SI [ 
                        (symbol_ref/u:SI ("*.LC2") [flags 0x2]) 
                    ] UNSPEC_GOTOFF)))) elim_setgot.c:26 213 {*leasi} 
     (expr_list:REG_EQUAL (symbol_ref/u:SI ("*.LC2") [flags 0x2]) 
        (nil))) 
(insn 46 45 20 3 (set (reg:TF 23 xmm2 [93]) 
        (mem/u/c:TF (reg:SI 0 ax [92]) [2  S16 A128])) elim_setgot.c:26 126
{*movtf_internal} 
     (nil))

[Bug rtl-optimization/63618] CSE at IRA pass delete SET_GOT which is used later

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

--- Comment #1 from Stupachenko Evgeny <evstupac at gmail dot com> ---
Created attachment 33780
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33780&action=edit
Reproducer

[Bug rtl-optimization/63618] CSE at IRA pass delete SET_GOT which is used later

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

--- Comment #2 from Stupachenko Evgeny <evstupac at gmail dot com> ---
Created attachment 33781
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33781&action=edit
leave SET_GOT while pic_offset_table_rtx is pseudo

[Bug rtl-optimization/63618] CSE at IRA pass delete SET_GOT which is used later

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at redhat dot com

--- Comment #3 from Jeffrey A. Law <law at redhat dot com> ---
Evgeny,

Can you post that patch for formal review along with a testcase,
bootstrap/regression test results, etc?

In general, if the patch isn't posted to gcc-patches then it's not going to get
reviewed and I really don't like having darwin (or any port for that matter)
broken this long.

[Bug rtl-optimization/63618] CSE at IRA pass delete SET_GOT which is used later

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

--- Comment #4 from Jeffrey A. Law <law at redhat dot com> ---
Ignore my last comment.  I found the official submission in my queue.  Somehow
I missed it when I first went looking.

[Bug rtl-optimization/63618] CSE at IRA pass delete SET_GOT which is used later

[iverbin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

--- Comment #5 from iverbin at gcc dot gnu.org ---
Author: iverbin
Date: Thu Oct 23 16:52:11 2014
New Revision: 216596

URL: https://gcc.gnu.org/viewcvs?rev=216596&root=gcc&view=rev
Log:
    PR target/63534
    PR target/63618
gcc/
    * cse.c (delete_trivially_dead_insns): Consider PIC register is used
    while it is pseudo.
    * dse.c (deletable_insn_p): Likewise.
gcc/testsuite/
    * gcc.target/i386/pr63618.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/i386/pr63618.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cse.c
    trunk/gcc/dce.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/63618] CSE at IRA pass delete SET_GOT which is used later

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63618

Stupachenko Evgeny <evstupac at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Stupachenko Evgeny <evstupac at gmail dot com> ---
The issue is fixed.