public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "evstupac at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin
Date: Mon, 27 Oct 2014 12:10:00 -0000	[thread overview]
Message-ID: <bug-63620-4-9THhlahLRe@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63620-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #10 from Stupachenko Evgeny <evstupac at gmail dot com> ---
(In reply to Uroš Bizjak from comment #9)
> (In reply to Stupachenko Evgeny from comment #8)
> > (In reply to Uroš Bizjak from comment #7)
> > > The difference si that the call to f128_p3 does not expand with "use (reg:SI
> > > bx)" tag in the Darwin case. Probably ix86_expand_call should be fixed for
> > > TARGET_MACHO
> > 
> > Darwin generates indirect access throw generated section: .symbol_stub.
> > They don't use EBX in the call even without any changes (relaxing EBX usage).
> 
> I guess that the mentioned "use" in the call is what keeps PIC register live
> accross push in the non-Darwin case.

Not sure I understand Darwin features correct, but they push shifted esp to
calls:
(objdump of example for PR63618)
00000d20 <_f128_square>:
 d20:   56                      push   %esi
 d21:   83 ec 18                sub    $0x18,%esp
 d24:   66 0f 6f 44 24 30       movdqa 0x30(%esp),%xmm0
 d2a:   89 e0                   mov    %esp,%eax
 d2c:   83 ec 2c                sub    $0x2c,%esp
 d2f:   8b 74 24 4c             mov    0x4c(%esp),%esi
 d33:   0f 11 44 24 1c          movups %xmm0,0x1c(%esp)
 d38:   0f 11 44 24 0c          movups %xmm0,0xc(%esp)
 d3d:   50                      push   %eax
 d3e:   e8 f9 00 00 00          call   e3c <___multf3$stub>
 d43:   89 f0                   mov    %esi,%eax
 d45:   66 0f 6f 4c 24 2c       movdqa 0x2c(%esp),%xmm1
 d4b:   0f 29 0e                movaps %xmm1,(%esi)
 d4e:   83 c4 44                add    $0x44,%esp
 d51:   5e                      pop    %esi
 d52:   c2 04 00                ret    $0x4

Anyway, if call is not EBX dependent (say local call in Linux) the issue is not
reproduced (like in example from PR63618).
So the issue looks like Darwin dependent RA issue.
>From gcc-bugs-return-465045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 12:10:22 2014
Return-Path: <gcc-bugs-return-465045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9660 invoked by alias); 27 Oct 2014 12:10:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9605 invoked by uid 48); 27 Oct 2014 12:10:17 -0000
From: "terra at gnome dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/63645] Incorrect code generation
Date: Mon, 27 Oct 2014 12:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: terra at gnome dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63645-4-XgKa1uX8Zc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63645-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63645-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02066.txt.bz2
Content-length: 279

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc645

--- Comment #15 from M Welinder <terra at gnome dot org> ---
FYI, I filed a related bug for valgrind covering the problem with the
conditional jump being detected as undefined:

    https://bugs.kde.org/show_bug.cgi?id40392


  parent reply	other threads:[~2014-10-27 11:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-63620-4@http.gcc.gnu.org/bugzilla/>
2014-10-22 16:36 ` evstupac at gmail dot com
2014-10-22 23:20 ` evstupac at gmail dot com
2014-10-26 18:38 ` ubizjak at gmail dot com
2014-10-27  8:05 ` izamyatin at gmail dot com
2014-10-27 10:08 ` evstupac at gmail dot com
2014-10-27 12:10 ` evstupac at gmail dot com [this message]
2014-10-27 13:20 ` ubizjak at gmail dot com
2014-10-29 13:41 ` enkovich.gnu at gmail dot com
2014-10-30  7:33 ` law at redhat dot com
2014-10-30 16:01 ` vmakarov at gcc dot gnu.org
2014-10-30 16:50 ` vmakarov at gcc dot gnu.org
2014-10-30 16:56 ` law at redhat dot com
2014-10-30 18:27 ` vmakarov at gcc dot gnu.org
2014-10-31 11:13 ` ubizjak at gmail dot com
2014-10-31 19:05 ` ubizjak at gmail dot com
2014-10-31 20:03 ` uros at gcc dot gnu.org
2014-10-31 21:56 ` uros at gcc dot gnu.org
2014-11-05  9:32 ` ubizjak at gmail dot com
2014-11-09 16:45 ` vmakarov at gcc dot gnu.org
2014-11-10 21:33 ` vmakarov at gcc dot gnu.org
2014-11-10 23:36 ` ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63620-4-9THhlahLRe@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).