[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #1 from Stupachenko Evgeny <evstupac at gmail dot com> ---
The issue reproduced only if patch from PR63618 is applied.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #2 from Stupachenko Evgeny <evstupac at gmail dot com> ---
Created attachment 33784
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33784&action=edit
patch making the test and darwin bootstrap pass

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #4 from Uroš Bizjak <ubizjak at gmail dot com> ---
Please note that:

(define_insn "*pushtf"
  [(set (match_operand:TF 0 "push_operand" "=<,<")
    (match_operand:TF 1 "general_no_elim_operand" "x,*roF"))]
  "TARGET_64BIT || TARGET_SSE"
{
  /* This insn should be already split before reg-stack.  */
  gcc_unreachable ();
}
  [(set_attr "isa" "*,x64")
   (set_attr "type" "multi")
   (set_attr "unit" "sse,*")
   (set_attr "mode" "TF,DI")])

in effect looks like:

(define_insn "*pushtf"
  [(set (match_operand:TF 0 "push_operand" "=<")
    (match_operand:TF 1 "general_no_elim_operand" "x"))]

on 32bit x86, due to "isa" attribute.
>From gcc-bugs-return-465011-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Oct 26 18:38:14 2014
Return-Path: <gcc-bugs-return-465011-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16387 invoked by alias); 26 Oct 2014 18:38:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16356 invoked by uid 48); 26 Oct 2014 18:38:10 -0000
From: "richard at netbsd dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/63650]=?UTF-8?Q? conflicting type attributes specified for ‘virtual?=..'
Date: Sun, 26 Oct 2014 18:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: richard at netbsd dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63650-4-7jMkHa1m5u@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63650-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63650-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02032.txt.bz2
Content-length: 294

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc650

--- Comment #3 from Richard PALO <richard at netbsd dot org> ---
I initially replied that there was an error in my original, please
correct the first three lines to:
#ifndef HIDDEN
#define HIDDEN __attribute__((visibility("hidden")))
#endif

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[izamyatin at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Igor Zamyatin <izamyatin at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |izamyatin at gmail dot com

--- Comment #5 from Igor Zamyatin <izamyatin at gmail dot com> ---
(In reply to Uroš Bizjak from comment #3)
> Confirmed. This will affect all SSE targets.

Have you managed to reproduce the issue on i686?

> The patch at Comment #2 will just paper over the issue.

Yeah, it was just a temporary fix for Darwin folks
>From gcc-bugs-return-465025-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 08:05:50 2014
Return-Path: <gcc-bugs-return-465025-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10985 invoked by alias); 27 Oct 2014 08:05:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10614 invoked by uid 48); 27 Oct 2014 08:05:44 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin
Date: Mon, 27 Oct 2014 08:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63620-4-xqcv1UcVoj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02046.txt.bz2
Content-length: 353

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Igor Zamyatin from comment #5)
> > Confirmed. This will affect all SSE targets.
> 
> Have you managed to reproduce the issue on i686?

No, only with a crosscompiler to x86_64-apple-darwin11. The i686-linux looks
OK.
>From gcc-bugs-return-465026-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 08:35:22 2014
Return-Path: <gcc-bugs-return-465026-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25545 invoked by alias); 27 Oct 2014 08:35:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25505 invoked by uid 48); 27 Oct 2014 08:35:18 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin
Date: Mon, 27 Oct 2014 08:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63620-4-ixTzU2JwUE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02047.txt.bz2
Content-length: 426

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
The difference si that the call to f128_p3 does not expand with "use (reg:SI
bx)" tag in the Darwin case. Probably ix86_expand_call should be fixed for
TARGET_MACHO.

However, even if this will solve bootstrap, the RA should be fixed to mark PIC
register live in case when constant is moved to memory.
>From gcc-bugs-return-465027-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 08:37:32 2014
Return-Path: <gcc-bugs-return-465027-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26728 invoked by alias); 27 Oct 2014 08:37:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26701 invoked by uid 48); 27 Oct 2014 08:37:28 -0000
From: "clyon at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63652] New: [AArch64_be] vzip/vuzp tests fail
Date: Mon, 27 Oct 2014 08:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: clyon at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-63652-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02048.txt.bz2
Content-length: 617

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc652

            Bug ID: 63652
           Summary: [AArch64_be] vzip/vuzp tests fail
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: clyon at gcc dot gnu.org

The vzip/vuzp tests from gcc.target/aarch64/advsimd-intrinsics fail at
execution when the target is aarch64_be.

I am using aarch64_be-none-elf with the Foundation Model as execution engine,
so it could be a bug in that simulator.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #8 from Stupachenko Evgeny <evstupac at gmail dot com> ---
(In reply to Uroš Bizjak from comment #7)
> The difference si that the call to f128_p3 does not expand with "use (reg:SI
> bx)" tag in the Darwin case. Probably ix86_expand_call should be fixed for
> TARGET_MACHO

Darwin generates indirect access throw generated section: .symbol_stub.
They don't use EBX in the call even without any changes (relaxing EBX usage).

> 
> However, even if this will solve bootstrap, the RA should be fixed to mark
> PIC register live in case when constant is moved to memory.
>From gcc-bugs-return-465037-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 10:08:14 2014
Return-Path: <gcc-bugs-return-465037-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23500 invoked by alias); 27 Oct 2014 10:08:14 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23468 invoked by uid 48); 27 Oct 2014 10:08:10 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin
Date: Mon, 27 Oct 2014 10:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63620-4-aNbaLg32gM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02058.txt.bz2
Content-length: 677

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #9 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Stupachenko Evgeny from comment #8)
> (In reply to Uroš Bizjak from comment #7)
> > The difference si that the call to f128_p3 does not expand with "use (reg:SI
> > bx)" tag in the Darwin case. Probably ix86_expand_call should be fixed for
> > TARGET_MACHO
> 
> Darwin generates indirect access throw generated section: .symbol_stub.
> They don't use EBX in the call even without any changes (relaxing EBX usage).

I guess that the mentioned "use" in the call is what keeps PIC register live
accross push in the non-Darwin case.
>From gcc-bugs-return-465038-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 10:22:12 2014
Return-Path: <gcc-bugs-return-465038-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30734 invoked by alias); 27 Oct 2014 10:22:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30660 invoked by uid 48); 27 Oct 2014 10:22:01 -0000
From: "richard at netbsd dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/63650]=?UTF-8?Q? conflicting type attributes specified for ‘virtual?=..'
Date: Mon, 27 Oct 2014 10:24:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: richard at netbsd dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63650-4-edgtGicQHx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63650-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63650-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02059.txt.bz2
Content-length: 213

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc650

--- Comment #7 from Richard PALO <richard at netbsd dot org> ---
Further testing indicates that 'cdecl' is okay and that keeping 'regparm(0)'
causes the error.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[evstupac at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #10 from Stupachenko Evgeny <evstupac at gmail dot com> ---
(In reply to Uroš Bizjak from comment #9)
> (In reply to Stupachenko Evgeny from comment #8)
> > (In reply to Uroš Bizjak from comment #7)
> > > The difference si that the call to f128_p3 does not expand with "use (reg:SI
> > > bx)" tag in the Darwin case. Probably ix86_expand_call should be fixed for
> > > TARGET_MACHO
> > 
> > Darwin generates indirect access throw generated section: .symbol_stub.
> > They don't use EBX in the call even without any changes (relaxing EBX usage).
> 
> I guess that the mentioned "use" in the call is what keeps PIC register live
> accross push in the non-Darwin case.

Not sure I understand Darwin features correct, but they push shifted esp to
calls:
(objdump of example for PR63618)
00000d20 <_f128_square>:
 d20:   56                      push   %esi
 d21:   83 ec 18                sub    $0x18,%esp
 d24:   66 0f 6f 44 24 30       movdqa 0x30(%esp),%xmm0
 d2a:   89 e0                   mov    %esp,%eax
 d2c:   83 ec 2c                sub    $0x2c,%esp
 d2f:   8b 74 24 4c             mov    0x4c(%esp),%esi
 d33:   0f 11 44 24 1c          movups %xmm0,0x1c(%esp)
 d38:   0f 11 44 24 0c          movups %xmm0,0xc(%esp)
 d3d:   50                      push   %eax
 d3e:   e8 f9 00 00 00          call   e3c <___multf3$stub>
 d43:   89 f0                   mov    %esi,%eax
 d45:   66 0f 6f 4c 24 2c       movdqa 0x2c(%esp),%xmm1
 d4b:   0f 29 0e                movaps %xmm1,(%esi)
 d4e:   83 c4 44                add    $0x44,%esp
 d51:   5e                      pop    %esi
 d52:   c2 04 00                ret    $0x4

Anyway, if call is not EBX dependent (say local call in Linux) the issue is not
reproduced (like in example from PR63618).
So the issue looks like Darwin dependent RA issue.
>From gcc-bugs-return-465045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 12:10:22 2014
Return-Path: <gcc-bugs-return-465045-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9660 invoked by alias); 27 Oct 2014 12:10:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9605 invoked by uid 48); 27 Oct 2014 12:10:17 -0000
From: "terra at gnome dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/63645] Incorrect code generation
Date: Mon, 27 Oct 2014 12:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: terra at gnome dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63645-4-XgKa1uX8Zc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63645-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63645-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02066.txt.bz2
Content-length: 279

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc645

--- Comment #15 from M Welinder <terra at gnome dot org> ---
FYI, I filed a related bug for valgrind covering the problem with the
conditional jump being detected as undefined:

    https://bugs.kde.org/show_bug.cgi?id40392

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #11 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Stupachenko Evgeny from comment #10)

> Anyway, if call is not EBX dependent (say local call in Linux) the issue is
> not reproduced (like in example from PR63618).
> So the issue looks like Darwin dependent RA issue.

True. In Darwin case, RA allocates %eax, which is call-used register and
clobbered by the call to f128_p3. I don't see %eax saved around the call.

In Linux case, RA allocates %edi, which is call-saved.
>From gcc-bugs-return-465051-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 13:20:53 2014
Return-Path: <gcc-bugs-return-465051-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23455 invoked by alias); 27 Oct 2014 13:20:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23435 invoked by uid 48); 27 Oct 2014 13:20:49 -0000
From: "petschy at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/63657] New: [4.9 regression] -Wunused-variable: warning supressed by virtual dtor fn
Date: Mon, 27 Oct 2014 13:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: petschy at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-63657-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02072.txt.bz2
Content-length: 1704

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63657

            Bug ID: 63657
           Summary: [4.9 regression] -Wunused-variable: warning supressed
                    by virtual dtor fn
           Product: gcc
           Version: 4.9.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: petschy at gmail dot com

The under code has two unused variables, which are references to classes. We
should have two warnings, however 4.9.1 and 5.0 trunk gives just one. 4.7.2 and
4.8.3 are ok. The second warning is supressed by the virtual dtor in Bar. Only
the dtor does the trick, if I comment it out or instead I define a plain
virtual fn, the warning appears.

g++-4.8 -Wunused-variable -c 20141022-unused_warn.cpp 
20141022-unused_warn.cpp: In function ‘void foo()’:
20141022-unused_warn.cpp:7:7: warning: unused variable ‘f’ [-Wunused-variable]
  Foo& f = getfoo();
       ^
20141022-unused_warn.cpp: In function ‘void bar()’:
20141022-unused_warn.cpp:18:7: warning: unused variable ‘b’ [-Wunused-variable]
  Bar& b = getbar();
       ^


g++-5.0.0 -Wunused-variable -c 20141022-unused_warn.cpp 
20141022-unused_warn.cpp: In function ‘void foo()’:
20141022-unused_warn.cpp:7:7: warning: unused variable ‘f’ [-Wunused-variable]
  Foo& f = getfoo();
       ^

----8<----8<----8<----
class Foo 
{
};
Foo& getfoo();
void foo()
{
        Foo& f = getfoo();
}

class Bar
{
        virtual ~Bar() {}
};
Bar& getbar();
void bar()
{
        Bar& b = getbar();
}
>From gcc-bugs-return-465052-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Oct 27 13:31:13 2014
Return-Path: <gcc-bugs-return-465052-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 28028 invoked by alias); 27 Oct 2014 13:31:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27985 invoked by uid 48); 27 Oct 2014 13:31:08 -0000
From: "howarth at bromo dot med.uc.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63610] OSX 10.10 (Yosemite) segfault in MPIR testsuite with -O0 or -O1
Date: Mon, 27 Oct 2014 13:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: howarth at bromo dot med.uc.edu
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63610-4-I7lwUnaRxn@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63610-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63610-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02073.txt.bz2
Content-length: 376

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc610

--- Comment #9 from howarth at bromo dot med.uc.edu ---
Alternatively, you can just make sure you don't set MACOSX_DEPLOYMENT_TARGET in
your shell.

Also mote that gmp, mpfr and mpc also suffer from this bug and, if built on
10.10, should either have their configure scripts patched or regenerated with
the fixed libtool.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Ilya Enkovich <enkovich.gnu at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |enkovich.gnu at gmail dot com

--- Comment #13 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
Created attachment 33841
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33841&action=edit
Reproducer for Linux

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |vmakarov at redhat dot com

--- Comment #14 from Jeffrey A. Law <law at redhat dot com> ---
Ilya, thanks for the Linux (well, non-Darwin) testcase.  I think it shows very
clearly that this is an IRA/LRA problem.

If we look at the .ira dump we have:


(insn/f 43 7 2 2 (parallel [
            (set (reg:SI 88)
                (unspec:SI [
                        (const_int 0 [0])
                    ] UNSPEC_SET_GOT))
            (clobber (reg:CC 17 flags))
        ]) 679 {set_got}
     (expr_list:REG_UNUSED (reg:SI 88)
        (expr_list:REG_UNUSED (reg:CC 17 flags)
            (expr_list:REG_EQUIV (unspec:SI [
                        (const_int 0 [0])
                    ] UNSPEC_SET_GOT)
                (expr_list:REG_CFA_FLUSH_QUEUE (nil)
                    (nil))))))


We assign r88 to %eax.  Note the REG_UNUSED note.  The validity of the
REG_UNUSED note is debatable since there aren't any uses of r88 in the RTL, but
we do have those "hidden uses" when we have reloads.

Later in the .ira dump we have:

(call_insn 13 12 14 2 (parallel [
            (call (mem:QI (reg/v/f:SI 4 si [orig:87 f ] [87]) [0 *(__float128
(*<T311>) (__float128)) f_4(D) S1 A8])
                (const_int 32 [0x20]))
            (set (reg/f:SI 7 sp)
                (plus:SI (reg/f:SI 7 sp)
                    (const_int 4 [0x4])))
        ]) j.c:11 657 {*call_pop}
     (expr_list:REG_CALL_DECL (nil)
        (expr_list:REG_ARGS_SIZE (const_int 28 [0x1c])
            (nil)))
    (nil))

[ ... ]

(insn 21 18 22 3 (set (mem:TF (pre_dec:SI (reg/f:SI 7 sp)) [1  S16 A128])
        (const_double:TF 1.0e+29 [0x0.a18f07d736b90be55p+97])) j.c:13 121
{*pushtf}
     (expr_list:REG_ARGS_SIZE (const_int 16 [0x10])
        (nil)))


So IRA assigns r88 to %eax.  Which makes sense given the raw RTL.  As far as
IRA can tell, r88 is just set in the SET_GOT insn and it never gets used.

LRA turns that into:

(insn/f 43 7 2 2 (parallel [
            (set (reg:SI 0 ax [88])
                (unspec:SI [
                        (const_int 0 [0])
                    ] UNSPEC_SET_GOT))
            (clobber (reg:CC 17 flags))
        ]) 679 {set_got}
     (expr_list:REG_EQUIV (unspec:SI [
                (const_int 0 [0])
            ] UNSPEC_SET_GOT)
        (expr_list:REG_CFA_FLUSH_QUEUE (nil)
            (nil))))

[ ... ]

(call_insn 13 12 14 2 (parallel [
            (call (mem:QI (reg/v/f:SI 4 si [orig:87 f ] [87]) [0 *(__float128
(*<T311>) (__float128)) f_4(D) S1 A8])
                (const_int 32 [0x20]))
            (set (reg/f:SI 7 sp)
                (plus:SI (reg/f:SI 7 sp)
                    (const_int 4 [0x4])))
        ]) j.c:11 657 {*call_pop}
     (expr_list:REG_CALL_DECL (nil)
        (expr_list:REG_ARGS_SIZE (const_int 28 [0x1c])
            (nil)))
    (nil))

[ ... ]

(insn 46 18 47 3 (set (reg:SI 0 ax [93])
        (plus:SI (reg:SI 0 ax [88])
            (const:SI (unspec:SI [
                        (symbol_ref/u:SI ("*.LC0") [flags 0x2])
                    ] UNSPEC_GOTOFF)))) j.c:13 213 {*leasi}
     (expr_list:REG_EQUAL (symbol_ref/u:SI ("*.LC0") [flags 0x2])
        (nil)))
(insn 47 46 21 3 (set (reg:TF 23 xmm2 [94])
        (mem/u/c:TF (reg:SI 0 ax [93]) [1  S16 A128])) j.c:13 126
{*movtf_internal}
     (nil))



Which is obviously bogus because %eax is clobbered at insn 13 and thus won't
have a useful value at insn 46.

Officially assigning to Vlad...

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Vladimir Makarov <vmakarov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at gcc dot gnu.org

--- Comment #15 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Jeffrey A. Law from comment #14)
>
> Which is obviously bogus because %eax is clobbered at insn 13 and thus won't
> have a useful value at insn 46.
> 
> Officially assigning to Vlad...

  I checked the testcase.  The problem is in absense of pic pseudo 88 in live
in set of BB3 where the constant is put into memory and we need the pseudo to
address it.

  Actually, this is LRA design problem.  LRA is not designed for
transformations which needs to update global info (live info).  That is why it
is called local.  LRA as older reload pass uses BB-live info got from
DF-infrastructure right before its work and never uses DF-infrastructure after
that (as reload pass).  It can change live info inside BB (reg notes) but never
change live info at BB borders (more correctly it can do this in EBB scope used
to improve inheritance).  The reason for this is that changes in RTL are so
massive during LRA/reload that using DF-infrastructure (which has a lot of
on-side data and any RTL change results in changing the data) slows down
compiler a lot (the very first version of LRA was based on DF and it slowed
down the whole compiler by 10%).

  The problem could have been solved if we used another alternative which does
need pic pseudos after the transformation.  And my additional patches to this
optimization code use this solution (e.g. preventing usage memory equivalence
requiring pic addressing or avoiding putting the constant into memory).  But it
can not work in this case as there are not such acceptable altrenatives.

  So there are the following solutions of the PR:

    o marking pic pseudo lives everywhere but it basically rejects all this
      optimization -- unacceptable
    o switching to DF-infrastructure.  It is a big work and the most important
      slows down compiler by about 10% -- unacceptable
    o recalculating global live-info without DF (using only DF data-flow
solver)

  I see the last as the only solution.  Such solution would open a door to
global LRA transformations.  It could help for LRA-remat pass too where I am
currently trying to solve some existing performance problems in local scope
only.

  I am starting to work on this.  I have very few time before the end of the
current stage and it makes me reconsider my current work on LRA-remat pass too.
 But I guess I can manage.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #16 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Vladimir Makarov from comment #15)
> 
>   I am starting to work on this.  I have very few time before the end of the
> current stage and it makes me reconsider my current work on LRA-remat pass
> too.  But I guess I can manage.

Meanwhile, I guess it is obvious that the pic optimization should be switched
off.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #17 from Jeffrey A. Law <law at redhat dot com> ---
So would it work (and I realize this is a horrid hack) to have a way for the
backend to set the pic-pseudo as live at the key points during IRA?  It'll be
overly conservative, but it may still be better than going back to a fixed PIC
register.  If we had the conservative live information during IRA, presumably
it would flow through to LRA and avoid this problem?

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #18 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Jeffrey A. Law from comment #17)
> So would it work (and I realize this is a horrid hack) to have a way for the
> backend to set the pic-pseudo as live at the key points during IRA?  It'll
> be overly conservative, but it may still be better than going back to a
> fixed PIC register.  If we had the conservative live information during IRA,
> presumably it would flow through to LRA and avoid this problem?

I believe it will disable the optimization completely too.  It is up to Intel
guys to decide how to disable the optimization *temporarily* with minimal
efforts most probably only for 2 weeks.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #19 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Vladimir Makarov from comment #18)
> (In reply to Jeffrey A. Law from comment #17)
> > So would it work (and I realize this is a horrid hack) to have a way for the
> > backend to set the pic-pseudo as live at the key points during IRA?  It'll
> > be overly conservative, but it may still be better than going back to a
> > fixed PIC register.  If we had the conservative live information during IRA,
> > presumably it would flow through to LRA and avoid this problem?
> 
> I believe it will disable the optimization completely too.  It is up to
> Intel guys to decide how to disable the optimization *temporarily* with
> minimal efforts most probably only for 2 weeks.

Following patch mitigates bootstrap problems:

--cut here--
Index: config/i386/i386.md
===================================================================
--- config/i386/i386.md (revision 216952)
+++ config/i386/i386.md (working copy)
@@ -2736,7 +2736,10 @@
 (define_insn "*pushtf"
   [(set (match_operand:TF 0 "push_operand" "=<,<")
        (match_operand:TF 1 "general_no_elim_operand" "x,*roF"))]
-  "TARGET_64BIT || TARGET_SSE"
+  "(TARGET_64BIT || TARGET_SSE)
+   && (!can_create_pseudo_p ()
+       || GET_CODE (operands[1]) != CONST_DOUBLE
+       || standard_sse_constant_p (operands[1]))"
 {
   /* This insn should be already split before reg-stack.  */
   gcc_unreachable ();
@@ -2761,7 +2764,9 @@
 (define_insn "*pushxf"
   [(set (match_operand:XF 0 "push_operand" "=<,<")
        (match_operand:XF 1 "general_no_elim_operand" "f,Yx*roF"))]
-  ""
+  "!can_create_pseudo_p ()
+   || GET_CODE (operands[1]) != CONST_DOUBLE
+   || standard_80387_constant_p (operands[1]) > 0"
 {
   /* This insn should be already split before reg-stack.  */
   gcc_unreachable ();
@@ -2792,7 +2797,12 @@
 (define_insn "*pushdf"
   [(set (match_operand:DF 0 "push_operand" "=<,<,<,<")
        (match_operand:DF 1 "general_no_elim_operand" "f,Yd*roF,rmF,x"))]
-  ""
+  "!can_create_pseudo_p ()
+   || GET_CODE (operands[1]) != CONST_DOUBLE
+   || (!(TARGET_SSE2 && TARGET_SSE_MATH)
+       && standard_80387_constant_p (operands[1]) > 0)
+   || (TARGET_SSE2 && TARGET_SSE_MATH
+       && standard_sse_constant_p (operands[1]))"
 {
   /* This insn should be already split before reg-stack.  */
   gcc_unreachable ();
--cut here--

The above patch solves all but corner problems, but generates non-optimal push
sequences for constants when general registers are available.

So, we can refer to the above hacky patch to "fix" current bootstrap problems.
This way it is possible to survive a couple of weeks, until the real fix is
available.
>From gcc-bugs-return-465474-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Oct 31 11:13:06 2014
Return-Path: <gcc-bugs-return-465474-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 17114 invoked by alias); 31 Oct 2014 11:13:06 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 17058 invoked by uid 48); 31 Oct 2014 11:13:02 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin
Date: Fri, 31 Oct 2014 11:15:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: vmakarov at redhat dot com
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-63620-4-qiVlVbvD5B@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02495.txt.bz2
Content-length: 575

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominiq at lps dot ens.fr,
                   |                            |fxcoudert at gcc dot gnu.org,
                   |                            |mikestump at comcast dot net

--- Comment #20 from Uroš Bizjak <ubizjak at gmail dot com> ---
Adding Darwin people to CC.
>From gcc-bugs-return-465475-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Oct 31 11:15:59 2014
Return-Path: <gcc-bugs-return-465475-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21601 invoked by alias); 31 Oct 2014 11:15:59 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21548 invoked by uid 48); 31 Oct 2014 11:15:56 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/63698] [5 Regression] std::set leaks nodes on assignment
Date: Fri, 31 Oct 2014 11:17:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc bug_severity
Message-ID: <bug-63698-4-paAj5ABLfF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63698-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63698-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02496.txt.bz2
Content-length: 1153

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc698

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fdumont at gcc dot gnu.org
           Severity|normal                      |major

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Francois, the bug is in _Reuse_or_alloc_node::_M_extract which returns a node
that has a child. When we reuse the node the child is lost.

The LHS of the assignment looks like this:

(gdb) p this->_M_impl._M_header
$1 = {_M_color = std::_S_red, _M_parent = 0x605010, _M_left = 0x605040,
_M_right = 0x605010}
(gdb) p *$1._M_left
$2 = {_M_color = std::_S_red, _M_parent = 0x605010, _M_left = 0x0, _M_right 0x0}
(gdb) p *$1._M_right
$3 = {_M_color = std::_S_black, _M_parent = 0x7fffffffd668, _M_left = 0x605040,
_M_right = 0x0}

When that gets handed to the _Reuse_or_alloc_node
this->_M_impl._M_header._M_right->_M_parent gets set to null, so when
_M_extract returns 0x605010 it thinks it has no more nodes to reuse.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #22 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Jeffrey A. Law from comment #21)

> Any objection to installing that patch to work around these problems while
> Vlad works on things from the rematerialization side?

No, I was in fact tempted to commit this patch as a temporary workaround.
> 
> Perhaps put that condition in a function which makes it clear that this is
> just a workaround to give Vlad time to build out the real solution?

Every condition is slightly different, I think that marking the patterns with a
XXX comment, referring to this PR, should be enough.
>From gcc-bugs-return-465514-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Oct 31 19:16:04 2014
Return-Path: <gcc-bugs-return-465514-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1835 invoked by alias); 31 Oct 2014 19:16:03 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1801 invoked by uid 48); 31 Oct 2014 19:15:51 -0000
From: "jtaylor.debian at googlemail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/63704] New: -flto internal compiler error: in mems_in_disjoint_alias_sets_p, at alias.c:398
Date: Fri, 31 Oct 2014 19:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jtaylor.debian at googlemail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-63704-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02535.txt.bz2
Content-length: 2005

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63704

            Bug ID: 63704
           Summary: -flto internal compiler error: in
                    mems_in_disjoint_alias_sets_p, at alias.c:398
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jtaylor.debian at googlemail dot com

Created attachment 33856
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33856&action=edit
creduced testcase files

attached reduced testcase run with the run.sh file produces an ice with current
trunk (20141026).
The issue can also be preproduced with 4.9.2 and 4.8.2

tar xf testcase.tar.gz
cd testcase
#adapt path to gcc and lto1 in the run.sh script
./run.sh
...

/tmp/creduce-gzds4W/lowlevel_strided_loops.i: In function ‘fn1’:
/tmp/creduce-gzds4W/lowlevel_strided_loops.i:10:1: internal compiler error: in
mems_in_disjoint_alias_sets_p, at alias.c:398

gcc -v
Using built-in specs.
COLLECT_GCC=/scratch/jtaylor/gcc/local-trunk/bin//gcc
COLLECT_LTO_WRAPPER=/scratch/jtaylor/gcc/local-trunk/libexec/gcc/x86_64-unknown-linux-gnu/5.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /media/jtaylor/external1/buildacc/gcc-trunk/configure
--disable-werror --enable-languages=c,c++,fortran --enable-tls
--prefix=/scratch/jtaylor/gcc/local-trunk --with-gmp=/usr --with-mpfr=/usr
--with-mpc=/usr --with-cloog=/usr --with-ppl=/usr --with-isl=/usr
--disable-bootstrap --enable-checking=release
Thread model: posix
gcc version 5.0.0 20141026 (experimental) (GCC) 

to reproduce using the full source (requires python development headers):
git clone git://github.com/numpy/numpy
cd numpy
CC='gcc -fno-fat-lto-objects -flto=4 -fuse-linker-plugin -O3' LDSHARED='gcc
-fno-fat-lto-objects -flto=4 -fuse-linker-plugin -shared -O3' AR=gcc-ar python
setup.py build_ext
>From gcc-bugs-return-465513-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Oct 31 19:05:30 2014
Return-Path: <gcc-bugs-return-465513-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25399 invoked by alias); 31 Oct 2014 19:05:29 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25351 invoked by uid 48); 31 Oct 2014 19:05:26 -0000
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin
Date: Fri, 31 Oct 2014 19:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: law at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: vmakarov at redhat dot com
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63620-4-lAnh0yAbuw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63620-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02534.txt.bz2
Content-length: 218

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc620

--- Comment #23 from Jeffrey A. Law <law at redhat dot com> ---
The inline XXX comment approach is fine with me, let's go with that.

I'll let you do the honors ;-)

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #24 from uros at gcc dot gnu.org ---
Author: uros
Date: Fri Oct 31 19:47:36 2014
New Revision: 216987

URL: https://gcc.gnu.org/viewcvs?rev=216987&root=gcc&view=rev
Log:
    PR target/63620
    * config/i386/i386.md (*pushtf): Allow only CONST_DOUBLES that won't
    be reloaded through memory.
    (*pushxf): Ditto.
    (*pushdf): Ditto.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.md

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #25 from uros at gcc dot gnu.org ---
Author: uros
Date: Fri Oct 31 21:52:22 2014
New Revision: 216990

URL: https://gcc.gnu.org/viewcvs?rev=216990&root=gcc&view=rev
Log:
    PR target/63620
    * config/i386/i386-protos.h (ix86_use_pseudo_pic_reg): Declare.
    * config/i386/i386.c (ix86_use_pseudo_pic_reg): Export.
    * config/i386/i386.md (*pushtf): Allow only CONST_DOUBLEs that won't
    be reloaded through memory.
    (*pushxf): Ditto.
    (*pushdf): Ditto.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386-protos.h
    trunk/gcc/config/i386/i386.c
    trunk/gcc/config/i386/i386.md

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #26 from Uroš Bizjak <ubizjak at gmail dot com> ---
PR 63527 is probably related to this issue.
>From gcc-bugs-return-465769-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Nov 05 09:35:33 2014
Return-Path: <gcc-bugs-return-465769-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22794 invoked by alias); 5 Nov 2014 09:35:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 22228 invoked by uid 48); 5 Nov 2014 09:35:24 -0000
From: "belagod at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63679] [5.0 Regression][AArch64] Failure to constant fold.
Date: Wed, 05 Nov 2014 09:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: belagod at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63679-4-gFhbOUFg6a@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63679-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63679-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00241.txt.bz2
Content-length: 676

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc679

--- Comment #5 from Tejas Belagod <belagod at gcc dot gnu.org> ---

>
> Index: passes.def
> ==================================================================> --- passes.def  (revision 217035)
> +++ passes.def  (working copy)
> @@ -255,7 +255,7 @@
>        NEXT_PASS (pass_reassoc);
>        NEXT_PASS (pass_strength_reduction);
>        NEXT_PASS (pass_tracer);
> -      NEXT_PASS (pass_dominator);
> +      NEXT_PASS (pass_fre);
>        NEXT_PASS (pass_strlen);
>        NEXT_PASS (pass_vrp);
>        /* The only const/copy propagation opportunities left after
>
> ?

Thanks. Still no luck :-(. Will keep digging.

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #27 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Author: vmakarov
Date: Sun Nov  9 16:45:15 2014
New Revision: 217265

URL: https://gcc.gnu.org/viewcvs?rev=217265&root=gcc&view=rev
Log:
2014-11-09  Vladimir Makarov  <vmakarov@redhat.com>

    PR rtl-optimization/63620
    * lra-constraints.c (substitute_pseudo): Add prefix lra_ to the
    name.  Move to lra.c.  Make it external.
    (substitute_pseudo_within_insn): Ditto.
    (inherit_reload_reg, split_reg, remove_inheritance_pseudos): Use
    the new names.
    (undo_optional_reloads): Ditto.
    * lra-int.h (lra_dump_bitmap_with_title, lra_substitute_pseudo):
    New prototypes.
    (lra_substitute_pseudo_within_insn): Ditto.
    * lra-lives.c (bb_killed_pseudos, bb_gen_pseudos): New.
    (mark_regno_live): Add parameter.  Update bb_gen_pseudos.
    (mark_regno_dead): Add parameter.  Update bb_gen_pseudos and
    bb_killed_pseudos.
    (struct bb_data, bb_data_t, bb_data): New.
    (get_bb_data, get_bb_data_by_index): Ditto.
    (all_hard_regs_bitmap): New.
    (live_trans_fun, live_con_fun_0, live_con_fun_n, all_blocks): New.
    (initiate_live_solver, finish_live_solver): New.
    (process_bb_lives): Change return type.  Add code updating local
    live data and removing dead insns.  Pass new argument to
    mark_regno_live and mark_regno_dead.  Check changing bb pseudo
    life info.  Return the result.
    (lra_create_live_ranges): Add code to do global pseudo live
    analysis.
    (lra_live_ranges_init): Call initiate_live_solver.
    (lra_live_ranges_finish): Call finish_live_solver.
    * lra.c (lra_dump_bitmap_with_title): New.
    (lra_substitute_pseudo, lra_substitute_pseudo_within_insn): Move
    from lra-constraints.c.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lra-constraints.c
    trunk/gcc/lra-int.h
    trunk/gcc/lra-lives.c
    trunk/gcc/lra.c

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

--- Comment #29 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Author: vmakarov
Date: Mon Nov 10 21:33:06 2014
New Revision: 217320

URL: https://gcc.gnu.org/viewcvs?rev=217320&root=gcc&view=rev
Log:
2014-11-10  Vladimir Makarov  <vmakarov@redhat.com>

    PR rtl-optimization/63620
    PR rtl-optimization/63799
    * lra-lives.c (process_bb_lives): Do not delete EH_REGION, trapped
    and setting PIC pseudo insns.
    (lra_create_live_ranges): Fix the typo.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lra-lives.c

[Bug rtl-optimization/63620] RELOAD lost SET_GOT dependency on Darwin

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #31 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.
>From gcc-bugs-return-466303-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Nov 10 23:37:53 2014
Return-Path: <gcc-bugs-return-466303-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9369 invoked by alias); 10 Nov 2014 23:37:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9026 invoked by uid 48); 10 Nov 2014 23:37:48 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63799] [5 Regression] r217265 caused libjava failures
Date: Mon, 10 Nov 2014 23:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_gcctarget bug_status resolution
Message-ID: <bug-63799-4-kBJYnbg5Vs@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63799-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63799-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00775.txt.bz2
Content-length: 482

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63799

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed.
>From gcc-bugs-return-466304-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 11 01:58:57 2014
Return-Path: <gcc-bugs-return-466304-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30456 invoked by alias); 11 Nov 2014 01:58:56 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30374 invoked by uid 48); 11 Nov 2014 01:58:41 -0000
From: "jeremyhu at macports dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61407] Build errors on latest OS X 10.10 Yosemite with Xcode 6 on GCC 4.8.3
Date: Tue, 11 Nov 2014 01:58:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jeremyhu at macports dot org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61407-4-wGjvw9w4JU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61407-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61407-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00776.txt.bz2
Content-length: 1758

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida407

--- Comment #49 from Jeremy Huddleston Sequoia <jeremyhu at macports dot org> ---
(In reply to Francois-Xavier Coudert from comment #45)
> (In reply to Jeremy Huddleston Sequoia from comment #42)
> > The committed patch is incorrect.  It makes an invalid assumption which
> > breaks the usage of deployment targets such as 10.9.3.
>
> All Apple doc I can find has deployment targets of the form 10.x or 10.x.0
> (where x is integer, but not only one digit).

That is not the case.  Do not make that assumption.

(In reply to howarth from comment #46)
> (In reply to Francois-Xavier Coudert from comment #45)
> > (In reply to Jeremy Huddleston Sequoia from comment #42)
> > > The committed patch is incorrect.  It makes an invalid assumption which
> > > breaks the usage of deployment targets such as 10.9.3.
> >
> > All Apple doc I can find has deployment targets of the form 10.x or 10.x.0
> > (where x is integer, but not only one digit).
>
> If Jeremy really disagreed on that change, he hasn't acted on it in the
> gcc49 MacPorts packaging that he maintains (which still uses the original
> proposed patch from
> https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02428.html). FYI, as far as
> llvm-gcc 4.2.1 is concerned, in my fink legacy package for Apple's llvm-gcc
> 4.2.1, I used a back port of our patch,
> http://fink.cvs.sourceforge.net/viewvc/fink/dists/10.7/stable/main/finkinfo/
> languages/llvm-gcc42-yosemite.patch. Neither gcc 4.9.2 nor the patched
> llvm-gcc 4.2.1 has shown any problems on OS X 10.9.5.

I have not fixed the GPL3 ports in MacPorts because I do not read GPL-3 code
and thus am not able to fix it.  Another MacPorts developer is making the fix
for newer versions of gcc.