[Bug tree-optimization/63666] New: [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[Bug tree-optimization/63666] New: [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

            Bug ID: 63666
           Summary: [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal
                    compiler error)
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: schwab@linux-m68k.org
                CC: rguenther at suse dot de
            Target: ia64-*-*

Broken by r216728.

$ gcc/xgcc -Bgcc/ ../gcc/testsuite/gcc.dg/vect/pr45752.c -ftree-vectorize
-fno-vect-cost-model -fno-common -O2 -fdump-tree-vect-details -lm -o
./pr45752.exe
../gcc/testsuite/gcc.dg/vect/pr45752.c: In function ‘foo’:
../gcc/testsuite/gcc.dg/vect/pr45752.c:38:6: internal compiler error: in
ia64_vectorize_vec_perm_const_ok, at config/ia64/ia64.c:11728
 void foo (unsigned int *__restrict__ pInput,
      ^
0x4000000001069d9f ia64_vectorize_vec_perm_const_ok
        ../../gcc/config/ia64/ia64.c:11728
0x400000000090272f can_vec_perm_p(machine_mode, bool, unsigned char const*)
        ../../gcc/optabs.c:6611
0x4000000000f387df vect_transform_slp_perm_load(_slp_tree*, vec<tree_node*,
va_heap, vl_ptr>, gimple_stmt_iterator*, int, _slp_instance*, bool)
        ../../gcc/tree-vect-slp.c:3049
0x4000000000f3c99f vect_supported_load_permutation_p
        ../../gcc/tree-vect-slp.c:1349
0x4000000000f3c99f vect_analyze_slp_instance
        ../../gcc/tree-vect-slp.c:1677
0x4000000000f3d28f vect_analyze_slp(_loop_vec_info*, _bb_vec_info*, unsigned
int)
        ../../gcc/tree-vect-slp.c:1747
0x4000000000f1674f vect_analyze_loop_2
        ../../gcc/tree-vect-loop.c:1762
0x4000000000f1674f vect_analyze_loop(loop*)
        ../../gcc/tree-vect-loop.c:1875
0x4000000000f4659f vectorize_loops()
        ../../gcc/tree-vectorizer.c:442
0x4000000000d77abf execute
        ../../gcc/tree-ssa-loop.c:290
>From gcc-bugs-return-465118-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 28 10:27:18 2014
Return-Path: <gcc-bugs-return-465118-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26223 invoked by alias); 28 Oct 2014 10:27:18 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26195 invoked by uid 48); 28 Oct 2014 10:27:14 -0000
From: "jiwang at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)
Date: Tue, 28 Oct 2014 10:39:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jiwang at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-63666-4-cbaEbKGL0M@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63666-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63666-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02139.txt.bz2
Content-length: 1170

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc666

Jiong Wang <jiwang at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jiwang at gcc dot gnu.org

--- Comment #1 from Jiong Wang <jiwang at gcc dot gnu.org> ---
I noticed this on aarch64 platform also and I suspect it's caused by

commit f619ecaed41d1487091098a0f4fdf4d6ed1fa379
Author: rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Mon Oct 27 11:30:23 2014 +0000

    2014-10-27  Richard Biener  <rguenther@suse.de>

        * tree-ssa-forwprop.c: Include tree-cfgcleanup.h and tree-into-ssa.h.
        (lattice): New global.
        (fwprop_ssa_val): New function.
        (fold_all_stmts): Likewise.
        (pass_forwprop::execute): Finally fold all stmts.

        * gcc.dg/tree-ssa/forwprop-6.c: Scan ccp1 dump instead.
        * gcc.dg/strlenopt-8.c: Adjust and XFAIL for non_strict_align
        target due to memcpy inline-expansion.


    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@216728
138bc75d-0d04-0410-961f-82ee72b054a4

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> ---
Also breaks gcc.dg/vect/vect-strided-a-u8-i2-gap.c

$ gcc/xgcc -Bgcc/ ../gcc/testsuite/gcc.dg/vect/vect-strided-a-u8-i2-gap.c
-ftree-vectorize -fno-vect-cost-model -fno-common -O2 -fdump-tree-vect-details
-lm -o ./vect-strided-a-u8-i2-gap.exe
../gcc/testsuite/gcc.dg/vect/vect-strided-a-u8-i2-gap.c: In function ‘main1’:
../gcc/testsuite/gcc.dg/vect/vect-strided-a-u8-i2-gap.c:34:16: internal
compiler error: in expand_expr_real_2, at expr.c:9156
       res[i].b = ptr->a;
                ^
0x400000000059052f expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier)
        ../../gcc/expr.c:9156
0x4000000000579c1f expand_expr_real_1(tree_node*, rtx_def*, machine_mode,
expand_modifier, rtx_def**, bool)
        ../../gcc/expr.c:9463
0x400000000058b71f store_expr(tree_node*, rtx_def*, int, bool)
        ../../gcc/expr.c:5344
0x400000000059701f expand_assignment(tree_node*, tree_node*, bool)
        ../../gcc/expr.c:5130
0x4000000000381b7f expand_gimple_stmt_1
        ../../gcc/cfgexpand.c:3285
0x4000000000381b7f expand_gimple_stmt
        ../../gcc/cfgexpand.c:3381
0x400000000038d89f expand_gimple_basic_block
        ../../gcc/cfgexpand.c:5216
0x40000000003916ef execute
        ../../gcc/cfgexpand.c:5822
>From gcc-bugs-return-465127-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Oct 28 11:01:39 2014
Return-Path: <gcc-bugs-return-465127-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30467 invoked by alias); 28 Oct 2014 11:01:39 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30422 invoked by uid 48); 28 Oct 2014 11:01:36 -0000
From: "ramana at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63173] performance problem with simd intrinsics vld2_dup_* on aarch64-none-elf
Date: Tue, 28 Oct 2014 11:10:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ramana at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: fei.yang0953 at gmail dot com
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution target_milestone
Message-ID: <bug-63173-4-zdKOfi8XIW@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63173-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63173-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02148.txt.bz2
Content-length: 500

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc173

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.0

--- Comment #9 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed on trunk.

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-10-28
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.  Can you attach preprocessed source so I can investigate
with a cross?  Thx.

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

--- Comment #4 from Jiong Wang <jiwang at gcc dot gnu.org> ---
Created attachment 33827
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33827&action=edit
./cc1 -O3 pr45752.i

upload testcase.

./cc1 (generated by--target=aarch64-elf) -O3 pr45752.i

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Ok, reproduced with a ia64 cross and a cut-down testcase w/o includes.

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Wed Oct 29 09:22:55 2014
New Revision: 216825

URL: https://gcc.gnu.org/viewcvs?rev=216825&root=gcc&view=rev
Log:
2014-10-29  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/63666
    * tree-vect-slp.c (vect_get_mask_element): Properly handle
    accessing out-of-bound elements.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-vect-slp.c

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

--- Comment #8 from Jiong Wang <jiwang at gcc dot gnu.org> ---
Created attachment 33839
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33839&action=edit
vshuf-v16hi.i

Richard,

  after your fix, the issue still exist on arm-none-eabi. testcase attached.

  cc1 built by (../gcc/configure --target=arm-none-eabi
--enable-languages=c,c++)

./cc1 -mcpu=cortex-a9 -mfloat-abi=softfp -mfpu=neon vshuf-v16hi.i -Os

Breakpoint 1, fancy_abort (file=0x1492484 "../../gcc/gcc/gcse.c", line=2153,
function=0x1492df0 "process_insert_insn") at ../../gcc/gcc/diagnostic.c:1232
1232      internal_error ("in %s, at %s:%d", function, trim_filename (file),
line);
(gdb) bt
#0  fancy_abort (file=0x1492484 "../../gcc/gcc/gcse.c", line=2153,
function=0x1492df0 "process_insert_insn") at ../../gcc/gcc/diagnostic.c:1232
#1  0x000000000096b680 in process_insert_insn (expr=0x1db2800) at
../../gcc/gcc/gcse.c:2153
#2  0x000000000096b6da in insert_insn_end_basic_block (expr=0x1db2800,
bb=0x7ffff6e13dd0) at ../../gcc/gcc/gcse.c:2175
#3  0x000000000096e03f in hoist_code () at ../../gcc/gcc/gcse.c:3471
#4  0x000000000096ea94 in one_code_hoisting_pass () at
../../gcc/gcc/gcse.c:3701
#5  0x000000000096f999 in execute_rtl_hoist () at ../../gcc/gcc/gcse.c:4191
#6  0x000000000096fae9 in (anonymous namespace)::pass_rtl_hoist::execute
(this=0x1cecca0) at ../../gcc/gcc/gcse.c:4272
#7  0x0000000000b4f445 in execute_one_pass (pass=0x1cecca0) at
../../gcc/gcc/passes.c:2156
#8  0x0000000000b4f684 in execute_pass_list_1 (pass=0x1cecca0) at
../../gcc/gcc/passes.c:2208
#9  0x0000000000b4f6b5 in execute_pass_list_1 (pass=0x1cec8e0) at
../../gcc/gcc/passes.c:2209
#10 0x0000000000b4f6f7 in execute_pass_list (fn=0x7ffff6bca1f8, pass=0x1ce97c0)
at ../../gcc/gcc/passes.c:2219
#11 0x00000000007d9aa8 in cgraph_node::expand (this=0x7ffff6bcd000) at
../../gcc/gcc/cgraphunit.c:1742
#12 0x00000000007da0c7 in expand_all_functions () at
../../gcc/gcc/cgraphunit.c:1878
#13 0x00000000007dac0d in symbol_table::compile (this=0x7ffff6c74000) at
../../gcc/gcc/cgraphunit.c:2213
#14 0x00000000007dadc4 in symbol_table::finalize_compilation_unit
(this=0x7ffff6c74000) at ../../gcc/gcc/cgraphunit.c:2290
#15 0x000000000063572d in c_write_global_declarations () at
../../gcc/gcc/c/c-decl.c:10641
#16 0x0000000000c489fc in compile_file () at ../../gcc/gcc/toplev.c:574
#17 0x0000000000c4ad22 in do_compile () at ../../gcc/gcc/toplev.c:1981
#18 0x0000000000c4af2c in toplev::main (this=0x7fffffffe55f, argc=6,
argv=0x7fffffffe658) at ../../gcc/gcc/toplev.c:2078
#19 0x00000000013a02b2 in main (argc=6, argv=0x7fffffffe658) at
../../gcc/gcc/main.c:38

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

--- Comment #9 from rguenther at suse dot de <rguenther at suse dot de> ---
On Wed, 29 Oct 2014, jiwang at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666
> 
> --- Comment #8 from Jiong Wang <jiwang at gcc dot gnu.org> ---
> Created attachment 33839
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33839&action=edit
> vshuf-v16hi.i
>
> Richard,
> 
>   after your fix, the issue still exist on arm-none-eabi. testcase attached.

This looks like a completely different issue than the one reported
in the initial description.  Please open a separate bugreport.

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glisse at gcc dot gnu.org

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Andreas Schwab from comment #2)
> Also breaks gcc.dg/vect/vect-strided-a-u8-i2-gap.c
> 
> $ gcc/xgcc -Bgcc/ ../gcc/testsuite/gcc.dg/vect/vect-strided-a-u8-i2-gap.c
> -ftree-vectorize -fno-vect-cost-model -fno-common -O2
> -fdump-tree-vect-details -lm -o ./vect-strided-a-u8-i2-gap.exe
> ../gcc/testsuite/gcc.dg/vect/vect-strided-a-u8-i2-gap.c: In function ‘main1’:
> ../gcc/testsuite/gcc.dg/vect/vect-strided-a-u8-i2-gap.c:34:16: internal
> compiler error: in expand_expr_real_2, at expr.c:9156
>        res[i].b = ptr->a;
>                 ^
> 0x400000000059052f expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
> expand_modifier)
>         ../../gcc/expr.c:9156
> 0x4000000000579c1f expand_expr_real_1(tree_node*, rtx_def*, machine_mode,
> expand_modifier, rtx_def**, bool)
>         ../../gcc/expr.c:9463
> 0x400000000058b71f store_expr(tree_node*, rtx_def*, int, bool)
>         ../../gcc/expr.c:5344
> 0x400000000059701f expand_assignment(tree_node*, tree_node*, bool)
>         ../../gcc/expr.c:5130
> 0x4000000000381b7f expand_gimple_stmt_1
>         ../../gcc/cfgexpand.c:3285
> 0x4000000000381b7f expand_gimple_stmt
>         ../../gcc/cfgexpand.c:3381
> 0x400000000038d89f expand_gimple_basic_block
>         ../../gcc/cfgexpand.c:5216
> 0x40000000003916ef execute
>         ../../gcc/cfgexpand.c:5822

This also still happens.  The vectorizer generates (and verified)

  vect_perm_even_77 = VEC_PERM_EXPR <vect__22.9_74, vect__22.10_76, { 0, 2, 4,
6, 8, 10, 12, 14 }>;
  vect_perm_odd_78 = VEC_PERM_EXPR <vect__22.9_74, vect__22.10_76, { 1, 3, 5,
7, 9, 11, 13, 15 }>;
  vect_inter_high_82 = VEC_PERM_EXPR <vect_perm_even_77, vect_perm_even_77, {
0, 8, 1, 9, 2, 10, 3, 11 }>;
  vect_inter_low_83 = VEC_PERM_EXPR <vect_perm_even_77, vect_perm_even_77, { 4,
12, 5, 13, 6, 14, 7, 15 }>;

then we unroll the loop and forwprop4 comes along changing

  vect_perm_even_145 = VEC_PERM_EXPR <vect__22.9_142, vect__22.10_144, { 0, 2,
4, 6, 8, 10, 12, 14 }>;
  vect_inter_high_146 = VEC_PERM_EXPR <vect_perm_even_145, vect_perm_even_145,
{ 0, 8, 1, 9, 2, 10, 3, 11 }>;

to

  vect_perm_even_145 = VEC_PERM_EXPR <vect__22.9_142, vect__22.10_144, { 0, 2,
4, 6, 8, 10, 12, 14 }>;
  vect_inter_high_146 = VEC_PERM_EXPR <vect_perm_even_145, vect_perm_even_145,
{ 0, 0, 1, 1, 2, 2, 3, 3 }>;

which isn't a supported permutation.  It looks like
fold-const.c:fold_ternary_loc doesn't care about only generating supported
permutations and the fallback code in expand_vec_perm doesn't cover all
cases.
>From gcc-bugs-return-465217-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 29 13:18:05 2014
Return-Path: <gcc-bugs-return-465217-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 19925 invoked by alias); 29 Oct 2014 13:18:05 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19831 invoked by uid 48); 29 Oct 2014 13:18:00 -0000
From: "simon at pushface dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/63675] New:=?UTF-8?Q? Non-confirming aspect doesn’t fail?Date: Wed, 29 Oct 2014 13:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ada
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: simon at pushface dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-63675-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02238.txt.bz2
Content-length: 1899

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63675

            Bug ID: 63675
           Summary: Non-confirming aspect doesn’t fail
           Product: gcc
           Version: 4.9.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: simon at pushface dot org

Created attachment 33840
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33840&action=edit
Reproducer

This arises from checking the status of PR/56196 (which is, itself, now fixed).

There is an untagged base type with aspects Unchecked_Union and C_Pass_By_Copy,
a primitive subprogram of the base type, and three derived types.

All derived types result in warnings

union.ads:15:06: warning: variant record has no direct equivalent in C
union.ads:15:06: warning: use of convention for type "Derived_1" is dubious
union.ads:15:06: warning: variant record has no direct equivalent in C
union.ads:15:06: warning: use of convention for type "Derived_2" is dubious
union.ads:15:06: warning: variant record has no direct equivalent in C
union.ads:15:06: warning: use of convention for type "Derived_3" is dubious

which (a) shouldn’t be a problem, I think, and (b) are on the line at which the
base type is declared, rather than on the line where the “dubious” derived type
is declared.

The first derived type has no aspects.

The second derived type has aspect Unchecked_Union => False, which conflicts
with that of the base type, and *is not rejected*.

The third derived type has aspect Unchecked_Union => True, which confirms that
of the base type, and *is* rejected.

union.ads:29:36: representation item appears too late
union.ads:29:36: primitive operations already defined for "Base"

I think both of derived types with aspects should be rejected.
>From gcc-bugs-return-465218-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Oct 29 13:19:27 2014
Return-Path: <gcc-bugs-return-465218-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 20928 invoked by alias); 29 Oct 2014 13:19:26 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20864 invoked by uid 48); 29 Oct 2014 13:19:23 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)
Date: Wed, 29 Oct 2014 13:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63666-4-0hj03CnWs3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63666-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63666-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-10/txt/msg02239.txt.bz2
Content-length: 969

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc666

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Index: gcc/fold-const.c
==================================================================--- gcc/fold-const.c    (revision 216834)
+++ gcc/fold-const.c    (working copy)
@@ -82,6 +82,7 @@ along with GCC; see the file COPYING3.
 #include "ipa-ref.h"
 #include "cgraph.h"
 #include "generic-match.h"
+#include "optabs.h"

 /* Nonzero if we are folding constants inside an initializer; zero
    otherwise.  */
@@ -14311,7 +14331,8 @@ fold_ternary_loc (location_t loc, enum t
          if (op0 == op1 && !single_arg)
            changed = true;

-         if (need_mask_canon && arg2 == op2)
+         if (need_mask_canon && arg2 == op2
+             && can_vec_perm_p (TYPE_MODE (type), false, sel))
            {
              tree *tsel = XALLOCAVEC (tree, nelts);
              tree eltype = TREE_TYPE (TREE_TYPE (arg2));

fixes the IA64 case.

[Bug tree-optimization/63666] [5.0 regression] FAIL: gcc.dg/vect/pr45752.c (internal compiler error)

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63666

--- Comment #12 from Marc Glisse <glisse at gcc dot gnu.org> ---
(I am traveling this week, so I can only post a short comment)

(In reply to Richard Biener from comment #11)
> -         if (need_mask_canon && arg2 == op2)
> +         if (need_mask_canon && arg2 == op2
> +             && can_vec_perm_p (TYPE_MODE (type), false, sel))

seems reasonable, though if we didn't have can_vec_perm_p before the
transformation (which implies we are before vector lowering) we should probably
still transform. Also, I believe that targets should try to support single
argument permutations when they support a 2 argument version that degenerates
to it when both arguments are the same.

By the way, from a quick look, I don't see where we protect against
TREE_SIDE_EFFECTS(op0) when doing op0=op1 or op1=op0 in this code, I don't
remember if there is a reason why it isn't needed.