[Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

            Bug ID: 63694
           Summary: [5.0 Regression] Build error compiling asan.c:
                    strtoull undeclared
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
              Host: hppa2.0w-hp-hpux11.11
            Target: hppa2.0w-hp-hpux11.11
             Build: hppa2.0w-hp-hpux11.11

g++ -c   -g -DIN_GCC    -fno-exceptions -fno-rtti -fasynchronous-unwind-tables
-
W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format
-Wmissing-format-
attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wn
o-overlength-strings -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc
-I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include
-I/opt/gnu/gcc/gmp/include  -I../../gcc/gcc/../libdecnumber
-I../../gcc/gcc/../libdecnu
mber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace    -o asan.o -MT
asan.o -MMD -MP -MF ./.deps/asan.TPo ../../gcc/gcc/asan.c
../../gcc/gcc/asan.c: In function 'bool set_asan_shadow_offset(const char*)':
../../gcc/gcc/asan.c:267:53: error: 'strtoull' was not declared in this scope
../../gcc/gcc/asan.c:267:53: note: suggested alternative:In file included from
/home/gnu/gcc/gcc-4.7/bin/../lib/gcc/hppa2.0w-hp-hpux11.11/4.7.2/../../../../include/c++/4.7.2/hppa2.0w-hp-hpux11.11/bits/c++config.h:414:
0,
                 from
/home/gnu/gcc/gcc-4.7/bin/../lib/gcc/hppa2.0w-hp-hpux11.11
/4.7.2/../../../../include/c++/4.7.2/cstring:43,
                 from ../../gcc/gcc/system.h:211,
                 from ../../gcc/gcc/asan.c:23:
/home/gnu/gcc/gcc-4.7/bin/../lib/gcc/hppa2.0w-hp-hpux11.11/4.7.2/../../../../inc
lude/c++/4.7.2/hppa2.0w-hp-hpux11.11/bits/os_defines.h:69:36: note:  
'std::strt
oull'
make[3]: *** [asan.o] Error 1


bool
set_asan_shadow_offset (const char *val)
{
  char *endp;

  errno = 0;
#ifdef HAVE_LONG_LONG
  asan_shadow_offset_value = strtoull (val, &endp, 0);
#else
  asan_shadow_offset_value = strtoul (val, &endp, 0);
#endif

Maybe asan.c should include "libiberty.h"

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ygribov at gcc dot gnu.org

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
It looks like libiberty.h is included but the generated libiberty/config.h
seems incorrect:

/* Define to 1 if you have the declaration of `strtoull', and to 0 if you
   don't. */
/* #undef HAVE_DECL_STRTOULL */

/* Define to 1 if you have the declaration of `strverscmp', and to 0 if you
   don't. */
#define HAVE_DECL_STRVERSCMP 0

It seems like we should have

#define HAVE_DECL_STRTOULL 0

2014-10-28  Yury Gribov  <y.gribov@samsung.com>

        * strtoll.c: New file.
        * strtoull.c: New file.
        * configure.ac: Add long long checks.  Add harness for strtoll and
        strtoull.  Check decls for strtol, strtoul, strtoll, strtoull.
        * Makefile.in (CFILES, CONFIGURED_OFILES): Add strtoll and strtoull.
        * config.in: Regenerate.
        * configure: Regenerate.
        * functions.texi: Regenerate.
        * testsuite/Makefile.in (check-strtol): New rule.
        (test-strtol): Likewise.
        (mostlyclean): Clean up strtol test.
        * testsuite/test-strtol.c: New test.

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #1)
> It looks like libiberty.h is included but the generated libiberty/config.h
> seems incorrect:
> 
> /* Define to 1 if you have the declaration of `strtoull', and to 0 if you
>    don't. */
> /* #undef HAVE_DECL_STRTOULL */
> 
> /* Define to 1 if you have the declaration of `strverscmp', and to 0 if you
>    don't. */
> #define HAVE_DECL_STRVERSCMP 0
> 
> It seems like we should have
> 
> #define HAVE_DECL_STRTOULL 0

That's equivalent unless somebody else defines HAVE_DECL_STRTOULL to 1.

-E -dD output of asan.c?

> 2014-10-28  Yury Gribov  <y.gribov@samsung.com>
> 
>         * strtoll.c: New file.
>         * strtoull.c: New file.
>         * configure.ac: Add long long checks.  Add harness for strtoll and
>         strtoull.  Check decls for strtol, strtoul, strtoll, strtoull.
>         * Makefile.in (CFILES, CONFIGURED_OFILES): Add strtoll and strtoull.
>         * config.in: Regenerate.
>         * configure: Regenerate.
>         * functions.texi: Regenerate.
>         * testsuite/Makefile.in (check-strtol): New rule.
>         (test-strtol): Likewise.
>         (mostlyclean): Clean up strtol test.
>         * testsuite/test-strtol.c: New test.

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

Yury Gribov <y.gribov at samsung dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |y.gribov at samsung dot com

--- Comment #3 from Yury Gribov <y.gribov at samsung dot com> ---
(In reply to John David Anglin from comment #0)
> Maybe asan.c should include "libiberty.h"

Yeah and probably also s/HAVE_LONG_LONG/HAVE_DECL_STRTOULL/ (or maybe
HAVE_STRTOULL?).

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

--- Comment #4 from dave.anglin at bell dot net ---
On 31-Oct-14, at 6:28 AM, y.gribov at samsung dot com wrote:

> Yeah and probably also s/HAVE_LONG_LONG/HAVE_DECL_STRTOULL/ (or maybe
> HAVE_STRTOULL?).

Yes.

--
John David Anglin    dave.anglin@bell.net

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

--- Comment #6 from dave.anglin at bell dot net ---
On 10/31/2014 2:05 PM, y.gribov at samsung dot com wrote:
> John, would you mind sending a (tested) patch to gcc-patches? I only have
> access to Linux systems which are irrelevant.
I believe the attached untested patch fixes the problem on hpux.  However,
I suspect more is needed for mingw, msdosdjgpp, etc.  Can't test these.

Dave

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

--- Comment #7 from dave.anglin at bell dot net ---
This bug is easily fixed by adding declaration checks for the new 
libiberty functions
to configure.ac (both libiberty and gcc), and rebuilding configure and 
config.in.

Sorry, I haven't had time to prepare a patch yet.

Dave

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2014-11-20
     Ever confirmed|0                           |1

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Is this fixed now?

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

--- Comment #9 from Yury Gribov <y.gribov at samsung dot com> ---
I don't think this patch got to gcc-patches.  I don't know how to repro
original error so I can't bootstrap myself.

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

--- Comment #10 from dave.anglin at bell dot net ---
On 11/20/2014 7:45 AM, rguenth at gcc dot gnu.org wrote:
> Is this fixed now?
No.

I have a patch which adds the necessary declaration checks to configure.ac
but have been very busy recently with work and personal issues.

Dave

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

--- Comment #11 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sat Nov 22 20:53:36 2014
New Revision: 217972

URL: https://gcc.gnu.org/viewcvs?rev=217972&root=gcc&view=rev
Log:
    PR other/63694
    * libiberty/configure.ac: Check for strtol, strtoul, strtoll and strtoull
    declarations.
    * libiberty/configure: Regenerated.
    * gcc/configure.ac: Check for strtol, strtoul, strtoll and strtoull
    declarations.
    * gcc/configure: Regenerated.
    * gcc/config.in: Regenerated.


Modified:
    trunk/gcc/config.in
    trunk/gcc/configure
    trunk/gcc/configure.ac
    trunk/libiberty/configure
    trunk/libiberty/configure.ac

[Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.