* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
@ 2014-10-31 2:42 ` danglin at gcc dot gnu.org
2014-10-31 9:47 ` rguenth at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: danglin at gcc dot gnu.org @ 2014-10-31 2:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
John David Anglin <danglin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ygribov at gcc dot gnu.org
--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
It looks like libiberty.h is included but the generated libiberty/config.h
seems incorrect:
/* Define to 1 if you have the declaration of `strtoull', and to 0 if you
don't. */
/* #undef HAVE_DECL_STRTOULL */
/* Define to 1 if you have the declaration of `strverscmp', and to 0 if you
don't. */
#define HAVE_DECL_STRVERSCMP 0
It seems like we should have
#define HAVE_DECL_STRTOULL 0
2014-10-28 Yury Gribov <y.gribov@samsung.com>
* strtoll.c: New file.
* strtoull.c: New file.
* configure.ac: Add long long checks. Add harness for strtoll and
strtoull. Check decls for strtol, strtoul, strtoll, strtoull.
* Makefile.in (CFILES, CONFIGURED_OFILES): Add strtoll and strtoull.
* config.in: Regenerate.
* configure: Regenerate.
* functions.texi: Regenerate.
* testsuite/Makefile.in (check-strtol): New rule.
(test-strtol): Likewise.
(mostlyclean): Clean up strtol test.
* testsuite/test-strtol.c: New test.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
2014-10-31 2:42 ` [Bug other/63694] " danglin at gcc dot gnu.org
@ 2014-10-31 9:47 ` rguenth at gcc dot gnu.org
2014-10-31 10:54 ` y.gribov at samsung dot com
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-10-31 9:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |5.0
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #1)
> It looks like libiberty.h is included but the generated libiberty/config.h
> seems incorrect:
>
> /* Define to 1 if you have the declaration of `strtoull', and to 0 if you
> don't. */
> /* #undef HAVE_DECL_STRTOULL */
>
> /* Define to 1 if you have the declaration of `strverscmp', and to 0 if you
> don't. */
> #define HAVE_DECL_STRVERSCMP 0
>
> It seems like we should have
>
> #define HAVE_DECL_STRTOULL 0
That's equivalent unless somebody else defines HAVE_DECL_STRTOULL to 1.
-E -dD output of asan.c?
> 2014-10-28 Yury Gribov <y.gribov@samsung.com>
>
> * strtoll.c: New file.
> * strtoull.c: New file.
> * configure.ac: Add long long checks. Add harness for strtoll and
> strtoull. Check decls for strtol, strtoul, strtoll, strtoull.
> * Makefile.in (CFILES, CONFIGURED_OFILES): Add strtoll and strtoull.
> * config.in: Regenerate.
> * configure: Regenerate.
> * functions.texi: Regenerate.
> * testsuite/Makefile.in (check-strtol): New rule.
> (test-strtol): Likewise.
> (mostlyclean): Clean up strtol test.
> * testsuite/test-strtol.c: New test.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
2014-10-31 2:42 ` [Bug other/63694] " danglin at gcc dot gnu.org
2014-10-31 9:47 ` rguenth at gcc dot gnu.org
@ 2014-10-31 10:54 ` y.gribov at samsung dot com
2014-10-31 12:44 ` dave.anglin at bell dot net
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: y.gribov at samsung dot com @ 2014-10-31 10:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
Yury Gribov <y.gribov at samsung dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |y.gribov at samsung dot com
--- Comment #3 from Yury Gribov <y.gribov at samsung dot com> ---
(In reply to John David Anglin from comment #0)
> Maybe asan.c should include "libiberty.h"
Yeah and probably also s/HAVE_LONG_LONG/HAVE_DECL_STRTOULL/ (or maybe
HAVE_STRTOULL?).
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (2 preceding siblings ...)
2014-10-31 10:54 ` y.gribov at samsung dot com
@ 2014-10-31 12:44 ` dave.anglin at bell dot net
2014-10-31 20:23 ` dave.anglin at bell dot net
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: dave.anglin at bell dot net @ 2014-10-31 12:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #4 from dave.anglin at bell dot net ---
On 31-Oct-14, at 6:28 AM, y.gribov at samsung dot com wrote:
> Yeah and probably also s/HAVE_LONG_LONG/HAVE_DECL_STRTOULL/ (or maybe
> HAVE_STRTOULL?).
Yes.
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (3 preceding siblings ...)
2014-10-31 12:44 ` dave.anglin at bell dot net
@ 2014-10-31 20:23 ` dave.anglin at bell dot net
2014-11-05 20:30 ` dave.anglin at bell dot net
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: dave.anglin at bell dot net @ 2014-10-31 20:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #6 from dave.anglin at bell dot net ---
On 10/31/2014 2:05 PM, y.gribov at samsung dot com wrote:
> John, would you mind sending a (tested) patch to gcc-patches? I only have
> access to Linux systems which are irrelevant.
I believe the attached untested patch fixes the problem on hpux. However,
I suspect more is needed for mingw, msdosdjgpp, etc. Can't test these.
Dave
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (4 preceding siblings ...)
2014-10-31 20:23 ` dave.anglin at bell dot net
@ 2014-11-05 20:30 ` dave.anglin at bell dot net
2014-11-20 12:45 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: dave.anglin at bell dot net @ 2014-11-05 20:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #7 from dave.anglin at bell dot net ---
This bug is easily fixed by adding declaration checks for the new
libiberty functions
to configure.ac (both libiberty and gcc), and rebuilding configure and
config.in.
Sorry, I haven't had time to prepare a patch yet.
Dave
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (5 preceding siblings ...)
2014-11-05 20:30 ` dave.anglin at bell dot net
@ 2014-11-20 12:45 ` rguenth at gcc dot gnu.org
2014-11-20 13:40 ` y.gribov at samsung dot com
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-11-20 12:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |WAITING
Last reconfirmed| |2014-11-20
Ever confirmed|0 |1
--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Is this fixed now?
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (6 preceding siblings ...)
2014-11-20 12:45 ` rguenth at gcc dot gnu.org
@ 2014-11-20 13:40 ` y.gribov at samsung dot com
2014-11-20 17:23 ` dave.anglin at bell dot net
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: y.gribov at samsung dot com @ 2014-11-20 13:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #9 from Yury Gribov <y.gribov at samsung dot com> ---
I don't think this patch got to gcc-patches. I don't know how to repro
original error so I can't bootstrap myself.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (7 preceding siblings ...)
2014-11-20 13:40 ` y.gribov at samsung dot com
@ 2014-11-20 17:23 ` dave.anglin at bell dot net
2014-11-22 20:54 ` danglin at gcc dot gnu.org
2014-11-22 20:58 ` danglin at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: dave.anglin at bell dot net @ 2014-11-20 17:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #10 from dave.anglin at bell dot net ---
On 11/20/2014 7:45 AM, rguenth at gcc dot gnu.org wrote:
> Is this fixed now?
No.
I have a patch which adds the necessary declaration checks to configure.ac
but have been very busy recently with work and personal issues.
Dave
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (8 preceding siblings ...)
2014-11-20 17:23 ` dave.anglin at bell dot net
@ 2014-11-22 20:54 ` danglin at gcc dot gnu.org
2014-11-22 20:58 ` danglin at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: danglin at gcc dot gnu.org @ 2014-11-22 20:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #11 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sat Nov 22 20:53:36 2014
New Revision: 217972
URL: https://gcc.gnu.org/viewcvs?rev=217972&root=gcc&view=rev
Log:
PR other/63694
* libiberty/configure.ac: Check for strtol, strtoul, strtoll and strtoull
declarations.
* libiberty/configure: Regenerated.
* gcc/configure.ac: Check for strtol, strtoul, strtoll and strtoull
declarations.
* gcc/configure: Regenerated.
* gcc/config.in: Regenerated.
Modified:
trunk/gcc/config.in
trunk/gcc/configure
trunk/gcc/configure.ac
trunk/libiberty/configure
trunk/libiberty/configure.ac
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug other/63694] [5.0 Regression] Build error compiling asan.c: strtoull undeclared
2014-10-31 1:41 [Bug other/63694] New: [5.0 Regression] Build error compiling asan.c: strtoull undeclared danglin at gcc dot gnu.org
` (9 preceding siblings ...)
2014-11-22 20:54 ` danglin at gcc dot gnu.org
@ 2014-11-22 20:58 ` danglin at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: danglin at gcc dot gnu.org @ 2014-11-22 20:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
John David Anglin <danglin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 12+ messages in thread