[Bug fortran/63727] New: Checks missing for proc-pointer components: Usage as actual argument when elemental

[Bug fortran/63727] New: Checks missing for proc-pointer components: Usage as actual argument when elemental

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63727

            Bug ID: 63727
           Summary: Checks missing for proc-pointer components: Usage as
                    actual argument when elemental
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org

The PPC lacks some argument check as the code below should have been rejected
with something like: ELEMENTAL non-INTRINSIC procedure 'x%ptr' is not allowed
as an actual argument.


interface
  elemental subroutine foo()
  end subroutine
end interface

type t
  procedure(foo), pointer, nopass :: ptr
end type t

type(t) :: x
call bar(x%ptr)
end

[Bug fortran/63727] [F03] Checks missing for proc-pointer components: Usage as actual argument when elemental

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63727

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-12-14
                 CC|                            |janus at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org
            Summary|Checks missing for          |[F03] Checks missing for
                   |proc-pointer components:    |proc-pointer components:
                   |Usage as actual argument    |Usage as actual argument
                   |when elemental              |when elemental
     Ever confirmed|0                           |1

--- Comment #1 from janus at gcc dot gnu.org ---
The following is sufficient to reject the code (not regtested yet):


Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c    (Revision 218705)
+++ gcc/fortran/resolve.c    (Arbeitskopie)
@@ -1740,6 +1740,7 @@ resolve_actual_arglist (gfc_actual_arglist *arg, p
   gfc_symbol *sym;
   gfc_symtree *parent_st;
   gfc_expr *e;
+  gfc_component *comp;
   int save_need_full_assumed_size;
   bool return_value = false;
   bool actual_arg_sav = actual_arg, first_actual_arg_sav = first_actual_arg;
@@ -1967,6 +1968,14 @@ resolve_actual_arglist (gfc_actual_arglist *arg, p
         }
     }

+      comp = gfc_get_proc_ptr_comp(e);
+      if (comp && comp->attr.elemental)
+        {
+            gfc_error ("ELEMENTAL procedure pointer component %qs is not "
+                       "allowed as an actual argument at %L", comp->name,
+                       &e->where);
+        }
+
       /* Fortran 2008, C1237.  */
       if (e->expr_type == EXPR_VARIABLE && gfc_is_coindexed (e)
       && gfc_has_ultimate_pointer (e))

[Bug fortran/63727] [F03] Checks missing for proc-pointer components: Usage as actual argument when elemental

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63727

--- Comment #2 from janus at gcc dot gnu.org ---
Author: janus
Date: Mon Dec 15 16:10:50 2014
New Revision: 218751

URL: https://gcc.gnu.org/viewcvs?rev=218751&root=gcc&view=rev
Log:
2014-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/63727
    * resolve.c (resolve_actual_arglist): Check for elemental procedure
    pointer components.


2014-12-15  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/63727
    * gfortran.dg/coarray_collectives_14.f90: Address FIXME item.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90

[Bug fortran/63727] [F03] Checks missing for proc-pointer components: Usage as actual argument when elemental

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63727

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from janus at gcc dot gnu.org ---
Fixed with r218751. Closing.