[Bug fortran/63733] [4.8/4.9/5 Regression] [OOP] wrong resolution for OPERATOR generics

["janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63733

--- Comment #4 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #1)
> likely r195729 (pr54195).

Reverting this commit on trunk yields:

test_ov.f90:7:32:

      generic   :: operator(+) => sum
                                1
Error: Entity »sum_parent« at (1) is already present in the interface


So it's not the cause of this regression either.
>From gcc-bugs-return-472468-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jan 08 13:37:54 2015
Return-Path: <gcc-bugs-return-472468-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8337 invoked by alias); 8 Jan 2015 13:37:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 8302 invoked by uid 48); 8 Jan 2015 13:37:48 -0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/63733] [4.8/4.9/5 Regression] [OOP]  wrong resolution for OPERATOR generics
Date: Thu, 08 Jan 2015 13:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.5
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63733-4-vEaQhj09cF@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63733-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63733-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg00462.txt.bz2
Content-length: 1207

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc733

--- Comment #5 from janus at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #1)
> likely r189022 (pr49591).

I think this one is the culprit. Reverting the relevant part restores the
expected behavior. Patch:


Index: gcc/fortran/resolve.c
==================================================================--- gcc/fortran/resolve.c    (Revision 219342)
+++ gcc/fortran/resolve.c    (Arbeitskopie)
@@ -11894,21 +11894,6 @@ resolve_typebound_intrinsic_op (gfc_symbol* derive

       if (!gfc_check_operator_interface (target_proc, op, p->where))
     goto error;
-
-      /* Add target to non-typebound operator list.  */
-      if (!target->specific->deferred && !derived->attr.use_assoc
-      && p->access != ACCESS_PRIVATE && derived->ns == gfc_current_ns)
-    {
-      gfc_interface *head, *intr;
-      if (!gfc_check_new_interface (derived->ns->op[op], target_proc,
p->where))
-        return false;
-      head = derived->ns->op[op];
-      intr = gfc_get_interface ();
-      intr->sym = target_proc;
-      intr->where = p->where;
-      intr->next = head;
-      derived->ns->op[op] = intr;
-    }
     }

   return true;