[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2014-11-04
   Target Milestone|---                         |4.9.3
            Summary|GCC 4.9.2 bootstrap fails   |[4.9 Regression] GCC 4.9.2
                   |on ARM,                     |bootstrap fails on ARM,
                   |haifa-sched.c:6507:1:       |haifa-sched.c:6507:1:
                   |internal compiler error: in |internal compiler error: in
                   |lra_create                  |lra_create
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Can you provide preprocessed source of haifa-sched.c for the failing command?

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[aaro.koskinen at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #2 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
Created attachment 33885
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33885&action=edit
haifa-sched preprocessed source

This is the preprocessed source of haifa-sched produced with full original xg++
command line with -E added.

I had to compress it as the plain/text version exceeded the 1000 KB attachment
limit.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktkachov at gcc dot gnu.org

--- Comment #3 from ktkachov at gcc dot gnu.org ---
(In reply to Aaro Koskinen from comment #2)
> Created attachment 33885 [details]
> haifa-sched preprocessed source
> 
> This is the preprocessed source of haifa-sched produced with full original
> xg++ command line with -E added.
> 
> I had to compress it as the plain/text version exceeded the 1000 KB
> attachment limit.

I'm getting a whole bunch of frontend errors (and it seems that the .i file is
actually another .gz file that needs to be uncompressed again?)

Could you please produce the preprocessed output by adding -save-temps to the
command line?

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[aaro.koskinen at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Aaro Koskinen <aaro.koskinen at iki dot fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33885|0                           |1
        is obsolete|                            |

--- Comment #4 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
Created attachment 33889
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33889&action=edit
haifa-sched.ii.gz

haifa-sched.ii (gzipped) from -save-temps.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[aaro.koskinen at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #5 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
Created attachment 33890
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33890&action=edit
haifa-sched.s.gz

haifa-sched.s (gzipped) from -save-temps.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[aaro.koskinen at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #6 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
(In reply to Aaro Koskinen from comment #0)
> GCC 4.9.2 native bootstrap on ARM fails with ICE from the second stage
> compiler:
> 
> /home/aaro/gcctest/build/./prev-gcc/xg++

Correction: stage_curr says "stage2" after the failure. So the error is coming
from a compiler built in stage1.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[aaro.koskinen at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #7 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
Result from bisection (4.9 git branch):

611da9dd72a4c9d9ece2a8d24612e4aee435414a is the first bad commit
commit 611da9dd72a4c9d9ece2a8d24612e4aee435414a
Author: jakub <jakub@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Oct 1 14:42:46 2014 +0000

        Backported from mainline
        2014-09-18  Vladimir Makarov  <vmakarov@redhat.com>

        PR debug/63285
        * haifa-sched.c (schedule_block): Advance cycle at the end of BB
        if advance != 0.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[aaro.koskinen at iki dot fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #8 from Aaro Koskinen <aaro.koskinen at iki dot fi> ---
ICE backtrace seems to be same as in Bug 61430. The fix for that has not been
backported to 4.9 branch. I tested it and it seems to fix the issue at hand.

The fix: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=211701

This patch should probably be backported as it is not currently possible to
compile GCC 4.9.2 release on ARM (or maybe some newer ARM archs work).

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|WAITING                     |NEW

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mark P1 so we don't forget to do that.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cltang at gcc dot gnu.org,
                   |                            |ramana at gcc dot gnu.org

--- Comment #10 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Useful to CC the original author :)

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #11 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
*** Bug 63771 has been marked as a duplicate of this bug. ***

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Any progress on this?

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[mkuvyrkov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #13 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #12)
> Any progress on this?

This has slipped off my radar.  Thanks for the ping, I'm working on this now.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[mkuvyrkov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mkuvyrkov at gcc dot gnu.org       |vmakarov at gcc dot gnu.org

--- Comment #14 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
OK, I'm not sorry after all, this was not supposed to be on my radar :-).

Re-assigning to the right person -- Vladimir.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #15 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
The insn in question is
 (insn 3598 3597 6907 395 (parallel [
            (set (reg:CC 100 cc)
                (compare:CC (reg:SI 307 [ ls$2 ])
                    (const_int 0 [0])))
            (set (reg:SI 192 [ D.62648 ])
                (reg:SI 307 [ ls$2 ]))
        ]) ../../gcc-4.9.2/gcc/haifa-sched.c:6368 204 {*movsi_compare0}
     (expr_list:REG_DEAD (reg:SI 307 [ ls$2 ])
        (expr_list:REG_UNUSED (reg:CC 100 cc)
            (nil))))

The insn definition is

(define_insn "*movsi_compare0"
  [(set (reg:CC CC_REGNUM)
        (compare:CC (match_operand:SI 1 "s_register_operand" "0,r")
                    (const_int 0)))
   (set (match_operand:SI 0 "s_register_operand" "=r,r")
        (match_dup 1))]

LRA choosing the first alternative where the 0 and 1 operand should be the same
and generates

(insn 3598 7755 7756 395 (parallel [
            (set (reg:CC 100 cc)
                (compare:CC (reg:SI 3686 [orig:192 D.62648 ] [192])
                    (const_int 0 [0])))
            (set (reg:SI 3686 [orig:192 D.62648 ] [192])
                (reg:SI 3686 [orig:192 D.62648 ] [192]))
        ]) ../../gcc-4.9.2/gcc/haifa-sched.c:6368 204 {*movsi_compare0}
     (expr_list:REG_DEAD (reg:SI 307 [ ls$2 ])
        (expr_list:REG_UNUSED (reg:CC 100 cc)
            (nil))))

The generated ins is ok.  The code in lra_lives.c::process_bb_lives is

          if (dst_regno >= lra_constraint_new_regno_start
              && src_regno >= lra_constraint_new_regno_start)
            lra_create_copy (dst_regno, src_regno, freq);

The code was written to process reload insns only but insn 3598 looks like
reload because it is a single_set insn (reg 100 is unused).

lra_create_copy has an assertion that dst_regno and src_regno are different
which fails.

The fix should be trivial.  I'll commit it soon.

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #16 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Author: vmakarov
Date: Mon Jun 22 18:17:28 2015
New Revision: 224752

URL: https://gcc.gnu.org/viewcvs?rev=224752&root=gcc&view=rev
Log:
2015-06-22  Vladimir Makarov  <vmakarov@redhat.com>

        PR bootstrap/63740
        * lra-lives.c (process_bb_lives): Check insn copying the same
        reload pseudo and don't create a copy for it.


Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/lra-lives.c

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #17 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Author: vmakarov
Date: Mon Jun 22 18:45:58 2015
New Revision: 224753

URL: https://gcc.gnu.org/viewcvs?rev=224753&root=gcc&view=rev
Log:
2015-06-22  Vladimir Makarov  <vmakarov@redhat.com>

        PR bootstrap/63740
        * lra-lives.c (process_bb_lives): Check insn copying the same
        reload pseudo and don't create a copy for it.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lra-lives.c

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

--- Comment #18 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
Author: vmakarov
Date: Mon Jun 22 20:48:05 2015
New Revision: 224761

URL: https://gcc.gnu.org/viewcvs?rev=224761&root=gcc&view=rev
Log:
2015-06-22  Vladimir Makarov  <vmakarov@redhat.com>

        PR bootstrap/63740
        * lra-lives.c (process_bb_lives): Check insn copying the same
        reload pseudo and don't create a copy for it.


Modified:
    branches/gcc-5-branch/gcc/ChangeLog
    branches/gcc-5-branch/gcc/lra-lives.c

[Bug bootstrap/63740] [4.9 Regression] GCC 4.9.2 bootstrap fails on ARM, haifa-sched.c:6507:1: internal compiler error: in lra_create

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63740

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #19 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.