[Bug libobjc/63765] New: [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[Bug libobjc/63765] New: [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

            Bug ID: 63765
           Summary: [5.0 Regression] libobjc testsuite failures on AIX
                    caused by setting _XOPEN_SOURCE
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: libobjc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dje at gcc dot gnu.org

The Objective C testsuite results have regressed from 1 failure to 180 failures
after the libobjc patch was applied.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |powerpc-ibm-aix*
             Status|UNCONFIRMED                 |NEW
                URL|                            |https://gcc.gnu.org/ml/gcc-
                   |                            |patches/2014-11/msg00073.ht
                   |                            |ml
   Last reconfirmed|                            |2014-11-06
                 CC|                            |ro at gcc dot gnu.org
   Target Milestone|---                         |5.0
     Ever confirmed|0                           |1

--- Comment #1 from David Edelsohn <dje at gcc dot gnu.org> ---
Confirmed.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gcc.gnu.org/ml/gcc- |
                   |patches/2014-11/msg00073.ht |
                   |ml                          |
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Caused by:
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00073.html

Let's only define the new value for Solaris instead of for everyone.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 33916
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33916&action=edit
proposed patch

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #5 from David Edelsohn <dje at gcc dot gnu.org> ---
If _XOPEN_SOURCE is removed from thr.c completely, the testsuite results revert
to 1 failure.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #6 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #5 from David Edelsohn <dje at gcc dot gnu.org> ---
> If _XOPEN_SOURCE is removed from thr.c completely, the testsuite results revert
> to 1 failure.

Did this failure already exist before my patch?  If so, such a change is
certainly better than arch-specific _XOPEN_SOURCE values.  Andrew, what
do you thing?

Thanks.
        Rainer

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #7 from David Edelsohn <dje at gcc dot gnu.org> ---
Yes, the single objc failure existed before the patch. But I don't know if
*other* targets need _XOPEN_SOURCE=500.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #7 from David Edelsohn <dje at gcc dot gnu.org> ---
> Yes, the single objc failure existed before the patch. But I don't know if
> *other* targets need _XOPEN_SOURCE=500.

True, but now (end of stage1) is the time to find out.  In most
compilation environments, defining no feature test macros gives you the
superset of everything available.

Ultimately, it's Andrew's call.

    Rainer

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Let's go with the one defining _XOPEN_SOURCE only for Solaris until someone
programs David's suggestion of the host-specific configure file.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #11 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #9 from David Edelsohn <dje at gcc dot gnu.org> ---
> I would have expected _XOPEN_SOURCE=500 to be defined in a host-specific
> configure file (like libstdc++-v3/config/os/.../os_defines.h) or added to the
> compile line in configure.

Given how little target-specific configuration libobjc needs, this seems
overkill to me.

    Rainer

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #12 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
> Let's go with the one defining _XOPEN_SOURCE only for Solaris until someone
> programs David's suggestion of the host-specific configure file.

Huh?  As I've just checked, both Solaris and Linux/x86_64 do fine
without any definition of _XOPEN_SOURCE at all, as does AIX.  Only if
_XOPEN_SOURCE is defined at all does Solaris need a value >= 600 with
C99 and beyond.

The attached patch does just that.

    Rainer

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #13 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 33933
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33933&action=edit
alternative patch

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #14 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #11)
> > --- Comment #9 from David Edelsohn <dje at gcc dot gnu.org> ---
> > I would have expected _XOPEN_SOURCE=500 to be defined in a host-specific
> > configure file (like libstdc++-v3/config/os/.../os_defines.h) or added to the
> > compile line in configure.
> 
> Given how little target-specific configuration libobjc needs, this seems
> overkill to me.

That is because it picks up most of it from GCC's target headers right now.  I
had plans to changing that but I never got around fixing that around 9 years
ago :).

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #15 from Rainer Orth <ro at gcc dot gnu.org> ---
I've never received comments on my alternative patch.  Either that one, which I
prefer since it's cleaner) or the previous one (ugly and target-specific),
needs
to be applied to have AIX bootstrap, I believe.

What should we do?

  Rainer

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #16 from David Edelsohn <dje at gcc dot gnu.org> ---
The alternative patch works on AIX.  I thought that it was going to be
installed.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #17 from David Edelsohn <dje at gcc dot gnu.org> ---
What other comments are needed to install the alternative patch?  It works for
Solaris and AIX, where the problems started.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #18 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to David Edelsohn from comment #16)
> The alternative patch works on AIX.  I thought that it was going to be
> installed.

I don't remember it being ever posted to gcc-patches, patch review doesn't
happen in bugzilla.

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/ml/gcc-
                   |                            |patches/2015-01/msg02468.ht
                   |                            |ml

--- Comment #19 from Rainer Orth <ro at gcc dot gnu.org> ---
Done now.

I hadn't posted the patches so far, since Andrew as libobjc maintainer had
commented on the first proposol in the PR already.

  Rainer

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

--- Comment #20 from Rainer Orth <ro at gcc dot gnu.org> ---
Author: ro
Date: Thu Feb  5 09:41:44 2015
New Revision: 220438

URL: https://gcc.gnu.org/viewcvs?rev=220438&root=gcc&view=rev
Log:
Fix failures on AIX (PR libobjc/63765)

    PR libobjc/63765
    * thr.c (_XOPEN_SOURCE): Remove.

Modified:
    trunk/libobjc/ChangeLog
    trunk/libobjc/thr.c

[Bug libobjc/63765] [5.0 Regression] libobjc testsuite failures on AIX caused by setting _XOPEN_SOURCE

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63765

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #21 from Rainer Orth <ro at gcc dot gnu.org> ---
Fixed for 5.0.