[Bug bootstrap/63811] New: r217322 breaks bootstrap

[Bug bootstrap/63811] New: r217322 breaks bootstrap

[howarth at bromo dot med.uc.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63811

            Bug ID: 63811
           Summary: r217322 breaks bootstrap
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: howarth at bromo dot med.uc.edu

On x86_64-apple-darwin14, at r217330, the bootstrap now fails at...

make[5]: Entering directory
'/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include'
mkdir -p ./x86_64-apple-darwin13.4.0/bits/stdc++.h.gch
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/./gcc/xgcc -shared-libgcc
-B/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/./gcc -nostdinc++
-L/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/src
-L/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/src/.libs
-L/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/libsupc++/.libs
-B/sw/lib/gcc5.0/x86_64-apple-darwin13.4.0/bin/
-B/sw/lib/gcc5.0/x86_64-apple-darwin13.4.0/lib/ -isystem
/sw/lib/gcc5.0/x86_64-apple-darwin13.4.0/include -isystem
/sw/lib/gcc5.0/x86_64-apple-darwin13.4.0/sys-include    -x c++-header
-nostdinc++ -g -O2 
-I/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include/x86_64-apple-darwin13.4.0
-I/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include
-I/sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20141110/libstdc++-v3/libsupc++ -O2
-g -std=gnu++0x
/sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20141110/libstdc++-v3/include/precompiled/stdc++.h
\
-o x86_64-apple-darwin13.4.0/bits/stdc++.h.gch/O2ggnu++0x.gch
In file included from /usr/include/assert.h:42:0,
                 from
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include/cassert:43,
                 from
/sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20141110/libstdc++-v3/include/precompiled/stdc++.h:33:
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include/bits/stl_deque.h:
In member function ‘std::_Deque_base<_Tp, _Alloc>::_Deque_impl
std::_Deque_base<_Tp, _Alloc>::_M_move_impl()’:
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include/bits/stl_deque.h:645:17:
error: expected primary-expression before ‘__attribute__’
  _Tp_alloc_type __unused __attribute((__unused__)) {std::move(__alloc)};
                 ^
Makefile:1615: recipe for target
'x86_64-apple-darwin13.4.0/bits/stdc++.h.gch/O2ggnu++0x.gch' failed
make[5]: *** [x86_64-apple-darwin13.4.0/bits/stdc++.h.gch/O2ggnu++0x.gch] Error
1
make[5]: Leaving directory
'/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3/include'
Makefile:485: recipe for target 'all-recursive' failed
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory
'/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3'
Makefile:391: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory
'/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/x86_64-apple-darwin13.4.0/libstdc++-v3'
Makefile:12208: recipe for target 'all-stage1-target-libstdc++-v3' failed
make[2]: *** [all-stage1-target-libstdc++-v3] Error 2
make[2]: Leaving directory '/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir'
Makefile:20568: recipe for target 'stage1-bubble' failed
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory '/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir'
Makefile:912: recipe for target 'all' failed
make: *** [all] Error 2

Suspect this is due to...

r217322 | redi | 2014-11-10 17:44:07 -0500 (Mon, 10 Nov 2014) | 13 lines

Fix std::deque move construction with non-equal allocators.

        * include/bits/stl_deque.h (_Deque_base::_Deque_base(_Deque_base&&)):
        Dispatch according to whether allocators are always equal.
        (_Deque_base::_M_move_impl()): Implement move-from state.
        * testsuite/23_containers/deque/requirements/dr438/assign_neg.cc: Fix
        dg-error line number.
        * testsuite/23_containers/deque/requirements/dr438/
        constructor_1_neg.cc: Likewise.
        * testsuite/23_containers/deque/requirements/dr438/
        constructor_2_neg.cc: Likewise.
        * testsuite/23_containers/deque/requirements/dr438/insert_neg.cc:
        Likewise.
>From gcc-bugs-return-466309-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 11 03:43:17 2014
Return-Path: <gcc-bugs-return-466309-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1497 invoked by alias); 11 Nov 2014 03:43:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1451 invoked by uid 48); 11 Nov 2014 03:43:10 -0000
From: "e29253 at jp dot ibm.com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/63812] New: Compilation error due to a large floating point constant truncated to integer
Date: Tue, 11 Nov 2014 03:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: e29253 at jp dot ibm.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc
Message-ID: <bug-63812-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg00781.txt.bz2
Content-length: 1538

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc812

            Bug ID: 63812
           Summary: Compilation error due to a large floating point
                    constant truncated to integer
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: e29253 at jp dot ibm.com
                CC: cmang at google dot com

GCCGO cannot compile the following program, while GC can compile and run the
same program. This program is derived from a unit test of Docker
(https://github.com/docker/docker/blob/master/pkg/units/size_test.go#L28):

inagaki@black3:~/size_test$ cat example.go
package main

import "fmt"

func main() {
  fmt.Println(int64(2.22*1000000000000000))
}
inagaki@black3:~/size_test$ gccgo example.go
example.go:6:15: error: floating point constant truncated to integer
   fmt.Println(int64(2.22*1000000000000000))
               ^
inagaki@black3:~/size_test$ /usr/bin/go build example.go
inagaki@black3:~/size_test$ ./example
2220000000000000
inagaki@black3:~/size_test$ gccgo --version
gccgo.bin (GCC) 5.0.0 20141029 (experimental)
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

inagaki@black3:~/size_test$

The example can be successfully compiled if the constant value is smaller, for
example, 2.22*10^12.

[Bug bootstrap/63811] r217322 breaks bootstrap

[howarth at bromo dot med.uc.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63811

--- Comment #1 from howarth at bromo dot med.uc.edu ---
The change...

Index: libstdc++-v3/include/bits/stl_deque.h
===================================================================
--- libstdc++-v3/include/bits/stl_deque.h    (revision 217331)
+++ libstdc++-v3/include/bits/stl_deque.h    (working copy)
@@ -642,7 +642,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
     // Create a copy of the current allocator.
     _Tp_alloc_type __alloc{_M_get_Tp_allocator()};
     // Put that copy in a moved-from state.
-    _Tp_alloc_type __unused __attribute((__unused__)) {std::move(__alloc)};
+    _Tp_alloc_type __unused__ __attribute((__unused__)) {std::move(__alloc)};
     // Create an empty map that allocates using the moved-from allocator.
     _Deque_base __empty{__alloc};
     // Now safe to modify current allocator and perform non-throwing swaps.

eliminates the bootstrap error

[Bug libstdc++/63811] r217322 breaks bootstrap

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63811

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-11
                 CC|                            |fxcoudert at gcc dot gnu.org,
                   |                            |jwakely.gcc at gmail dot com
          Component|bootstrap                   |libstdc++
     Ever confirmed|0                           |1

[Bug libstdc++/63811] r217322 breaks bootstrap

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63811

--- Comment #2 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
The libstdc++'s own manual says that __unused is a bad identifier, because it's
reserved by BSD:
https://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html#coding_style.bad_identifiers

So renaming it to anything else makes bootstrap work again:

Index: include/bits/stl_deque.h
===================================================================
--- include/bits/stl_deque.h    (revision 217342)
+++ include/bits/stl_deque.h    (working copy)
@@ -642,7 +642,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
     // Create a copy of the current allocator.
     _Tp_alloc_type __alloc{_M_get_Tp_allocator()};
     // Put that copy in a moved-from state.
-    _Tp_alloc_type __unused __attribute((__unused__)) {std::move(__alloc)};
+    _Tp_alloc_type __unused1 __attribute((__unused__)) {std::move(__alloc)};
     // Create an empty map that allocates using the moved-from allocator.
     _Deque_base __empty{__alloc};
     // Now safe to modify current allocator and perform non-throwing swaps.

[Bug libstdc++/63811] r217322 breaks bootstrap

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63811

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Tue Nov 11 10:41:46 2014
New Revision: 217343

URL: https://gcc.gnu.org/viewcvs?rev=217343&root=gcc&view=rev
Log:
    PR libstdc++/63811
    * include/bits/stl_deque.h (_Deque_base::_M_move_impl()): Avoid using
    badname.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/stl_deque.h

[Bug libstdc++/63811] r217322 breaks bootstrap

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63811

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Confirmed fixed.