[Bug target/63848] New: [5.0 regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[Bug target/63848] New: [5.0 regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

            Bug ID: 63848
           Summary: [5.0 regression] FAIL:
                    c-c++-common/torture/builtin-arith-overflow-17.c   -O0
                     execution test
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: schwab@linux-m68k.org
                CC: jakub at redhat dot com
            Target: ia64-*-*

This fails at any opt level.  Also failing are b-a-o-18.c (t103sub) and
b-a-o-6.c (t153add).

Breakpoint 2, bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
17        v++;
(gdb) bt
#0  bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
#1  0x4000000000044430 in t132_1add (x=0x3fffffffffffffffffffffffffffffff, 
    y=0x40000000000000000000000000000000)
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#2  0x4000000000044c90 in t132add ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#3  0x400000000006e670 in main ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:18
(gdb) c
Continuing.

Breakpoint 2, bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
17        v++;
(gdb) bt
#0  bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
#1  0x4000000000044600 in t132_2add (y=0x40000000000000000000000000000000)
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#2  0x4000000000044cf0 in t132add ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#3  0x400000000006e670 in main ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:18
(gdb) c
Continuing.

Breakpoint 2, bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
17        v++;
(gdb) bt
#0  bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
#1  0x40000000000449d0 in t132_4add (x=0x3fffffffffffffffffffffffffffffff)
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#2  0x4000000000044db0 in t132add ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#3  0x400000000006e670 in main ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:18
(gdb) c
Continuing.

Breakpoint 2, bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
17        v++;
(gdb) bt
#0  bar ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow.h:17
#1  0x4000000000044f70 in t132add ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#2  0x400000000006e670 in main ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:18
(gdb) c
Continuing.

Program received signal SIGABRT, Aborted.
0xa000000000040721 in __kernel_syscall_via_break ()
(gdb) bt
#0  0xa000000000040721 in __kernel_syscall_via_break ()
#1  0x20000000001b2ad0 in *__GI_raise (sig=<optimized out>)
    at ../nptl/sysdeps/unix/sysv/linux/raise.c:67
#2  0x20000000001b53b0 in *__GI_abort () at abort.c:92
#3  0x40000000000450d0 in t132add ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:10
#4  0x400000000006e670 in main ()
    at
/usr/local/gcc/gcc-20141113/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-17.c:18

[Bug target/63848] [5.0 regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[matthew.fortune at imgtec dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

Matthew Fortune <matthew.fortune at imgtec dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matthew.fortune at imgtec dot com

--- Comment #1 from Matthew Fortune <matthew.fortune at imgtec dot com> ---
I am seeing multiple failures for the builtin-arith-overflow tests on MIPS64 as
well. I have not yet had time to investigate much but it may be due to some
missing sign extension and/or performing a range test using bitwise comparison.

[Bug target/63848] [5.0 regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktkachov at gcc dot gnu.org

--- Comment #2 from ktkachov at gcc dot gnu.org ---
Seeing these on aarch64-none-elf as well btw

[Bug target/63848] [5.0 regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug target/63848] [5 Regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to ktkachov from comment #2)
> Seeing these on aarch64-none-elf as well btw

I filed the aarch64 ones as bug 63975.

[Bug target/63848] [5 Regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-11-21
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 34069
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34069&action=edit
gcc5-pr63848.patch

Untested fix.

Apparently on some targets for some modes emit_cmp_and_jump_insns silently
generates wrong code, so one needs to use do_compare_rtx_and_jump which wraps
that and handles the wider modes.  Unfortunately the two functions have
different order of arguments (and do_compare_rtx_and_jump one additional one).
built-arith-overflow* still passes on x86_64-linux and i686-linux with this,
haven't bootstrapped/regtested it yet (but, on these targets it doesn't make
much difference, as there are even TImode comparison patterns for -m64 and
DImode for -m32).

[Bug target/63848] [5 Regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

--- Comment #5 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Jakub Jelinek from comment #4)
> Created attachment 34069 [details]
> gcc5-pr63848.patch
> 
> Untested fix.

Yes, this fixes failures for alpha with:

gmake -j 4 -k check RUNTESTFLAGS=dg-torture.exp=builtin-arith-overflow-*.c
>From gcc-bugs-return-467988-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Nov 21 18:03:47 2014
Return-Path: <gcc-bugs-return-467988-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22754 invoked by alias); 21 Nov 2014 18:03:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 22613 invoked by uid 55); 21 Nov 2014 18:03:43 -0000
From: "meissner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63965] [5 Regression] ICE: in extract_constrain_insn, at recog.c:2230 on ppc64
Date: Fri, 21 Nov 2014 18:03:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: meissner at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: meissner at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63965-4-6Fet5lkGcd@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63965-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63965-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg02460.txt.bz2
Content-length: 939

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc965

--- Comment #6 from Michael Meissner <meissner at gcc dot gnu.org> ---
Author: meissner
Date: Fri Nov 21 18:03:09 2014
New Revision: 217940

URL: https://gcc.gnu.org/viewcvs?rev!7940&root=gcc&view=rev
Log:
2014-11-21  Michael Meissner  <meissner@linux.vnet.ibm.com>

    PR target/63965
    * config/rs6000/rs6000.c (rs6000_setup_reg_addr_masks): Do not set
    Altivec & -16 mask if the type is not valid for Altivec registers.
    (rs6000_secondary_reload_memory): Add support for ((reg + const) +
    reg) that occurs during push_reload processing.

    * config/rs6000/altivec.md (altivec_mov<mode>): Add instruction
    alternative for moving constant vectors which are easy altivec
    constants to GPRs.  Set the length attribute each of the
    alternatives.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000-cpus.def
    trunk/gcc/config/rs6000/rs6000.c

[Bug target/63848] [5 Regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Nov 21 20:42:20 2014
New Revision: 217946

URL: https://gcc.gnu.org/viewcvs?rev=217946&root=gcc&view=rev
Log:
    PR target/63848
    PR target/63975
    * internal-fn.c (expand_arith_overflow_result_store,
    expand_addsub_overflow, expand_neg_overflow, expand_mul_overflow): Use
    do_compare_rtx_and_jump instead of emit_cmp_and_jump_insns everywhere,
    adjust arguments to those functions.  Use unsignedp = true for
    EQ, NE, GEU, LEU, LTU and GTU comparisons.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/internal-fn.c

[Bug target/63848] [5 Regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug target/63848] [5 Regression] FAIL: c-c++-common/torture/builtin-arith-overflow-17.c -O0 execution test

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63848

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 63975 has been marked as a duplicate of this bug. ***