public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vekumar at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/63850] Building TSAN for Aarch64 results in assembler Error
Date: Tue, 20 Jan 2015 06:06:00 -0000	[thread overview]
Message-ID: <bug-63850-4-sThV6igJkD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63850-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63850

--- Comment #7 from vekumar at gcc dot gnu.org ---
(In reply to clyon from comment #6)
> Venkat,
> Can you submit your GCC patch, in an accepable way? (no change to sanitizer
> libs code, and obviously do not activate tsan by default)

Okay I will send out a patch that modifies libsanitizer/configure.ac and
libsanitizer/tsan/Makefile.am that will separate out tsan_rtl_amd64.S from
getting build for other targets.


--- a/libsanitizer/tsan/tsan_rtl.h
+++ b/libsanitizer/tsan/tsan_rtl.h
@@ -679,7 +679,7 @@ void AcquireReleaseImpl(ThreadState *thr, uptr pc,
SyncClock *c);
 // The trick is that the call preserves all registers and the compiler
 // does not treat it as a call.
 // If it does not work for you, use normal call.
-#if TSAN_DEBUG == 0
+#if defined(__x86_64__) && TSAN_DEBUG == 0

This change is also acceptable?


  parent reply	other threads:[~2015-01-20  6:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 12:09 [Bug sanitizer/63850] New: Building TSAN for Aarch64 results in assembler venkataramanan.kumar at amd dot com
2014-11-13 12:51 ` [Bug sanitizer/63850] Building TSAN for Aarch64 results in assembler Error dvyukov at google dot com
2014-11-13 13:12 ` clyon at gcc dot gnu.org
2014-11-13 14:32 ` dvyukov at google dot com
2015-01-19  7:36 ` vekumar at gcc dot gnu.org
2015-01-19  7:49 ` dvyukov at google dot com
2015-01-19 20:46 ` clyon at gcc dot gnu.org
2015-01-20  6:06 ` vekumar at gcc dot gnu.org [this message]
2015-01-20  6:44 ` dvyukov at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63850-4-sThV6igJkD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).