public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "venkataramanan.kumar at amd dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/63850] New: Building TSAN for Aarch64 results in assembler
Date: Thu, 13 Nov 2014 12:09:00 -0000	[thread overview]
Message-ID: <bug-63850-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63850

            Bug ID: 63850
           Summary: Building TSAN for Aarch64 results in assembler
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: venkataramanan.kumar at amd dot com
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

After enabling TSAN for Aarch64, building it results in Assembler errors.

tmp/cc02YOZf.s:22856: Error: unknown mnemonic `call' -- `call
__tsan_trace_switch_thunk'
/tmp/cc02YOZf.s:22856: Error: operand 1 should be an integer or stack
pointer register -- `add $1024,%rsp'
/tmp/cc02YOZf.s:23297: Error: operand 1 should be an integer or stack
pointer register -- `sub $1024,%rsp'


The function "TraceAddEvent" adds "HACKY_CALL" which is defined for X86_64.

void ALWAYS_INLINE TraceAddEvent(ThreadState *thr, FastState fs,
                                        EventType typ, u64 addr) {
  if (!kCollectHistory)
    return;
  DCHECK_GE((int)typ, 0);
  DCHECK_LE((int)typ, 7);
  DCHECK_EQ(GetLsb(addr, 61), addr);
  StatInc(thr, StatEvents);
  u64 pos = fs.GetTracePos();
  if (UNLIKELY((pos % kTracePartSize) == 0)) {
#ifndef TSAN_GO
    HACKY_CALL(__tsan_trace_switch);
#else
    TraceSwitch(thr);
#endif
  }
  Event *trace = (Event*)GetThreadTrace(fs.tid());
  Event *evp = &trace[pos];
  Event ev = (u64)addr | ((u64)typ << 61);
  *evp = ev;
}

}  // namespace __tsan


#if TSAN_DEBUG == 0
// The caller may not create the stack frame for itself at all,
// so we create a reserve stack frame for it (1024b must be enough).
#define HACKY_CALL(f) \
  __asm__ __volatile__("sub $1024, %%rsp;" \
                       CFI_INL_ADJUST_CFA_OFFSET(1024) \
                       ".hidden " #f "_thunk;" \
                       "call " #f "_thunk;" \
                       "add $1024, %%rsp;" \
                       CFI_INL_ADJUST_CFA_OFFSET(-1024) \
                       ::: "memory", "cc");
#else
#define HACKY_CALL(f) f()
#endif

Making #if 0 & TSAN_DEBUG == 0 also results in Assembler errors. TSAN make
system includes x86_64 assembly file.

I am looking at ways to fix it and functionally build TSAN for Aarch64


             reply	other threads:[~2014-11-13 12:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13 12:09 venkataramanan.kumar at amd dot com [this message]
2014-11-13 12:51 ` [Bug sanitizer/63850] Building TSAN for Aarch64 results in assembler Error dvyukov at google dot com
2014-11-13 13:12 ` clyon at gcc dot gnu.org
2014-11-13 14:32 ` dvyukov at google dot com
2015-01-19  7:36 ` vekumar at gcc dot gnu.org
2015-01-19  7:49 ` dvyukov at google dot com
2015-01-19 20:46 ` clyon at gcc dot gnu.org
2015-01-20  6:06 ` vekumar at gcc dot gnu.org
2015-01-20  6:44 ` dvyukov at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63850-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).