[Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation?

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation?
@ 2014-11-14  0:47 hjl.tools at gmail dot com
  2014-11-14  0:50 ` [Bug libstdc++/63860] " pinskia at gcc dot gnu.org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: hjl.tools at gmail dot com @ 2014-11-14  0:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

            Bug ID: 63860
           Summary: Ill-formed std::pair::swap implementation?
           Product: gcc
           Version: 4.8.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com

According to

http://llvm.org/bugs/show_bug.cgi?id=21565

and

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20141110/118441.html

std::pair::swap implementation in libstdc++ in GCC 4.8.3 is ill-formed.
I checked trunk and it isn't changed.  Is libstdc++ wrong here?


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
@ 2014-11-14  0:50 ` pinskia at gcc dot gnu.org
  2014-11-14  1:02 ` redi at gcc dot gnu.org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2014-11-14  0:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely because 4.8.3 did not fully implement C++11.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
  2014-11-14  0:50 ` [Bug libstdc++/63860] " pinskia at gcc dot gnu.org
@ 2014-11-14  1:02 ` redi at gcc dot gnu.org
  2014-11-14  1:11 ` redi at gcc dot gnu.org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2014-11-14  1:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-14
     Ever confirmed|0                           |1

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #1)
> Most likely because 4.8.3 did not fully implement C++11.

No, it's just a bug in libstdc++


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
  2014-11-14  0:50 ` [Bug libstdc++/63860] " pinskia at gcc dot gnu.org
  2014-11-14  1:02 ` redi at gcc dot gnu.org
@ 2014-11-14  1:11 ` redi at gcc dot gnu.org
  2014-11-14  1:15 ` richard-gccbugzilla at metafoo dot co.uk
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2014-11-14  1:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Created attachment 33965
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33965&action=edit
untested patch

I think this makes the code valid


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
                   ` (2 preceding siblings ...)
  2014-11-14  1:11 ` redi at gcc dot gnu.org
@ 2014-11-14  1:15 ` richard-gccbugzilla at metafoo dot co.uk
  2014-12-21 15:46 ` hjl.tools at gmail dot com
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: richard-gccbugzilla at metafoo dot co.uk @ 2014-11-14  1:15 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

Richard Smith <richard-gccbugzilla at metafoo dot co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |richard-gccbugzilla@metafoo
                   |                            |.co.uk

--- Comment #4 from Richard Smith <richard-gccbugzilla at metafoo dot co.uk> ---
The proposed change looks correct to me. You'd need to also address the same
issue in std::array, std::priority_queue, std::stack, and std::queue (and in
the std::array variant in the debug and profile variants of libstdc++ too).


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
                   ` (3 preceding siblings ...)
  2014-11-14  1:15 ` richard-gccbugzilla at metafoo dot co.uk
@ 2014-12-21 15:46 ` hjl.tools at gmail dot com
  2015-03-05 17:40 ` ville.voutilainen at gmail dot com
  2015-04-22 11:58 ` jakub at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: hjl.tools at gmail dot com @ 2014-12-21 15:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |redi at gcc dot gnu.org
            Version|4.8.3                       |5.0
   Target Milestone|---                         |5.0
      Known to fail|                            |4.8.4, 4.9.3, 5.0

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
Doesn't GCC 5 have the same problem?


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
                   ` (4 preceding siblings ...)
  2014-12-21 15:46 ` hjl.tools at gmail dot com
@ 2015-03-05 17:40 ` ville.voutilainen at gmail dot com
  2015-04-22 11:58 ` jakub at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: ville.voutilainen at gmail dot com @ 2015-03-05 17:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

Ville Voutilainen <ville.voutilainen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ville.voutilainen at gmail dot com

--- Comment #6 from Ville Voutilainen <ville.voutilainen at gmail dot com> ---
This is
http://cplusplus.github.io/LWG/lwg-active.html#2456
and I have a patch for it at
https://github.com/villevoutilainen/gcc/tree/is_nothrow_swappable
which will be submitted after gcc5 is released.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libstdc++/63860] Ill-formed std::pair::swap implementation?
  2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
                   ` (5 preceding siblings ...)
  2015-03-05 17:40 ` ville.voutilainen at gmail dot com
@ 2015-04-22 11:58 ` jakub at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-04-22 11:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63860

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0                         |5.2

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 5.1 has been released.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-04-22 11:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-14  0:47 [Bug libstdc++/63860] New: Ill-formed std::pair::swap implementation? hjl.tools at gmail dot com
2014-11-14  0:50 ` [Bug libstdc++/63860] " pinskia at gcc dot gnu.org
2014-11-14  1:02 ` redi at gcc dot gnu.org
2014-11-14  1:11 ` redi at gcc dot gnu.org
2014-11-14  1:15 ` richard-gccbugzilla at metafoo dot co.uk
2014-12-21 15:46 ` hjl.tools at gmail dot com
2015-03-05 17:40 ` ville.voutilainen at gmail dot com
2015-04-22 11:58 ` jakub at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).