[Bug libgomp/63868] New: [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[Bug libgomp/63868] New: [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

            Bug ID: 63868
           Summary: [5 Regression] Multiple failures in the libgomp test
                    suite between r217458 and r217501.
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: jakub at gcc dot gnu.org

Multiple failures appeared in the libgomp test suite between r217458 and
r217501,
see for instance https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00309.html.

On x86_64-apple-darwin14, all the failures are UNRESOLVED and the errors are of
the kind

[Book15] f90/bug% gfc -fopenmp
/opt/gcc/work/libgomp/testsuite/libgomp.fortran/target1.f90
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:1940:Expected
comma after segment-name
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:1940:Rest of line
ignored. 1st junk character valued 32 ( ).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:1944:Expected
comma after segment-name
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:1944:Rest of line
ignored. 1st junk character valued 32 ( ).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2290:Expected
comma after segment-name
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2290:Rest of line
ignored. 1st junk character valued 32 ( ).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2293:Expected
comma after segment-name
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2293:Rest of line
ignored. 1st junk character valued 32 ( ).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2332:Expected
comma after segment-name
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2332:Rest of line
ignored. 1st junk character valued 32 ( ).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2332:Junk
character 48 (0).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2332:Rest of line
ignored. 1st junk character valued 111 (o).
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccH5c7Zy.s:2427:Expected
comma after segment-name
...

with the default as and

[Book15] f90/bug% gfc -fopenmp
/opt/gcc/work/libgomp/testsuite/libgomp.fortran/target1.f90 -Wa,-q
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccrwTRRF.s:1940:28: error:
unexpected token in '.section' directive
        .section .gnu.offload_vars
                                  ^
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccrwTRRF.s:1945:29: error:
unexpected token in '.section' directive
        .section .gnu.offload_funcs
                                   ^
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccrwTRRF.s:2292:52: error:
unexpected token in '.section' directive
        .section .gnu.offload_lto_.inline.7a3ca29239cf7041
                                                          ^
/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccrwTRRF.s:2296:72: error:
unexpected token in '.section' directive
        .section .gnu.offload_lto___target1_MOD_foo._omp_fn.2.7a3ca29239cf7041
                                                                              ^
...

withe the clang one.

[Bug libgomp/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iverbin at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Perhaps we should just disable all offloading for Darwin, at least unless some
Darwin maintainer steps up and adds the needed support for that.

[Bug libgomp/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Perhaps we should just disable all offloading for Darwin, at least unless
> some Darwin maintainer steps up and adds the needed support for that.

Well, this won't solve the failures on linux!

[Bug libgomp/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[iverbin at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

Ilya Verbin <iverbin at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iverbin at gmail dot com

--- Comment #3 from Ilya Verbin <iverbin at gmail dot com> ---
(In reply to Dominique d'Humieres from comment #2)
> > Perhaps we should just disable all offloading for Darwin, at least unless
> > some Darwin maintainer steps up and adds the needed support for that.
> 
> Well, this won't solve the failures on linux!

Failures on linux ( https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00309.html
) are caused by another issue (not by errors during assembling), I'm
investigating them.
I agree to disable generation of offload IR sections temporary for darwin.

[Bug libgomp/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Ilya Verbin from comment #4)
> It seems that support of offload sections in Mach-O will require substantial
> changes to gcc/config/darwin.c, like it was done for LTO.
> 
> I'm going to disable the generation of any offload sections when a compiler
> is configured without --enable-offload-targets, i.e. when ENABLE_OFFLOADING
> is not defined. Is this change ok?

Yes.

[Bug regression/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[iverbin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

iverbin at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-11-17
          Component|libgomp                     |regression
           Assignee|unassigned at gcc dot gnu.org      |iverbin at gcc dot gnu.org
   Target Milestone|---                         |5.0
     Ever confirmed|0                           |1

[Bug regression/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[iverbin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

--- Comment #6 from iverbin at gcc dot gnu.org ---
Author: iverbin
Date: Wed Nov 19 13:52:12 2014
New Revision: 217773

URL: https://gcc.gnu.org/viewcvs?rev=217773&root=gcc&view=rev
Log:
    PR regression/63868
    * cgraph.c (cgraph_node::create): Guard g->have_offload with
    ifdef ENABLE_OFFLOADING.
    * omp-low.c (create_omp_child_function): Likewise.
    (expand_omp_target): Guard node->mark_force_output and offload_funcs
    with ifdef ENABLE_OFFLOADING.
    * varpool.c (varpool_node::get_create): Guard g->have_offload and
    offload_vars with ifdef ENABLE_OFFLOADING.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraph.c
    trunk/gcc/omp-low.c
    trunk/gcc/varpool.c

[Bug regression/63868] [5 Regression] Multiple failures in the libgomp test suite between r217458 and r217501.

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63868

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
r217773 seems to have fixed this PR for darwin as well as for linux (see
https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00551.html). Closing as FIXED.