public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/63888] [5 Regression] bootstrap failed when configured with -with-build-config=bootstrap-asan --disable-werror
Date: Thu, 20 Nov 2014 10:22:00 -0000	[thread overview]
Message-ID: <bug-63888-4-1OWoz2hx9r@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63888-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Kostya Serebryany from comment #6)
> (In reply to Yury Gribov from comment #5)
> > Perhaps ODR check should check that names of global variables match before
> > issuing warning?
> 
> The variables are generated by the compiler, right? 
> (These are switch tables)
> 
> Do we want to instrument them at all? 

Generally, we do want to instrument even artificial variables, and on many of
them buffer overflow is possible.

> I.e. is a buffer overflow on these variables possible? 
> 
> If we don't instrument them we won't report an ODR violation. 
> 
> >> GCC with -fmerge-all-constants also merges many read-only constants, even addressable ones, when they have the same content.
> 
> Then I guess we may have other false positives. 
> We may want to disable -fmerge-all-constants under asan

You haven't responded about the language thing, there is no such thing as ODR
in C or Fortran, so you shouldn't report it.
There are 31 (or 63) bits left in __has_dynamic_init field, can't one bit be
used for whether ODR should be reported or not?


  parent reply	other threads:[~2014-11-20 10:22 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 14:25 [Bug bootstrap/63888] New: " hjl.tools at gmail dot com
2014-11-17  9:33 ` [Bug bootstrap/63888] " rguenth at gcc dot gnu.org
2014-11-17 22:13 ` hjl at gcc dot gnu.org
2014-11-17 22:14 ` hjl.tools at gmail dot com
2014-11-18 13:56 ` jakub at gcc dot gnu.org
2014-11-19 14:53 ` y.gribov at samsung dot com
2014-11-19 19:21 ` kcc at gcc dot gnu.org
2014-11-20 10:22 ` jakub at gcc dot gnu.org [this message]
2014-12-05  8:10 ` jakub at gcc dot gnu.org
2014-12-05 10:08 ` y.gribov at samsung dot com
2014-12-06  1:37 ` kcc at gcc dot gnu.org
2014-12-08  9:02 ` y.gribov at samsung dot com
2014-12-12 22:10 ` kcc at gcc dot gnu.org
2014-12-12 22:25 ` jakub at gcc dot gnu.org
2014-12-12 22:34 ` kcc at gcc dot gnu.org
2014-12-12 22:50 ` jakub at gcc dot gnu.org
2014-12-12 23:00 ` kcc at gcc dot gnu.org
2014-12-12 23:26 ` jakub at gcc dot gnu.org
2014-12-12 23:41 ` kcc at gcc dot gnu.org
2014-12-13  0:10 ` jakub at gcc dot gnu.org
2014-12-13  1:25 ` kcc at gcc dot gnu.org
2015-02-03 21:40 ` echristo at gmail dot com
2015-02-03 21:50 ` echristo at gmail dot com
2015-02-03 22:00 ` pinskia at gcc dot gnu.org
2015-02-03 22:03 ` echristo at gmail dot com
2015-02-03 22:22 ` jakub at gcc dot gnu.org
2015-02-03 22:30 ` echristo at gmail dot com
2015-02-04 13:06 ` jakub at gcc dot gnu.org
2015-02-04 18:09 ` echristo at gmail dot com
2015-02-20 10:44 ` jakub at gcc dot gnu.org
2015-02-20 11:04 ` y.gribov at samsung dot com
2015-02-20 11:09 ` jakub at gcc dot gnu.org
2015-02-20 16:41 ` kcc at gcc dot gnu.org
2015-02-20 17:40 ` y.gribov at samsung dot com
2015-02-23 22:15 ` jakub at gcc dot gnu.org
2015-02-23 22:46 ` jakub at gcc dot gnu.org
2015-02-24 11:28 ` y.gribov at samsung dot com
2015-10-21  7:48 ` chefmax at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63888-4-1OWoz2hx9r@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).