public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63890] [4.9/5 regression] Compiling trivial program with -O -p leads to misaligned stack
Date: Mon, 02 Mar 2015 00:29:00 -0000 [thread overview]
Message-ID: <bug-63890-4-4fpxauO2Lf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63890-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63890
--- Comment #18 from Jan Hubicka <hubicka at ucw dot cz> ---
> I'm happy to defer the question to the person that reviews the patch for the
> tree. I'd like a codegen type person that understands the proposed change to
> review it. They may feel perfectly comfortable approving it for the tree now.
Well, I think the patch is in area I can review (though I would welcome second
opinion as I am nothappy about solution at all).
The way the call is output is broken by design. final.c is outputting
optimized function body and after seeing NOTE_INSN_PROLOGUE_END it calls a hook
that output assembler blob in there. This made sense in early 90's but not much
today when prologues are optimized into rest of the code. We make no promises
about stack alignment at the place NOTE_INSN_PROLOGUE_END is inserted.
So either someone needs to step forward and implement profile_before_prologue
version or we can go with a hack. I do not have darwin setup to test either.
My understanding is that currently profiling is completely broken (segfaults
on empty propgram). If the patch helps profiling to be resonably working,
and lacking better altenatives I would go for it.
next prev parent reply other threads:[~2015-03-02 0:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 15:19 [Bug target/63890] New: [4.9/5.0 " fxcoudert at gcc dot gnu.org
2014-11-15 15:20 ` [Bug target/63890] " fxcoudert at gcc dot gnu.org
2014-11-15 15:45 ` fxcoudert at gcc dot gnu.org
2014-11-15 16:01 ` iains at gcc dot gnu.org
2014-11-15 16:24 ` dominiq at lps dot ens.fr
2014-11-15 16:42 ` dominiq at lps dot ens.fr
2014-11-15 16:46 ` iains at gcc dot gnu.org
2014-11-15 18:11 ` iains at gcc dot gnu.org
2014-11-17 9:32 ` rguenth at gcc dot gnu.org
2014-11-24 16:58 ` rguenth at gcc dot gnu.org
2015-02-24 22:41 ` [Bug target/63890] [4.9/5 " mrs at gcc dot gnu.org
2015-02-25 2:16 ` mrs at gcc dot gnu.org
2015-02-25 4:24 ` mrs at gcc dot gnu.org
2015-02-25 6:46 ` hubicka at ucw dot cz
[not found] ` <bug-63890-4-n8faGCUNTz@http.gcc.gnu.org/bugzilla/>
2015-02-27 8:29 ` Jan Hubicka
2015-02-27 8:38 ` hubicka at ucw dot cz
2015-03-01 20:42 ` howarth at bromo dot med.uc.edu
2015-03-01 22:02 ` hubicka at gcc dot gnu.org
2015-03-01 23:19 ` mrs at gcc dot gnu.org
2015-03-01 23:26 ` hubicka at ucw dot cz
2015-03-01 23:49 ` mrs at gcc dot gnu.org
2015-03-02 0:29 ` hubicka at ucw dot cz [this message]
2015-03-30 13:17 ` iains at gcc dot gnu.org
2015-04-02 9:15 ` dominiq at lps dot ens.fr
2015-06-26 20:07 ` [Bug target/63890] [4.9/5/6 " jakub at gcc dot gnu.org
2015-06-26 20:36 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-63890-4-4fpxauO2Lf@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).