From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-478130-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10240 invoked by alias); 22 Feb 2015 23:16:13 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 10201 invoked by uid 48); 22 Feb 2015 23:16:09 -0000
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63892] [5 Regression] gcc.dg/sibcall-3.c fails on darwin with -m32
Date: Sun, 22 Feb 2015 23:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: marxin at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63892-4-EFJkJOUSJP@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63892-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63892-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg02462.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892

--- Comment #22 from Iain Sandoe <iains at gcc dot gnu.org> ---
yeah, it's not right yet.. looking at this:
diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index e1af8bf..3b5553e 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -658,13 +658,16 @@ sem_function::merge (sem_item *alias_item)
       create_thunk = !stdarg_p (TREE_TYPE (alias->decl));
       create_alias = false;
       /* When both alias and original are not overwritable, we can save
-         the extra thunk wrapper for direct calls.  */
+         the extra thunk wrapper for direct calls (providing that there
+         are no other referring entries).  */
       redirect_callers
        = (!original_discardable
           && !DECL_COMDAT_GROUP (alias->decl)
           && alias->get_availability () > AVAIL_INTERPOSABLE
           && original->get_availability () > AVAIL_INTERPOSABLE
-          && !alias->instrumented_version);
+          && !alias->instrumented_version
+          && alias->ref_list.referring.is_empty()
+         );
     }
   else
     {