public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63892] [5 Regression] gcc.dg/sibcall-3.c fails on darwin with -m32
Date: Sun, 22 Feb 2015 13:10:00 -0000	[thread overview]
Message-ID: <bug-63892-4-zXwKvFhcaR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63892-4@http.gcc.gnu.org/bugzilla/>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 5001 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892

--- Comment #18 from Iain Sandoe <iains at gcc dot gnu.org> ---

so - next increment - simplification of the previous. 
(don't try to redirect callers if we don't have any) 

diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index e1af8bf..ca19967 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -660,7 +660,8 @@ sem_function::merge (sem_item *alias_item)
       /* When both alias and original are not overwritable, we can save
          the extra thunk wrapper for direct calls.  */
       redirect_callers
-       = (!original_discardable
+       = (alias->callers
+          && !original_discardable
           && !DECL_COMDAT_GROUP (alias->decl)
           && alias->get_availability () > AVAIL_INTERPOSABLE
           && original->get_availability () > AVAIL_INTERPOSABLE


Unfortunately, we're still not there.
I think that we can have a situation where we remove an alias which happens to
be the version that the vtable is pointing to (and so end up with an
unsatisfied reference from the vtable and link time).  

However, I still haven't figured out how to redirect those references…
>From gcc-bugs-return-478091-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Feb 22 13:04:44 2015
Return-Path: <gcc-bugs-return-478091-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30159 invoked by alias); 22 Feb 2015 13:04:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 29981 invoked by uid 48); 22 Feb 2015 13:04:41 -0000
From: "zsojka at seznam dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/65161] ICE: in vec<_haifa_insn_data, va_heap, vl_embed>::operator[], at vec.h:736 with -O3 -fselective-scheduling2 -mtune=slm
Date: Sun, 22 Feb 2015 13:11:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: zsojka at seznam dot cz
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-65161-4-uCSyeg3l04@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65161-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65161-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg02423.txt.bz2
Content-length: 1917

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide161

--- Comment #1 from Zdenek Sojka <zsojka at seznam dot cz> ---
Created attachment 34834
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id4834&actioníit
testcase that doesn't need --param on cmd line

Compiler output:
$ gcc -O3 -fselective-scheduling2 -mtune=slm testcase.c
testcase.c: In function 'foo':
testcase.c:11:1: internal compiler error: in operator[], at vec.h:736
 }
 ^
0x5abcde vec<_haifa_insn_data, va_heap, vl_embed>::operator[](unsigned int)
        /mnt/svn/gcc-trunk/gcc/vec.h:736
0xf304c6 vec<_haifa_insn_data, va_heap, vl_embed>::operator[](unsigned int)
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.c:26672
0xf304c6 vec<_haifa_insn_data, va_heap, vl_ptr>::operator[](unsigned int)
        /mnt/svn/gcc-trunk/gcc/vec.h:1202
0xf304c6 swap_top_of_ready_list
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.c:26661
0xf304c6 ix86_sched_reorder
        /mnt/svn/gcc-trunk/gcc/config/i386/i386.c:26740
0xc0e83d invoke_reorder_hooks
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:4129
0xc0e83d find_best_expr
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:4406
0xc0e83d fill_insns
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:5568
0xc0f73a schedule_on_fences
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:7393
0xc0f73a sel_sched_region_2
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:7531
0xc11025 sel_sched_region_1
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:7573
0xc11025 sel_sched_region(int)
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:7674
0xc12021 run_selective_scheduling()
        /mnt/svn/gcc-trunk/gcc/sel-sched.c:7750
0xbea6e5 rest_of_handle_sched2
        /mnt/svn/gcc-trunk/gcc/sched-rgn.c:3647
0xbea6e5 execute
        /mnt/svn/gcc-trunk/gcc/sched-rgn.c:3791
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.


  parent reply	other threads:[~2015-02-22 13:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 16:21 [Bug target/63892] New: [5.0 regression] " fxcoudert at gcc dot gnu.org
2014-11-15 16:22 ` [Bug target/63892] " fxcoudert at gcc dot gnu.org
2014-11-15 16:27 ` dominiq at lps dot ens.fr
2014-11-17  9:32 ` rguenth at gcc dot gnu.org
2014-12-10 15:28 ` rguenth at gcc dot gnu.org
2015-02-18 19:49 ` [Bug target/63892] [5 Regression] " law at redhat dot com
2015-02-20  9:32 ` jakub at gcc dot gnu.org
2015-02-20 10:41 ` jakub at gcc dot gnu.org
2015-02-20 12:00 ` marxin at gcc dot gnu.org
2015-02-20 13:04 ` jakub at gcc dot gnu.org
2015-02-20 16:50 ` jakub at gcc dot gnu.org
2015-02-20 16:51 ` jakub at gcc dot gnu.org
2015-02-21 12:51 ` dominiq at lps dot ens.fr
2015-02-21 13:29 ` iains at gcc dot gnu.org
2015-02-21 13:29 ` iains at gcc dot gnu.org
2015-02-21 14:47 ` iains at gcc dot gnu.org
2015-02-21 18:03 ` iains at gcc dot gnu.org
2015-02-22  4:59 ` iains at gcc dot gnu.org
2015-02-22 13:10 ` iains at gcc dot gnu.org [this message]
2015-02-22 16:55 ` iains at gcc dot gnu.org
2015-02-22 22:27 ` howarth at bromo dot med.uc.edu
2015-02-22 23:57 ` iains at gcc dot gnu.org
2015-02-23  8:45 ` iains at gcc dot gnu.org
2015-02-23 11:15 ` jakub at gcc dot gnu.org
2015-02-23 11:15 ` jakub at gcc dot gnu.org
2015-02-27  7:44 ` mrs at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63892-4-zXwKvFhcaR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).