public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63906] [5 Regression] dse after reload miscompiles glibc with lra_remat turned on aarch64
Date: Mon, 17 Nov 2014 04:46:00 -0000	[thread overview]
Message-ID: <bug-63906-4-yNxPIBRmol@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63906-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63906

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[5 Regression] lra_remat    |[5 Regression] dse after
                   |mis-compiles glibc on       |reload miscompiles glibc
                   |aarch64                     |with lra_remat turned on
                   |                            |aarch64

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It looks like dse is removing more stores when lra_remat is enable:

(insn 538 537 2663 41 (set (mem/f:DI (plus:DI (reg/f:DI 1 x1 [581])
                (const_int 16 [0x10])) [1 runp_409->next+0 S8 A128])
        (const_int 0 [0])) dl-deps.c:283 42 {*movdi_aarch64}
     (nil))


That is for:
            newp->next = NULL;
            tail->next = newp;

DSE (after reload) thinks tail->next is the same as the store to newp->next
with LRA_REMAT turned on.
**scanning insn=538
  mem: (plus:DI (reg/f:DI 1 x1 [581])
    (const_int 16 [0x10]))

   after canon_rtx address: (plus:DI (reg/f:DI 1 x1 [581])
    (const_int 16 [0x10]))

   after cselib_expand address: (plus:DI (reg/f:DI 31 sp)
    (const_int 16 [0x10]))
....
**scanning insn=539
  mem: (plus:DI (reg/v/f:DI 2 x2 [orig:88 runp ] [88])
    (const_int 16 [0x10]))

   after canon_rtx address: (plus:DI (reg/v/f:DI 2 x2 [orig:88 runp ] [88])
    (const_int 16 [0x10]))

   after cselib_expand address: (plus:DI (reg/f:DI 31 sp)
    (const_int 16 [0x10]))

   after canon_rtx address: (plus:DI (reg/f:DI 31 sp)
    (const_int 16 [0x10]))
  varying cselib base=2:4287 offset = 16
 processing cselib store [16..24)
**scanning insn=539
  mem: (plus:DI (reg/v/f:DI 2 x2 [orig:88 runp ] [88])
    (const_int 16 [0x10]))

   after canon_rtx address: (plus:DI (reg/v/f:DI 2 x2 [orig:88 runp ] [88])
    (const_int 16 [0x10]))

   after cselib_expand address: (plus:DI (reg/f:DI 31 sp)
    (const_int 16 [0x10]))

   after canon_rtx address: (plus:DI (reg/f:DI 31 sp)
    (const_int 16 [0x10]))
  varying cselib base=2:4287 offset = 16
 processing cselib store [16..24)


  parent reply	other threads:[~2014-11-17  4:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17  3:22 [Bug rtl-optimization/63906] New: [5 Regression] lra_remat mis-compiles glibc " pinskia at gcc dot gnu.org
2014-11-17  3:22 ` [Bug rtl-optimization/63906] " pinskia at gcc dot gnu.org
2014-11-17  3:53 ` pinskia at gcc dot gnu.org
2014-11-17  3:54 ` pinskia at gcc dot gnu.org
2014-11-17  4:46 ` pinskia at gcc dot gnu.org [this message]
2014-11-17  4:47 ` [Bug rtl-optimization/63906] [5 Regression] dse after reload miscompiles glibc with lra_remat turned " pinskia at gcc dot gnu.org
2014-11-17  5:01 ` [Bug rtl-optimization/63906] [5 Regression] lra_remat miscompiles glibc " pinskia at gcc dot gnu.org
2014-11-17  9:19 ` rguenth at gcc dot gnu.org
2014-11-17 20:30 ` vmakarov at gcc dot gnu.org
2014-11-18  0:15 ` vmakarov at gcc dot gnu.org
2014-11-18  3:23 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63906-4-yNxPIBRmol@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).