[Bug sanitizer/63958] New: [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[Bug sanitizer/63958] New: [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

            Bug ID: 63958
           Summary: [5 Regression] bootstrap failure in the sanitizer libs
                    on sparc-linux-gnu
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

seen with r217751 on the trunk

libtool: compile:  /«PKGBUILDDIR»/build/./gcc/xgcc
-B/«PKGBUILDDIR»/build/./gcc/ -B/usr/lib/gcc-snapshot/sparc-linux-gnu/bin/
-B/usr/lib/gcc-snapshot/sparc-linux-gnu/lib/ -isystem
/usr/lib/gcc-snapshot/sparc-linux-gnu/include -isystem
/usr/lib/gcc-snapshot/sparc-linux-gnu/sys-include -DHAVE_CONFIG_H
-I../../../../src/libatomic/config/posix -I../../../../src/libatomic -I. -Wall
-Werror -pthread -g -O2 -m64 -MT init.lo -MD -MP -MF .deps/init.Tpo -c
../../../../src/libatomic/init.c -o init.o >/dev/null 2>&1
/«PKGBUILDDIR»/build/./gcc/xgcc -B/«PKGBUILDDIR»/build/./gcc/
-B/usr/lib/gcc-snapshot/sparc-linux-gnu/bin/
-B/usr/lib/gcc-snapshot/sparc-linux-gnu/lib/ -isystem
/usr/lib/gcc-snapshot/sparc-linux-gnu/include -isystem
/usr/lib/gcc-snapshot/sparc-linux-gnu/sys-include    -c -g -O2  -fPIC  -W -Wall
-gnatpg -nostdinc   a-wwboio.adb -o a-wwboio.o
In file included from
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:40:0:
/usr/include/sparc-linux-gnu/asm/stat.h:60:2: error: 'time_t' does not name a
type
  time_t  st_atime;
  ^
/usr/include/sparc-linux-gnu/asm/stat.h:62:2: error: 'time_t' does not name a
type
  time_t  st_mtime;
  ^
/usr/include/sparc-linux-gnu/asm/stat.h:64:2: error: 'time_t' does not name a
type
  time_t  st_ctime;
  ^
yes
In file included from
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:20:0:
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:64:78:
error: invalid application of 'sizeof' to incomplete type '__old_kernel_stat'
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
                                                                              ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:272:65:
note: in definition of macro 'IMPL_COMPILER_ASSERT'
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:64:1:
note: in expansion of macro 'COMPILER_CHECK'
 COMPILER_CHECK(struct___old_kernel_stat_sz == sizeof(struct
__old_kernel_stat));
 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:67:16:
error: 'struct_kernel_stat_sz' was not declared in this scope
 COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
                ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:272:65:
note: in definition of macro 'IMPL_COMPILER_ASSERT'
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                 ^
../../../../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:67:1:
note: in expansion of macro 'COMPILER_CHECK'
 COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct stat));
 ^
checking for getrlimit... Makefile:447: recipe for target
'sanitizer_platform_limits_linux.lo' failed
make[6]: *** [sanitizer_platform_limits_linux.lo] Error 1
make[6]: *** Waiting for unfinished jobs....
>From gcc-bugs-return-467385-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Nov 19 11:57:54 2014
Return-Path: <gcc-bugs-return-467385-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 4205 invoked by alias); 19 Nov 2014 11:57:54 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 4177 invoked by uid 48); 19 Nov 2014 11:57:50 -0000
From: "lh_mouse at 126 dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/63959] New: G++ misreports volatile int as trivially copyable
Date: Wed, 19 Nov 2014 11:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: lh_mouse at 126 dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-63959-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg01857.txt.bz2
Content-length: 899

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc959

            Bug ID: 63959
           Summary: G++ misreports volatile int as trivially copyable
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lh_mouse at 126 dot com

The type trait std::is_trivially_copyable<volatile int>::value yields true on
g++ (GCC) 5.0.0 20141119 (experimental).

ISO C++ states that volatile types are NOT trivially copyable:

N3936 3.9 Types [basic.types]
9 Arithmetic types (3.9.1), ... Cv-unqualified scalar types, trivially copyable
class types (Clause 9), arrays of such types,
** and nonvolatile const-qualified versions of these types (3.9.3) **
are collectively called trivially copyable types. ...

So this is a bug. Please fix.

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |5.0
   Target Milestone|---                         |5.0

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[kcc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #1 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
Please send patches upstream:
https://code.google.com/p/address-sanitizer/wiki/HowToContribute

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[kcc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #3 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
I am very sorry that you are so upset, but the workflow will not change. 
All changes to sanitizer files (except for GCC-specific tests and make files)
have to go to upstream first. 
If any change goes directly to GCC it will get overwritten by a following merge
from upstream. 
(merge is the wrong name for process actually. The right name would be "copy").

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[davem at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #4 from davem at gcc dot gnu.org ---
You cannot have it both ways.

If you demand people go through upstream, you have to be responsive to fixing
build failures yourselves.  Because it is the sanitizer developers who
introduced this build failure that stood for 9 months in a release of gcc.

This current situation is completely unacceptable, and if you are going to get
into a commit war with me when I am simply trying to fix the build which you
both broke and refused to fix for 9+ months, that's extremely anti-social and
demonstrates how the current situation is not working and is bad for gcc
development overall.

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[kcc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #6 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
I am not at war with anyone and if I am, I give up and surrender.

But whoever wants the sanitizers to work on SPARC [s]he will have to work with
us upstream. We can not fix build failures on SPARC upstream because we don't
have access to SPARC machines and there is no public buildbot with SPARC. 
If no one needs sanitizers on SPARC and all you care about is that GCC builds
on SPARC, just disable the sanitizers for SPARC. 

This is my last response here. 
For constructive discussion please start sending patches upstream.

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2014-12-10
     Ever confirmed|0                           |1

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Does it work again?

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doko at gcc dot gnu.org

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Matthias, do you still build Debian and/or Ubuntu for SPARC and could you check
this?

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #10 from Matthias Klose <doko at gcc dot gnu.org> ---
yes, still applies, and the build passed the libsanitizer directory.

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Mon Mar  9 18:25:28 2015
New Revision: 221283

URL: https://gcc.gnu.org/viewcvs?rev=221283&root=gcc&view=rev
Log:
    PR sanitizer/63958
    Reapply:
    2014-10-14  David S. Miller  <davem@davemloft.net>

    * sanitizer_common/sanitizer_platform_limits_linux.cc (time_t):
    Define at __kernel_time_t, as needed for sparc.
    (struct __old_kernel_stat): Don't check if __sparc__ is defined.
    * libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
    (__sanitizer): Define struct___old_kernel_stat_sz,
    struct_kernel_stat_sz, and struct_kernel_stat64_sz for sparc.
    (__sanitizer_ipc_perm): Adjust for sparc targets.
    (__sanitizer_shmid_ds): Likewsie.
    (__sanitizer_sigaction): Likewise.
    (IOC_SIZE): Likewsie.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for GCC 5 now, but the problem will likely reappear during next merge :(.

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
.

[Bug sanitizer/63958] [5 Regression] bootstrap failure in the sanitizer libs on sparc-linux-gnu

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63958

--- Comment #14 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Author: chefmax
Date: Wed Oct 21 07:44:35 2015
New Revision: 229113

URL: https://gcc.gnu.org/viewcvs?rev=229113&root=gcc&view=rev
Log:
libsanitizer/

        PR sanitizer/63958
        Reapply:
        2014-10-14  David S. Miller  <davem@davemloft.net>

        * sanitizer_common/sanitizer_platform_limits_linux.cc (time_t):
        Define at __kernel_time_t, as needed for sparc.
        (struct __old_kernel_stat): Don't check if __sparc__ is defined.
        * libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
        (__sanitizer): Define struct___old_kernel_stat_sz,
        struct_kernel_stat_sz, and struct_kernel_stat64_sz for sparc.
        (__sanitizer_ipc_perm): Adjust for sparc targets.
        (__sanitizer_shmid_ds): Likewsie.
        (__sanitizer_sigaction): Likewise.
        (IOC_SIZE): Likewsie.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h