public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug lto/63968] [5 Regression] 175.vpr from cpu2000 fails to build with LTO Date: Thu, 20 Nov 2014 22:43:00 -0000 [thread overview] Message-ID: <bug-63968-4-Il4QCUabqU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-63968-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63968 Jan Hubicka <hubicka at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hubicka at gcc dot gnu.org --- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> --- /* If we wanted to, we could actually do a real increase by redeleting and inserting. However, this would require O (log n) time. So just bail out for now. */ if (fibheap_comp_data (heap, key, data, node) > 0) return NULL; It is clearly bug in the old implementation. Increase is quite easy to handle: you just remember the increased value and if your find_min returns one where value has increased, just re-insert it and get another minimum. This requires to store two keys, that is probably not good for generic template. Perhaps bb-reorder can just see if it is increasing and perform delete+insert. Its loop is not perofrmance critical (inliner did so and it was too slow in that case)
next prev parent reply other threads:[~2014-11-20 22:43 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-19 16:04 [Bug lto/63968] New: " hjl.tools at gmail dot com 2014-11-19 18:34 ` [Bug lto/63968] " hjl.tools at gmail dot com 2014-11-20 10:30 ` marxin at gcc dot gnu.org 2014-11-20 10:31 ` marxin at gcc dot gnu.org 2014-11-20 22:43 ` hubicka at gcc dot gnu.org [this message] 2014-11-21 10:54 ` mliska at suse dot cz 2014-11-24 10:25 ` marxin at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-63968-4-Il4QCUabqU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).