[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

dmalcolm at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-20
     Ever confirmed|0                           |1

--- Comment #1 from dmalcolm at gcc dot gnu.org ---
Confirmed: this is trivial to reproduce by running:
  make check-jit 
to build the test programs, or just one like so:
  make check-jit RUNTESTFLAGS="-v -v -v jit.exp=tut01-hello-world.c"
then running:
  ./testsuite/jit/tut01-hello-world.exe
outside of the jit.exp harness (thus not setting up the envvars).

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

dmalcolm at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from dmalcolm at gcc dot gnu.org ---
Segfault occurs if driver is not found on PATH *and* the context's
GCC_JIT_STR_OPTION_PROGNAME is NULL.

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

--- Comment #3 from dmalcolm at gcc dot gnu.org ---
(In reply to dmalcolm from comment #2)
> Segfault occurs if driver is not found on PATH *and* the context's
> GCC_JIT_STR_OPTION_PROGNAME is NULL.

...and hence only the tutorials run into this; the rest of the testsuite uses
harness.h, which sets that option to non-NULL.

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

--- Comment #4 from dmalcolm at gcc dot gnu.org ---
Patch posted for review as
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02617.html

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

--- Comment #5 from dmalcolm at gcc dot gnu.org ---
Note: with the fix, the testcase (with an unset PATH) emits these error
messages for me:

libgccjit.so: error trying to exec 'x86_64-unknown-linux-gnu-gcc-5.0.0':
execvp: No such file or directory
libgccjit.so: error: error invoking gcc driver: exit_status: 65280 err: 0
libgccjit.so: error: whilst attempting to run a driver named:
x86_64-unknown-linux-gnu-gcc-5.0.0
libgccjit.so: error: PATH was: (null)

which hopefully should make it clearer that it's a PATH issue.

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

--- Comment #6 from dmalcolm at gcc dot gnu.org ---
(In reply to dmalcolm from comment #4)
> Patch posted for review as
> https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02617.html

TMM confirmed on IRC that the proposed patch fixes the issue for them.

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

--- Comment #7 from dmalcolm at gcc dot gnu.org ---
Author: dmalcolm
Date: Mon Dec  1 15:58:11 2014
New Revision: 218226

URL: https://gcc.gnu.org/viewcvs?rev=218226&root=gcc&view=rev
Log:
PR jit/63969: Fix segfault in error-handling when driver isn't found

gcc/jit/ChangeLog:
    PR jit/63969
    * jit-playback.c: Ensure that ctxt_progname is non-NULL.

gcc/testsuite/ChangeLog:
    PR jit/63969
    * jit.dg/harness.h (CHECK_STRING_STARTS_WITH): New.
    (check_string_starts_with): New.
    * jit.dg/test-error-pr63969-missing-driver.c: New.

Added:
    trunk/gcc/testsuite/jit.dg/test-error-pr63969-missing-driver.c
Modified:
    trunk/gcc/jit/ChangeLog
    trunk/gcc/jit/jit-playback.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/jit.dg/harness.h

[Bug jit/63969] gccjit segfaults when it can't locate the correct gcc driver program

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63969

dmalcolm at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from dmalcolm at gcc dot gnu.org ---
Should be fixed as of r218226.