[Bug bootstrap/63995] New: Bootstrap error with -mmpx -fcheck-pointer-bounds

[Bug bootstrap/63995] New: Bootstrap error with -mmpx -fcheck-pointer-bounds

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

            Bug ID: 63995
           Summary: Bootstrap error with -mmpx -fcheck-pointer-bounds
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
                CC: enkovich.gnu at gmail dot com
            Target: x86_64-*-*

/tmp/cceHGHa1.s: Assembler messages:
/tmp/cceHGHa1.s:12080: Error: symbol `__chkp_bounds_of_mode_inner' is already
defined
/tmp/cceHGHa1.s:12086: Error: symbol `__chkp_bounds_of_mode_nunits' is already
defined
make[3]: *** [insn-preds.o] Error 1

and similar fails for compiling alias.o during stage2

Did you ever try bootstrapping instrumtented GCC?  I tried

BOOT_CFLAGS="-O2 -g -fcheck-pointer-bounds -mmpx"

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #1 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
Created attachment 34052
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34052&action=edit
reproducer

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #2 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
I had a successful bootstrap with instrumentation some time ago but it's not
performed regularly.

We are extending regression testing for instrumentation now and coverage should
become better.

This particular problem may be caused by multiple varpool_node for the same
var.  Will check it.

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #4 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 25 Nov 2014, enkovich.gnu at gmail dot com wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995
> 
> --- Comment #3 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
> Patch removing duplicating bounds symbols is in review.  With this patch
> applied bootstrap goes till the end but there are lots of stage2 and stage3
> comparison error.  I looked into one of them and the difference is caused by
> '-gtoggle' option used for stage2 build and not used for stage3 build.

This means you are generating different code with -g vs. -g0 which is
forbidden.

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #5 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
Created attachment 34112
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34112&action=edit
-g0 problem reproducer

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #7 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
In chkpopt pass calls to bndmk are moved down to uses to decrease register
pressure.  Debug info introduces new uses and therefore it affects a position
where bndmk calls appear.

-g0 case:

  <bb 4>:                                         
  r.field = -1;                                   
  __bound_tmp.1_13 = __builtin_ia32_bndmk (&r, 4);
  test2.chkp (&r, __bound_tmp.1_13);              

-g case:

  <bb 4>:
  # DEBUG c => &r
  __bound_tmp.1_13 = __builtin_ia32_bndmk (&r, 4);
  # DEBUG __chkp_bounds_of_c => NULL
  r.field = -1;
  test2.chkp (&r, __bound_tmp.1_13);

Will ignore debug statements when computing a new position for bounds
load/creation (BTW debug statement seems to be damaged by gsi_move_before
called for bndmk).  Testing following fix:

diff --git a/gcc/tree-chkp-opt.c b/gcc/tree-chkp-opt.c
index ff390d7..b8d5d0b 100644
--- a/gcc/tree-chkp-opt.c
+++ b/gcc/tree-chkp-opt.c
@@ -1175,7 +1175,9 @@ chkp_reduce_bounds_lifetime (void)

       FOR_EACH_IMM_USE_STMT (use_stmt, use_iter, op)
        {
-         if (dom_bb &&
+         if (is_gimple_debug (use_stmt))
+           continue;
+         else if (dom_bb &&
              dominated_by_p (CDI_DOMINATORS,
                              dom_bb, gimple_bb (use_stmt)))
            {

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #8 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
With both patches applied bootstrap is OK

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[ienkovich at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #10 from ienkovich at gcc dot gnu.org ---
Author: ienkovich
Date: Wed Nov 26 14:37:07 2014
New Revision: 218085

URL: https://gcc.gnu.org/viewcvs?rev=218085&root=gcc&view=rev
Log:
gcc/

    PR bootstrap/63995
    * tree-chkp-opt.c (chkp_reduce_bounds_lifetime): Ignore
    debug statement when searching for a new position for
    bounds load/creation statement.

gcc/testsuite/

    PR bootstrap/63995
    * gcc.target/i386/pr63995-2.c: New.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr63995-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-chkp-opt.c

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[ienkovich at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #11 from ienkovich at gcc dot gnu.org ---
Author: ienkovich
Date: Tue Dec  9 07:53:17 2014
New Revision: 218506

URL: https://gcc.gnu.org/viewcvs?rev=218506&root=gcc&view=rev
Log:
gcc/

    PR bootstrap/63995
    * tree-chkp.c (chkp_make_static_bounds): Share bounds var
    between nodes sharing assembler name.

gcc/testsuite/

    PR bootstrap/63995
    * g++.dg/dg.exp: Add mpx-dg.exp.
    * g++.dg/pr63995-1.C: New.


Added:
    trunk/gcc/testsuite/g++.dg/pr63995-1.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/dg.exp
    trunk/gcc/tree-chkp.c

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[enkovich.gnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

--- Comment #12 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
For r218506 bootstrap with BOOT_CFLAGS="-O2 -g -fcheck-pointer-bounds -mmpx" on
x86_64-unknown-linux-gnu is OK.

[Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds

[ienkovich at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63995

Ilya Enkovich <ienkovich at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |ienkovich at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #13 from Ilya Enkovich <ienkovich at gcc dot gnu.org> ---
Fixed