[Bug lto/63998] New: gcc.dg/lto/pr60820 fails on darwin

[Bug lto/63998] New: gcc.dg/lto/pr60820 fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

            Bug ID: 63998
           Summary: gcc.dg/lto/pr60820 fails on darwin
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fxcoudert at gcc dot gnu.org

gcc.dg/lto/pr60820 fails on x86_64-apple-darwin14 because of a warning:

warning: alias definitions not supported in Mach-O; ignored

I don't know if it should just be silenced, as per the patch below (which makes
the testcase pass), or if it indicates a more fundamental issue.


Index: pr60820_0.c
===================================================================
--- pr60820_0.c    (revision 217836)
+++ pr60820_0.c    (working copy)
@@ -1,5 +1,5 @@
 /* { dg-lto-do link } */
-/* { dg-lto-options {{-flto -r -nostdlib -O2}} } */
+/* { dg-lto-options {{-flto -r -nostdlib -O2 -w}} } */
 #include <stdio.h>
 struct in6_addr {int bah;};
 extern const struct in6_addr in6addr_any;

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-apple-darwin14
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-20
               Host|                            |x86_64-apple-darwin14
     Ever confirmed|0                           |1
              Build|                            |x86_64-apple-darwin14

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Maybe the testcase misses { dg-require-weak "" }?  Not sure if that works for
lto.exp though - can you check?

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu.org

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Maybe the testcase misses { dg-require-weak "" }?  Not sure if that works for
> lto.exp though - can you check?

If so, it would probably need

// { dg-additional-options "-Wl,-undefined,dynamic_lookup" { target *-*-darwin*
} }
// { dg-additional-options "-Wl,-flat_namespace" { target *-*-darwin[89]* } }

(see gcc.dg/attr-weakref-1.c).

Untested so far.

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> If so, it would probably need
>
> // { dg-additional-options "-Wl,-undefined,dynamic_lookup" { target *-*-darwin* } }
> // { dg-additional-options "-Wl,-flat_namespace" { target *-*-darwin[89]* } }
>
> (see gcc.dg/attr-weakref-1.c).
>
> Untested so far.

It does not work because lto does not support dg-additional-options.

I confirm that adding -w to dg-lto-options fixes the failures. However I have
noticed that there is a lto_prune_warns in lib/lto.exp. It would probably
better to add
"warning: alias definitions not supported in Mach-O; ignored" to the list.

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

--- Comment #5 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 20 Nov 2014, dominiq at lps dot ens.fr wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998
> 
> --- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > If so, it would probably need
> >
> > // { dg-additional-options "-Wl,-undefined,dynamic_lookup" { target *-*-darwin* } }
> > // { dg-additional-options "-Wl,-flat_namespace" { target *-*-darwin[89]* } }
> >
> > (see gcc.dg/attr-weakref-1.c).
> >
> > Untested so far.
> 
> It does not work because lto does not support dg-additional-options.
> 
> I confirm that adding -w to dg-lto-options fixes the failures. However I have
> noticed that there is a lto_prune_warns in lib/lto.exp. It would probably
> better to add
> "warning: alias definitions not supported in Mach-O; ignored" to the list.

I'd rather skip the test for darwin then.  The test tests sth with
"weak" which results in alias definitions, so if that doesn't work
then what's the point testing it?

Richard.

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

--- Comment #6 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Author: fxcoudert
Date: Fri Nov 21 08:38:41 2014
New Revision: 217907

URL: https://gcc.gnu.org/viewcvs?rev=217907&root=gcc&view=rev
Log:
    PR lto/63998
    * gcc.dg/lto/pr60820_0.c: Skip on darwin.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/lto/pr60820_0.c

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug lto/63998] gcc.dg/lto/pr60820 fails on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63998

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
(In reply to rguenther@suse.de from comment #5)
> I'd rather skip the test for darwin then.  The test tests sth with
> "weak" which results in alias definitions, so if that doesn't work
> then what's the point testing it?

Confirmed fixed, as indicated. Thanks.