public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/64003] valgrind complains about get_attr_length_nobnd in insn-attrtab.c from i386.md Date: Thu, 04 Dec 2014 19:51:00 -0000 [thread overview] Message-ID: <bug-64003-4-K2qfvsYE27@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-64003-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64003 --- Comment #19 from Jeffrey A. Law <law at redhat dot com> --- I was thinking more along the lines of documented in the texi documention for Length attributes. Useful to have in sh.md, but better documented in a location that is more likely to be read. I don't think that inlining ix86_bnd_prefixed_insn_p in the attribute stuff is really wise. Are you suggesting that we can put in a dummy clause similar to the sh or pa ports to resolve this issue? For reference the PA port's hack looks like: (set (attr "length") (cond [(and (const_int 0) (eq (const_int 0) (pc))) (const_int 8)] (symbol_ref "pa_attr_length_call (insn, 0)")))]) The result of this hack is that during shortening these insns are considered as having a fixed length (8 bytes). So we might overestimte their actual size and generate more long branches than necessary. We have the length right by final, so the final version may be shorter than the conservative estimate during shorten-branches.
next prev parent reply other threads:[~2014-12-04 19:51 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-20 18:39 [Bug rtl-optimization/64003] New: " dmalcolm at gcc dot gnu.org 2014-11-20 18:41 ` [Bug rtl-optimization/64003] " dmalcolm at gcc dot gnu.org 2014-11-20 18:54 ` dmalcolm at gcc dot gnu.org 2014-11-20 19:23 ` dmalcolm at gcc dot gnu.org 2014-11-20 19:27 ` dmalcolm at gcc dot gnu.org 2014-11-20 19:41 ` dmalcolm at gcc dot gnu.org 2014-11-21 19:04 ` [Bug target/64003] " dmalcolm at gcc dot gnu.org 2014-12-02 2:20 ` dmalcolm at gcc dot gnu.org 2014-12-02 15:40 ` dmalcolm at gcc dot gnu.org 2014-12-02 15:48 ` dmalcolm at gcc dot gnu.org 2014-12-02 15:54 ` dmalcolm at gcc dot gnu.org 2014-12-02 16:08 ` dmalcolm at gcc dot gnu.org 2014-12-02 16:13 ` dmalcolm at gcc dot gnu.org 2014-12-04 9:24 ` amylaar at gcc dot gnu.org 2014-12-04 18:43 ` law at redhat dot com 2014-12-04 18:44 ` law at redhat dot com 2014-12-04 19:19 ` amylaar at gcc dot gnu.org 2014-12-04 19:38 ` enkovich.gnu at gmail dot com 2014-12-04 19:45 ` amylaar at gcc dot gnu.org 2014-12-04 19:51 ` law at redhat dot com [this message] 2014-12-04 19:54 ` law at redhat dot com 2014-12-05 10:07 ` enkovich.gnu at gmail dot com 2014-12-05 10:08 ` enkovich.gnu at gmail dot com 2014-12-05 10:38 ` ubizjak at gmail dot com 2014-12-05 10:50 ` ubizjak at gmail dot com 2014-12-05 14:19 ` rsandifo at gcc dot gnu.org 2014-12-05 15:01 ` enkovich.gnu at gmail dot com 2014-12-05 16:01 ` ienkovich at gcc dot gnu.org 2015-04-16 14:08 ` ienkovich at gcc dot gnu.org 2015-07-24 8:32 ` ubizjak at gmail dot com 2015-07-24 8:36 ` ubizjak at gmail dot com 2015-07-24 16:26 ` uros at gcc dot gnu.org 2015-07-24 16:31 ` ubizjak at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64003-4-K2qfvsYE27@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).