[Bug sanitizer/64013] New: [5 Regression] libsanitizer fails to build

[Bug sanitizer/64013] New: [5 Regression] libsanitizer fails to build

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

            Bug ID: 64013
           Summary: [5 Regression] libsanitizer fails to build
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

[35101s] I: Program returns random data in a function
[35101s] E: gcc5 no-return-in-nonvoid-function
../../../../libsanitizer/sanitizer_common/sanitizer_linux.cc:295

bool FileExists(const char *filename) {
#if SANITIZER_USES_CANONICAL_LINUX_SYSCALLS
  struct stat st;
  if (internal_syscall(SYSCALL(newfstatat), AT_FDCWD, filename, &st, 0))
    return false;
#else
  struct stat st;
  if (internal_stat(filename, &st))
    return false;
  // Sanity check: filename is a regular file.
  return S_ISREG(st.st_mode);
#endif
}

the SANITIZER_USES_CANONICAL_LINUX_SYSCALLS misses a return.

[Bug sanitizer/64013] [5 Regression] libsanitizer fails to build

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |5.0

[Bug sanitizer/64013] [5 Regression] libsanitizer fails to build

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Note the message is from our package build process scanning for severe warnings
and failing package build because of that.  Thus there is a "no return in
non-void function" warning generated by GCC during the build of libsanitizer,
in the particular case on aarch64-linux.

[Bug sanitizer/64013] [5 Regression] libsanitizer fails to build

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-21
     Ever confirmed|0                           |1

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Kostya/Dmitri, can you please fix this upstream, so that we can cherry-pick it?
The fix is obvious...

[Bug sanitizer/64013] [5 Regression] libsanitizer fails to build

[dvyukov at google dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

Dmitry Vyukov <dvyukov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dvyukov at google dot com

--- Comment #3 from Dmitry Vyukov <dvyukov at google dot com> ---
Fixed upstream:
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc?r1=222532&r2=222531&pathrev=222532

[Bug sanitizer/64013] [5 Regression] libsanitizer fails to build

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Nov 21 14:03:37 2014
New Revision: 217921

URL: https://gcc.gnu.org/viewcvs?rev=217921&root=gcc&view=rev
Log:
    PR sanitizer/64013
    * sanitizer_common/sanitizer_linux.cc (FileExists): Cherry pick
    upstream r222532.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_linux.cc

[Bug sanitizer/64013] [5 Regression] libsanitizer fails to build

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64013

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed, thanks Dmitry.