[Bug target/64045] fortran.dg/pr45636.f90 fails for AArch64 - memcpy and memset are not combined

[Bug target/64045] fortran.dg/pr45636.f90 fails for AArch64 - memcpy and memset are not combined

[kugan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64045

--- Comment #1 from kugan at gcc dot gnu.org ---
Look at gcc/tree-ssa-fwprop.c:1650

      /* If the new memcpy wouldn't be emitted by storing the literal
         by pieces, this optimization might enlarge .rodata too much,
         as commonly used string literals couldn't be shared any
         longer.  */
      if (!can_store_by_pieces (src_len,
                    builtin_strncpy_read_str,
                    src_buf, ptr1_align, false))
        break;

AArch64 back-end rejects use_by_pieces_infrastructure for STORE_BY_PIECES and
hence this optimisation will fail. It is probably an xfail case if back-end is
going to reject it.


static bool
aarch64_use_by_pieces_infrastructure_p (unsigned int size,
                                       unsigned int align,
                                       enum by_pieces_operation op,
                                       bool speed_p)
{
  /* STORE_BY_PIECES can be used when copying a constant string, but
     in that case each 64-bit chunk takes 5 insns instead of 2 (LDR/STR).
     For now we always fail this and let the move_by_pieces code copy
     the string from read-only memory.  */
  if (op == STORE_BY_PIECES)
    return false;

  return default_use_by_pieces_infrastructure_p (size, align, op, speed_p);
}

[Bug target/64045] fortran.dg/pr45636.f90 fails for AArch64 - memcpy and memset are not combined

[mkuvyrkov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64045

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jgreenhalgh at gcc dot gnu.org,
                   |                            |mkuvyrkov at gcc dot gnu.org

--- Comment #2 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
James, should this be XFAILed aarch64-*?

[Bug target/64045] fortran.dg/pr45636.f90 fails for AArch64 - memcpy and memset are not combined

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64045

James Greenhalgh <jgreenhalgh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from James Greenhalgh <jgreenhalgh at gcc dot gnu.org> ---
Yes:

https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=220647

[Bug target/64045] fortran.dg/pr45636.f90 fails for AArch64 - memcpy and memset are not combined

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64045

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ramana at gcc dot gnu.org
   Target Milestone|---                         |5.0

--- Comment #4 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Fixed for 5.0