public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto
@ 2014-11-25  7:23 Joost.VandeVondele at mat dot ethz.ch
  2014-11-25  9:18 ` [Bug middle-end/64065] " rguenth at gcc dot gnu.org
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Joost.VandeVondele at mat dot ethz.ch @ 2014-11-25  7:23 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

            Bug ID: 64065
           Summary: [5 Regression] CP2K miscompilation at -O3 -flto
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Joost.VandeVondele at mat dot ethz.ch

Current trunk miscompiles cp2k at ' -flto=jobserver -fuse-linker-plugin
-fno-prefetch-loop-arrays -O3 -march=native -funroll-loops -ffast-math'

The last known good revision is r217995 and first bad is r218036

lto and -O3 are needed. As this involves lto, I don't think I can reduce the
problem, I might try to identify a precise commit.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
@ 2014-11-25  9:18 ` rguenth at gcc dot gnu.org
  2014-11-25 13:08 ` Joost.VandeVondele at mat dot ethz.ch
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-11-25  9:18 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2014-11-25
   Target Milestone|---                         |5.0
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
That would be nice.  Looking at the changes its either a latent issue uncovered
by inlining changes, my restrict change or my SCCVN change (which might uncover
a frontend bug - it did that for Java already).


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
  2014-11-25  9:18 ` [Bug middle-end/64065] " rguenth at gcc dot gnu.org
@ 2014-11-25 13:08 ` Joost.VandeVondele at mat dot ethz.ch
  2014-11-25 13:23 ` rguenther at suse dot de
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Joost.VandeVondele at mat dot ethz.ch @ 2014-11-25 13:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Joost.VandeVondele at mat dot ethz
                   |                            |.ch

--- Comment #2 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
(In reply to Richard Biener from comment #1)
> That would be nice.  Looking at the changes its either a latent issue
> uncovered by inlining changes, my restrict change or my SCCVN change (which
> might uncover a frontend bug - it did that for Java already).

r218005: Fail
r218004: OK

Which makes it restrict changes, I guess.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
  2014-11-25  9:18 ` [Bug middle-end/64065] " rguenth at gcc dot gnu.org
  2014-11-25 13:08 ` Joost.VandeVondele at mat dot ethz.ch
@ 2014-11-25 13:23 ` rguenther at suse dot de
  2014-11-25 13:28 ` rguenth at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rguenther at suse dot de @ 2014-11-25 13:23 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

--- Comment #3 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 25 Nov 2014, Joost.VandeVondele at mat dot ethz.ch wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065
> 
> Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |Joost.VandeVondele at mat dot ethz
>                    |                            |.ch
> 
> --- Comment #2 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
> (In reply to Richard Biener from comment #1)
> > That would be nice.  Looking at the changes its either a latent issue
> > uncovered by inlining changes, my restrict change or my SCCVN change (which
> > might uncover a frontend bug - it did that for Java already).
> 
> r218005: Fail
> r218004: OK
> 
> Which makes it restrict changes, I guess.

:/

Might make it a bad interaction with the "special" support we have
for the Fortran frontend or a genuine bug.  Not sure without
something more self-contained.  But at least I'll think a bit more
about the LTO side of that change.  Ah!  A bug.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
                   ` (2 preceding siblings ...)
  2014-11-25 13:23 ` rguenther at suse dot de
@ 2014-11-25 13:28 ` rguenth at gcc dot gnu.org
  2014-11-25 15:14 ` Joost.VandeVondele at mat dot ethz.ch
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-11-25 13:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 34111
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34111&action=edit
patch

Can you try this?


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
                   ` (3 preceding siblings ...)
  2014-11-25 13:28 ` rguenth at gcc dot gnu.org
@ 2014-11-25 15:14 ` Joost.VandeVondele at mat dot ethz.ch
  2014-11-25 15:20 ` rguenther at suse dot de
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Joost.VandeVondele at mat dot ethz.ch @ 2014-11-25 15:14 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

--- Comment #5 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
(In reply to Richard Biener from comment #4)
> Created attachment 34111 [details]
> patch
> 
> Can you try this?

Cool, fixed!


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
                   ` (4 preceding siblings ...)
  2014-11-25 15:14 ` Joost.VandeVondele at mat dot ethz.ch
@ 2014-11-25 15:20 ` rguenther at suse dot de
  2014-11-25 15:40 ` Joost.VandeVondele at mat dot ethz.ch
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: rguenther at suse dot de @ 2014-11-25 15:20 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

--- Comment #6 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 25 Nov 2014, Joost.VandeVondele at mat dot ethz.ch wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065
> 
> --- Comment #5 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
> (In reply to Richard Biener from comment #4)
> > Created attachment 34111 [details]
> > patch
> > 
> > Can you try this?
> 
> Cool, fixed!

Great.  Does the restrict stuff make any performance difference?


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
                   ` (5 preceding siblings ...)
  2014-11-25 15:20 ` rguenther at suse dot de
@ 2014-11-25 15:40 ` Joost.VandeVondele at mat dot ethz.ch
  2014-11-25 16:43 ` rguenth at gcc dot gnu.org
  2014-11-25 16:43 ` rguenth at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: Joost.VandeVondele at mat dot ethz.ch @ 2014-11-25 15:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

--- Comment #7 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
(In reply to rguenther@suse.de from comment #6)
> Does the restrict stuff make any performance difference?

Not noticeable for the particular benchmark I'm running overnight.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
                   ` (6 preceding siblings ...)
  2014-11-25 15:40 ` Joost.VandeVondele at mat dot ethz.ch
@ 2014-11-25 16:43 ` rguenth at gcc dot gnu.org
  2014-11-25 16:43 ` rguenth at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-11-25 16:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Bug middle-end/64065] [5 Regression] CP2K miscompilation at -O3 -flto
  2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
                   ` (7 preceding siblings ...)
  2014-11-25 16:43 ` rguenth at gcc dot gnu.org
@ 2014-11-25 16:43 ` rguenth at gcc dot gnu.org
  8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-11-25 16:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64065

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Nov 25 16:43:24 2014
New Revision: 218049

URL: https://gcc.gnu.org/viewcvs?rev=218049&root=gcc&view=rev
Log:
2014-11-25  Richard Biener  <rguenther@suse.de>

    PR lto/64065
    * lto-streamer-out.c (output_struct_function_base): Stream
    last_clique field.
    * lto-streamer-in.c (input_struct_function_base): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lto-streamer-in.c
    trunk/gcc/lto-streamer-out.c


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-11-25 16:43 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-25  7:23 [Bug middle-end/64065] New: [5 Regression] CP2K miscompilation at -O3 -flto Joost.VandeVondele at mat dot ethz.ch
2014-11-25  9:18 ` [Bug middle-end/64065] " rguenth at gcc dot gnu.org
2014-11-25 13:08 ` Joost.VandeVondele at mat dot ethz.ch
2014-11-25 13:23 ` rguenther at suse dot de
2014-11-25 13:28 ` rguenth at gcc dot gnu.org
2014-11-25 15:14 ` Joost.VandeVondele at mat dot ethz.ch
2014-11-25 15:20 ` rguenther at suse dot de
2014-11-25 15:40 ` Joost.VandeVondele at mat dot ethz.ch
2014-11-25 16:43 ` rguenth at gcc dot gnu.org
2014-11-25 16:43 ` rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).