[Bug target/64115] New: [5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[Bug target/64115] New: [5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

            Bug ID: 64115
           Summary: [5 Regression] ICE: : in rs6000_delegitimize_address,
                    at config/rs6000/rs6000.c:7051
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
              Host: powerpc64-unknown-linux-gnu
            Target: powerpc64-unknown-linux-gnu
             Build: powerpc64-unknown-linux-gnu

trippels@gcc2-power8 linux-3.17.2 % cat radio.i
void (*a)();
void b43legacy_synth_pu_workaround ();
int
channel2freq_bg (int p1)
{
  static int b[] = {};
  if (__builtin_expect (p1, 0))
    return b[p1];
  return 0;
}
void
b43legacy_radio_selectchannel (int p1)
{
  int c;
  b43legacy_synth_pu_workaround ();
  c = channel2freq_bg (p1);
  int d = c;
  a (d);
  if (p1)
    b43legacy_synth_pu_workaround ();
}


trippels@gcc2-power8 linux-3.17.2 % gcc -g -O2 -fprofile-arcs -c radio.i
(unspec:DI [
        (symbol_ref:DI ("*.LANCHOR1") [flags 0x182])
        (mem/v/c:DI (plus:DI (reg/f:DI 67 ap)
                (const_int -88 [0xffffffffffffffa8])) [5  S8 A8])
    ] UNSPEC_TOCREL)
radio.i: In function ‘b43legacy_radio_selectchannel’:
radio.i:21:1: internal compiler error: in rs6000_delegitimize_address, at
config/rs6000/rs6000.c:7051
 }
 ^
0x10b2e193 rs6000_delegitimize_address
        ../../gcc/gcc/config/rs6000/rs6000.c:7051
0x103b01f7 mem_loc_descriptor(rtx_def*, machine_mode, machine_mode,
var_init_status)
        ../../gcc/gcc/dwarf2out.c:12402
0x103b11f7 mem_loc_descriptor(rtx_def*, machine_mode, machine_mode,
var_init_status)
        ../../gcc/gcc/dwarf2out.c:12766
0x103baa77 loc_descriptor
        ../../gcc/gcc/dwarf2out.c:13444
0x103baabb loc_descriptor
        ../../gcc/gcc/dwarf2out.c:13471
0x103bb17b dw_loc_list_1
        ../../gcc/gcc/dwarf2out.c:13748
0x103b605b dw_loc_list
        ../../gcc/gcc/dwarf2out.c:14018
0x103b605b loc_list_from_tree
        ../../gcc/gcc/dwarf2out.c:14403
0x103bd7fb add_location_or_const_value_attribute
        ../../gcc/gcc/dwarf2out.c:15908
0x103a227b gen_variable_die
        ../../gcc/gcc/dwarf2out.c:19102
0x103a4993 gen_decl_die
        ../../gcc/gcc/dwarf2out.c:20828
0x103c0d83 decls_for_scope
        ../../gcc/gcc/dwarf2out.c:20368
0x1039e4eb gen_subprogram_die
        ../../gcc/gcc/dwarf2out.c:18694
0x103a4747 gen_decl_die
        ../../gcc/gcc/dwarf2out.c:20761
0x103a62b3 dwarf2out_function_decl
        ../../gcc/gcc/dwarf2out.c:21202
0x1042d1f7 rest_of_handle_final
        ../../gcc/gcc/final.c:4508
0x1042d1f7 execute
        ../../gcc/gcc/final.c:4550
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-468910-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Nov 29 11:23:23 2014
Return-Path: <gcc-bugs-return-468910-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1223 invoked by alias); 29 Nov 2014 11:23:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1170 invoked by uid 48); 29 Nov 2014 11:23:17 -0000
From: "maciej at opencsw dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/61303] gccgo: segfault, regression since 4.8.2
Date: Sat, 29 Nov 2014 11:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: maciej at opencsw dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: version
Message-ID: <bug-61303-4-sVKvNofkM6@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61303-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61303-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg03382.txt.bz2
Content-length: 431

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61303

Maciej Bliziński <maciej at opencsw dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.9.0                       |4.9.2

--- Comment #6 from Maciej Bliziński <maciej at opencsw dot org> ---
Just checked, the problem is still there in GCC 4.9.2.
>From gcc-bugs-return-468911-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Nov 29 12:22:47 2014
Return-Path: <gcc-bugs-return-468911-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26012 invoked by alias); 29 Nov 2014 12:22:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25983 invoked by uid 48); 29 Nov 2014 12:22:43 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051
Date: Sat, 29 Nov 2014 12:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc short_desc
Message-ID: <bug-64115-4-UGKXnXuwyG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64115-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64115-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg03383.txt.bz2
Content-length: 754

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd115

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uweigand at gcc dot gnu.org
            Summary|[5 Regression] ICE: : in    |[4.9/5 Regression] ICE: :
                   |rs6000_delegitimize_address |in
                   |, at                        |rs6000_delegitimize_address
                   |config/rs6000/rs6000.c:7051 |, at
                   |                            |config/rs6000/rs6000.c:7051

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Started with r204803.

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Target Milestone|---                         |4.9.3

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-12-01
           Assignee|unassigned at gcc dot gnu.org      |uweigand at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Confirmed.

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje.gcc at gmail dot com

--- Comment #3 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
The ICE is triggered by checking code in rs6000_delegitimize_address:

  if (GET_CODE (y) == UNSPEC
      && XINT (y, 1) == UNSPEC_TOCREL)
    {
#ifdef ENABLE_CHECKING
      if (REG_P (XVECEXP (y, 0, 1))
          && REGNO (XVECEXP (y, 0, 1)) == TOC_REGISTER)
        {
          /* All good.  */
        }
      else if (GET_CODE (XVECEXP (y, 0, 1)) == DEBUG_EXPR)
        {
          /* Weirdness alert.  df_note_compute can replace r2 with a
             debug_expr when this unspec is in a debug_insn.
             Seen in gcc.dg/pr51957-1.c  */
        }
      else
        {
          debug_rtx (orig_x);
          abort ();
        }
#endif

which attempts to ensure that the second argument of UNSPEC_TOCREL is the TOC
register.   However, this check seems fragile; in debug code, we can get RTX
simplifications that replace the TOC register by some equivalent expression.

The code already recognizes one such case; this bug shows another case, where
the TOC register is replaced by a MEM RTX for the TOC save slot holding the TOC
value.  [ This case is probably made more likely by the change in my ELFv2 ABI
preparation patch, which has the effect of making TOC moves into the save slot
more explicit at the RTL level, allowing var-tracking code to detect that
equivalence. ]

One could try to make this check in rs6000_delegitimize_address more generic by
allowing some (or all) MEM RTXes.  However, I'm wonding what exactly that check
is supposed to achieve in the first place; for the purposes of this routine,
the second argument of UNSPEC_TOCREL is really irrelevant.

David, would you be OK with simply removing the check (everything enclosed with
ENABLE_CHECKING in the above code)?

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gcc dot gnu.org,
                   |                            |dje at gcc dot gnu.org

--- Comment #4 from David Edelsohn <dje at gcc dot gnu.org> ---
This was part of a large patch by Alan and probably added by him while he was
debugging. I would like his recommendations about the fate of the checking
code.

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[amodra at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gmail dot com

--- Comment #5 from Alan Modra <amodra at gmail dot com> ---
I'm happy to have it removed.

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

--- Comment #6 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Author: uweigand
Date: Tue Dec  2 14:27:46 2014
New Revision: 218273

URL: https://gcc.gnu.org/viewcvs?rev=218273&root=gcc&view=rev
Log:
    PR target/64115
    * config/rs6000/rs6000.c (rs6000_delegitimize_address): Remove
    invalid UNSPEC_TOCREL sanity check under ENABLE_CHECKING.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000.c

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

--- Comment #7 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Author: uweigand
Date: Tue Dec  2 14:30:47 2014
New Revision: 218274

URL: https://gcc.gnu.org/viewcvs?rev=218274&root=gcc&view=rev
Log:
    PR target/64115
    * config/rs6000/rs6000.c (rs6000_delegitimize_address): Remove
    invalid UNSPEC_TOCREL sanity check under ENABLE_CHECKING.

Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/rs6000/rs6000.c

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

--- Comment #8 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Author: uweigand
Date: Tue Dec  2 14:33:00 2014
New Revision: 218275

URL: https://gcc.gnu.org/viewcvs?rev=218275&root=gcc&view=rev
Log:
    PR target/64115
    * config/rs6000/rs6000.c (rs6000_delegitimize_address): Remove
    invalid UNSPEC_TOCREL sanity check under ENABLE_CHECKING.

Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/rs6000/rs6000.c

[Bug target/64115] [4.9/5 Regression] ICE: : in rs6000_delegitimize_address, at config/rs6000/rs6000.c:7051

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64115

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Fixed everywhere.