[Bug sanitizer/64131] [5 Regression] libsanitizer fails to build for AARCH64 with the glibc from the trunk

[Bug sanitizer/64131] [5 Regression] libsanitizer fails to build for AARCH64 with the glibc from the trunk

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64131

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build
   Target Milestone|---                         |5.0
            Summary|libsanitizer fails to build |[5 Regression] libsanitizer
                   |for AARCH64 with the glibc  |fails to build for AARCH64
                   |from the trunk              |with the glibc from the
                   |                            |trunk

[Bug sanitizer/64131] New: libsanitizer fails to build for AARCH64 with the glibc from the trunk

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64131

            Bug ID: 64131
           Summary: libsanitizer fails to build for AARCH64 with the glibc
                    from the trunk
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org
            Target: aarch64-linux-gnu

libsanitizer is broken for AARCH64 with the trunk version of glibc.

In file included from
/data1/src/gcc-cavium/toolchain-thunder/scripts/../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc:176:0:
/data1/src/gcc-cavium/toolchain-thunder/scripts/../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:272:72:
error: size of array ‘assertion_failed__1058’ is negative
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                        ^
/data1/src/gcc-cavium/toolchain-thunder/scripts/../src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:266:30:
note: in expansion of macro ‘IMPL_COMPILER_ASSERT’
 #define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
                              ^
/data1/src/gcc-cavium/toolchain-thunder/scripts/../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h:1288:3:
note: in expansion of macro ‘COMPILER_CHECK’
   COMPILER_CHECK(sizeof(((__sanitizer_##CLASS *) NULL)->MEMBER) == \
   ^
/data1/src/gcc-cavium/toolchain-thunder/scripts/../src/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc:1058:1:
note: in expansion of macro ‘CHECK_SIZE_AND_OFFSET’
 CHECK_SIZE_AND_OFFSET(ipc_perm, mode);
 ^
make[5]: *** [sanitizer_platform_limits_posix.lo] Error 1
>From gcc-bugs-return-468992-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Nov 30 23:38:16 2014
Return-Path: <gcc-bugs-return-468992-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7113 invoked by alias); 30 Nov 2014 23:38:15 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7050 invoked by uid 48); 30 Nov 2014 23:38:11 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/64131] [5 Regression] libsanitizer fails to build for AARCH64 with the glibc from the trunk
Date: Sun, 30 Nov 2014 23:38:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: sanitizer
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: blocker
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64131-4-uSyYQ20c3J@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64131-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64131-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg03464.txt.bz2
Content-length: 435

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd131

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I suspect the following glibc change introduced the bug into sanitizer:
commit 5c40c3bab2fddaca8cfe12d75944d1fef8adf1a4
Author: Alan Hayward <alan.hayward@arm.com>
Date:   Tue Nov 11 16:32:34 2014 +0000

    [AArch64] Add ipc.h.

    Adding ipc.h for AArch64 adjusted to behave correctly on big endian
    targets.

[Bug sanitizer/64131] [5 Regression] libsanitizer fails to build for AARCH64 with the glibc from the trunk

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64131

clyon at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #2 from clyon at gcc dot gnu.org ---
Hi Andrew,
I've been made aware of this problem a few days ago by Marcus.
I plan to work on cleaning libsanitizer a bit (the other cleanup I'm working on
first is the old_[gu]id type change in the kernel).

[Bug sanitizer/64131] [5 Regression] libsanitizer fails to build for AARCH64 with the glibc from the trunk

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64131

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Wed Jan 21 21:21:27 2015
New Revision: 219968

URL: https://gcc.gnu.org/viewcvs?rev=219968&root=gcc&view=rev
Log:
    PR sanitizer/64435
    * sanitizer_common/sanitizer_platform_limits_posix.h: Cherry pick
    upstream r226637.
    * sanitizer_common/sanitizer_platform_limits_posix.cc: Likewise.
    * sanitizer_common/sanitizer_posix.cc: Cherry pick upstream r226639.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc
    trunk/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h
    trunk/libsanitizer/sanitizer_common/sanitizer_posix.cc