public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/64138] gfortran interface issue
Date: Tue, 02 Dec 2014 17:13:00 -0000	[thread overview]
Message-ID: <bug-64138-4-eyD4BMbyCg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64138-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64138

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I was sure to have seen discussions about such issues: pr33997 and 

https://groups.google.com/forum/#!msg/comp.lang.fortran/GIcxE7GM1ek/aP7eJpQ-T7QJ

AFAIU the discussions, the relevant point for this PR is

> (b) A nonoptional non-passed-object dummy argument whose name
> is such that either the other procedure has no dummy argument
> with that name or the dummy argument with that name is distinguishable
> with it.

Along this line I have renamed num to num1 and z1 to z2 in c_sub_rc

       module complex_number_module
        implicit none

        integer, parameter :: loc_real_precision = 8

        type complex_number
          real(kind=loc_real_precision) :: real_part, imag_part
        end type complex_number

        interface c_sub
          module procedure c_sub_cc,    &      ! z1 - z2
                           c_sub_cr,    &      ! z1 - num, where num is a real
number
                           c_sub_rc            ! num - z1, where num is a real
number
        end interface

 contains
! --------------------------------------------------------------------------
        type (complex_number) function c_sub_cc (z1, z2)

        type (complex_number), intent(in) :: z1, z2

        c_sub_cc%real_part = z1%real_part - z2%real_part
        c_sub_cc%imag_part = z1%imag_part - z2%imag_part

        end function c_sub_cc

! --------------------------------------------------------------------------
        type (complex_number) function c_sub_cr (z1, num)

        type (complex_number),     intent(in) :: z1
        real(kind=loc_real_precision), intent(in) :: num

        c_sub_cr%real_part = z1%real_part - num
        c_sub_cr%imag_part = z1%imag_part

        end function c_sub_cr

! --------------------------------------------------------------------------
        type (complex_number) function c_sub_rc (num1, z2)

        type (complex_number),     intent(in) :: z2
        real(kind=loc_real_precision), intent(in) :: num1

        c_sub_rc%real_part = num1 - z2%real_part
        c_sub_rc%imag_part = - z2%imag_part

        end function c_sub_rc

      end module complex_number_module

program foo
  use complex_number_module
  type(complex_number) a, b
  real(loc_real_precision) x
  a%real_part = 1
  a%imag_part = 2
  x = 3
  b = c_sub(a, x); print '(A,2F5.1)', 'a-x = ', b%real_part, b%imag_part
  b = c_sub(x, a); print '(A,2F5.1)', 'x-a = ', b%real_part, b%imag_part
  b = c_sub(z1=a, num=x); print '(A,2F5.1)', 'a-x = ', b%real_part, b%imag_part
  b = c_sub(num=x,z1=a); print '(A,2F5.1)', 'a-x = ', b%real_part, b%imag_part
  b = c_sub(num1=x,z2=a); print '(A,2F5.1)', 'x-a = ', b%real_part, b%imag_part
end program foo

This made the code to compile and if I am not mistaken to produce the correct
result

a-x =  -2.0  2.0
x-a =   2.0 -2.0
a-x =  -2.0  2.0
a-x =  -2.0  2.0
x-a =   2.0 -2.0


Out of curiosity why do want to handle complex numbers through types while they
are perfectly handled in Fortran by kinds?

To conclude I think this PR should be closed as INVALID.


  parent reply	other threads:[~2014-12-02 17:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 15:03 [Bug fortran/64138] New: " wong.david-c at epa dot gov
2014-12-01 17:24 ` [Bug fortran/64138] " kargl at gcc dot gnu.org
2014-12-01 20:11 ` wong.david-c at epa dot gov
2014-12-01 20:13 ` wong.david-c at epa dot gov
2014-12-01 20:17 ` kargl at gcc dot gnu.org
2014-12-02 15:37 ` wong.david-c at epa dot gov
2014-12-02 16:05 ` sgk at troutmask dot apl.washington.edu
2014-12-02 17:13 ` dominiq at lps dot ens.fr [this message]
2014-12-02 17:29 ` sgk at troutmask dot apl.washington.edu
2014-12-02 17:36 ` dominiq at lps dot ens.fr
2014-12-06 15:03 ` dominiq at lps dot ens.fr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64138-4-eyD4BMbyCg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).