* [Bug tree-optimization/64193] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
@ 2014-12-05 12:30 ` cederman at gaisler dot com
2014-12-05 12:31 ` cederman at gaisler dot com
` (12 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: cederman at gaisler dot com @ 2014-12-05 12:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #1 from Daniel Cederman <cederman at gaisler dot com> ---
Created attachment 34197
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34197&action=edit
assembly output with r173250
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
2014-12-05 12:30 ` [Bug tree-optimization/64193] Decreased performance after r173250 cederman at gaisler dot com
@ 2014-12-05 12:31 ` cederman at gaisler dot com
2014-12-08 13:40 ` [Bug tree-optimization/64193] [4.8/4.9/5 Regression] " rguenth at gcc dot gnu.org
` (11 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: cederman at gaisler dot com @ 2014-12-05 12:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #2 from Daniel Cederman <cederman at gaisler dot com> ---
Created attachment 34198
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34198&action=edit
assembly output without r173250
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9/5 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
2014-12-05 12:30 ` [Bug tree-optimization/64193] Decreased performance after r173250 cederman at gaisler dot com
2014-12-05 12:31 ` cederman at gaisler dot com
@ 2014-12-08 13:40 ` rguenth at gcc dot gnu.org
2014-12-09 10:48 ` rguenth at gcc dot gnu.org
` (10 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-12-08 13:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |missed-optimization
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2014-12-08
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Target Milestone|--- |4.8.4
Summary|Decreased performance after |[4.8/4.9/5 Regression]
|r173250 |Decreased performance after
| |r173250
Ever confirmed|0 |1
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look. Note the rev. was backported to GCC 4.5 and up.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9/5 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2014-12-08 13:40 ` [Bug tree-optimization/64193] [4.8/4.9/5 Regression] " rguenth at gcc dot gnu.org
@ 2014-12-09 10:48 ` rguenth at gcc dot gnu.org
2014-12-09 13:40 ` rguenther at suse dot de
` (9 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-12-09 10:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 34229
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34229&action=edit
patch
Ok, I see the regression introduced by that rev., but on trunk (r218479)
I get the same code generated with/without the attached fix. I'm using
-O3 -m32 -march=i686 on x86_64-linux.
Probably the regression was mitigated by the partial fix for PR63677:
2014-11-20 Richard Biener <rguenther@suse.de>
PR tree-optimization/63677
* tree-ssa-dom.c: Include gimplify.h for unshare_expr.
(avail_exprs_stack): Make a vector of pairs.
(struct hash_expr_elt): Replace stmt member with vop member.
(expr_elt_hasher::equal): Simplify.
...
where DOM now catches the CSE opportunities FRE no longer did.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9/5 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2014-12-09 10:48 ` rguenth at gcc dot gnu.org
@ 2014-12-09 13:40 ` rguenther at suse dot de
2014-12-09 13:57 ` dominiq at lps dot ens.fr
` (8 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenther at suse dot de @ 2014-12-09 13:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #6 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 9 Dec 2014, cederman at gaisler dot com wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
>
> --- Comment #5 from Daniel Cederman <cederman at gaisler dot com> ---
> > Probably the regression was mitigated by the partial fix for PR63677:
>
> Yes, that seems to be the case for my attached example. Do you think that the
> regression is mitigated in general, or is your attached fix also needed?
I am testing my fix and will install it nevertheless - it is required
to get full optimistic value-numbering again. It would be also the
fix that is appropriate for backporting (if any of them is).
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9/5 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2014-12-09 13:40 ` rguenther at suse dot de
@ 2014-12-09 13:57 ` dominiq at lps dot ens.fr
2014-12-09 13:58 ` rguenther at suse dot de
` (7 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: dominiq at lps dot ens.fr @ 2014-12-09 13:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
AFAICT if there is any speedup with the patch in comment 5, it is negligible on
a 2.8Ghz Corei7 and x86_64-apple-darwin14: ~7.1s with/without the patch. Note
that the timing in the test is not very precise.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9/5 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2014-12-09 13:57 ` dominiq at lps dot ens.fr
@ 2014-12-09 13:58 ` rguenther at suse dot de
2014-12-09 14:25 ` [Bug tree-optimization/64193] [4.8/4.9 " rguenth at gcc dot gnu.org
` (6 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenther at suse dot de @ 2014-12-09 13:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #8 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 9 Dec 2014, dominiq at lps dot ens.fr wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
>
> --- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> AFAICT if there is any speedup with the patch in comment 5, it is negligible on
> a 2.8Ghz Corei7 and x86_64-apple-darwin14: ~7.1s with/without the patch. Note
> that the timing in the test is not very precise.
As said the patch is more interesting on the 4.9 branch where the DOM
improvements do not mitigate its effect (or with -fno-tree-dominator-opts)
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2014-12-09 13:58 ` rguenther at suse dot de
@ 2014-12-09 14:25 ` rguenth at gcc dot gnu.org
2014-12-09 14:25 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-12-09 14:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Dec 9 14:25:09 2014
New Revision: 218515
URL: https://gcc.gnu.org/viewcvs?rev=218515&root=gcc&view=rev
Log:
2014-12-09 Richard Biener <rguenther@suse.de>
PR tree-optimization/64193
* tree-ssa-alias.c (walk_non_aliased_vuses): Add valueize parameter
and valueize the VUSE before looking up the def stmt.
* tree-ssa-alias.h (walk_non_aliased_vuses): Adjust prototype.
* tree-ssa-sccvn.c (vn_reference_lookup_pieces): Pass vn_valueize
to walk_non_aliased_vuses.
(vn_reference_lookup): Likewise.
* tree-ssa-dom.c (lookup_avail_expr): Pass NULL as valueize
callback to walk_non_aliased_vuses.
* gcc.dg/tree-ssa/ssa-fre-43.c: New testcase.
Added:
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-43.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-ssa-alias.c
trunk/gcc/tree-ssa-alias.h
trunk/gcc/tree-ssa-dom.c
trunk/gcc/tree-ssa-sccvn.c
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2014-12-09 14:25 ` [Bug tree-optimization/64193] [4.8/4.9 " rguenth at gcc dot gnu.org
@ 2014-12-09 14:25 ` rguenth at gcc dot gnu.org
2014-12-15 18:33 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-12-09 14:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
Known to work| |5.0
Summary|[4.8/4.9/5 Regression] |[4.8/4.9 Regression]
|Decreased performance after |Decreased performance after
|r173250 |r173250
Known to fail| |4.8.3, 4.9.2
--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2014-12-09 14:25 ` rguenth at gcc dot gnu.org
@ 2014-12-15 18:33 ` rguenth at gcc dot gnu.org
2014-12-19 13:42 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-12-15 18:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
Bug 64193 depends on bug 64312, which changed state.
Bug 64312 Summary: [5 Regression] ICE: Segmentation fault
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64312
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2014-12-15 18:33 ` rguenth at gcc dot gnu.org
@ 2014-12-19 13:42 ` jakub at gcc dot gnu.org
2015-06-23 8:23 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-12-19 13:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.4 |4.8.5
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.8/4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2014-12-19 13:42 ` jakub at gcc dot gnu.org
@ 2015-06-23 8:23 ` rguenth at gcc dot gnu.org
2015-06-26 20:19 ` [Bug tree-optimization/64193] [4.9 " jakub at gcc dot gnu.org
2015-06-26 20:39 ` jakub at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-06-23 8:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.5 |4.9.3
--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2015-06-23 8:23 ` rguenth at gcc dot gnu.org
@ 2015-06-26 20:19 ` jakub at gcc dot gnu.org
2015-06-26 20:39 ` jakub at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-26 20:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug tree-optimization/64193] [4.9 Regression] Decreased performance after r173250
[not found] <bug-64193-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2015-06-26 20:19 ` [Bug tree-optimization/64193] [4.9 " jakub at gcc dot gnu.org
@ 2015-06-26 20:39 ` jakub at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2015-06-26 20:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64193
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.9.3 |4.9.4
^ permalink raw reply [flat|nested] 14+ messages in thread