public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dje at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/64256] [5.0 Regression] Pointer Bounds Checker builtins enum overflows stabstring length
Date: Fri, 06 Feb 2015 17:04:00 -0000	[thread overview]
Message-ID: <bug-64256-4-KTPyY3iIGy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64256-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64256

--- Comment #10 from David Edelsohn <dje at gcc dot gnu.org> ---
Stabstring continuations originally seem to have been disabled for AIX XCOFF
because the AIX assembler did not support them correctly.  IBM's proprietary
compiler, VAC/XLC, directly generates object files and does not use the AIX
assembler.  XLC produces assembly language files by invoking a disassembler on
the object file.

The AIX XCOFF documentation and stabstring grammar defined continuations, XLC
produced them, the disassembler displayed them, AIX ld supported them, AIX DBX
supported them, but AIX Assembler did not.  No one manually wrote assembly
language files with long enough stabstrings (or any stabstrings) to trip over
the bug.

GCC is the biggest user of the AIX assembler.

At some point the AIX assembler was fixed and now properly supports stabstring
continuations.  As Zoltan mentioned, XLC seems to limit stabstrings to 16K.  XL
disassembler also uses '?' as the continuation character.  GDB accepts '?' as
an alternate continuation character, in addition to '\\'.  On AIX, it is safer
to produce code similar to XLC because the rest of the AIX tools consume that
and problems can be reproduced with native tools, ensuring fixes.

I will test the following patch

Index: xcoffout.h
===================================================================
--- xcoffout.h  (revision 220457)
+++ xcoffout.h  (working copy)
@@ -161,9 +161,12 @@
 /* Do not emit any marker for XCOFF until assembler allows XFT_CV.  */
 #define NO_DBX_GCC_MARKER

-/* Do not break .stabs pseudos into continuations.  */
-#define DBX_CONTIN_LENGTH 0
+/* XCOFF32 maximum length is 64K; XLC limits to 16K.  */
+#define DBX_CONTIN_LENGTH 16384

+/* XLC uses '?' as continuation character.  */
+#define DBX_CONTIN_CHAR '?'
+
 /* Don't try to use the `x' type-cross-reference character in DBX data.
    Also has the consequence of putting each struct, union or enum
    into a separate .stabs, containing only cross-refs to the others.  */


  parent reply	other threads:[~2015-02-06 17:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 15:43 [Bug bootstrap/64256] New: " dje at gcc dot gnu.org
2014-12-10 15:45 ` [Bug bootstrap/64256] " dje at gcc dot gnu.org
2014-12-10 15:49 ` rguenth at gcc dot gnu.org
2014-12-10 16:30 ` jakub at gcc dot gnu.org
2014-12-10 17:09 ` jakub at gcc dot gnu.org
2015-01-31 18:59 ` zoltan at hidvegi dot com
2015-02-04 23:46 ` zoltan at hidvegi dot com
2015-02-04 23:53 ` zoltan at hidvegi dot com
2015-02-05  1:58 ` dje at gcc dot gnu.org
2015-02-05  4:39 ` zoltan at hidvegi dot com
2015-02-06 17:04 ` dje at gcc dot gnu.org [this message]
2015-02-06 17:58 ` zoltan at hidvegi dot com
2015-02-07  2:35 ` dje at gcc dot gnu.org
2015-02-07 10:51 ` [Bug bootstrap/64256] [5 " jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64256-4-KTPyY3iIGy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).