[Bug target/64338] New: [5 Regression] ICE in swap_condition, at jump.c:628

[Bug target/64338] New: [5 Regression] ICE in swap_condition, at jump.c:628

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

            Bug ID: 64338
           Summary: [5 Regression] ICE in swap_condition, at jump.c:628
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org

Created attachment 34295
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34295&action=edit
preprocessed source

> ./cc1plus  -quiet KDChartCartesianAxis.ii  -quiet -mtune=generic -march=i586 -g -O2 -fomit-frame-pointer -fno-exceptions -fno-check-new  -fno-threadsafe-statics -fvisibility=hidden -fvisibility-inlines-hidden -fPIC  -m32
/home/abuild/rpmbuild/BUILD/calligra-2.8.6/3rdparty/kdchart/src/KDChartCartesianAxis.cpp:
In member function 'virtual void
KDChart::CartesianAxis::paintCtx(KDChart::PaintContext*)':
/home/abuild/rpmbuild/BUILD/calligra-2.8.6/3rdparty/kdchart/src/KDChartCartesianAxis.cpp:1426:1:
internal compiler error: in swap_condition, at jump.c:628
0xda1ad1 swap_condition(rtx_code)
        /space/rguenther/src/svn/trunk2/gcc/jump.c:628
0xb7664d emit_store_flag_1
        /space/rguenther/src/svn/trunk2/gcc/expmed.c:5227
0xb76d47 emit_store_flag(rtx_def*, rtx_code, rtx_def*, rtx_def*, machine_mode,
int, int)
        /space/rguenther/src/svn/trunk2/gcc/expmed.c:5434
0x1303358 ix86_expand_int_movcc(rtx_def**)
        /space/rguenther/src/svn/trunk2/gcc/config/i386/i386.c:20929
0x1303ab0 ix86_expand_int_movcc(rtx_def**)
        /space/rguenther/src/svn/trunk2/gcc/config/i386/i386.c:21098
0x144a08b gen_movqicc(rtx_def*, rtx_def*, rtx_def*, rtx_def*)
        /space/rguenther/src/svn/trunk2/gcc/config/i386/i386.md:16600
0xe547c8 insn_gen_fn::operator()(rtx_def*, rtx_def*, rtx_def*, rtx_def*) const
        /space/rguenther/src/svn/trunk2/gcc/recog.h:305
0xe53741 maybe_gen_insn(insn_code, unsigned int, expand_operand*)
        /space/rguenther/src/svn/trunk2/gcc/optabs.c:8377
0xe53a3e maybe_expand_insn(insn_code, unsigned int, expand_operand*)
        /space/rguenther/src/svn/trunk2/gcc/optabs.c:8407
0xe4a8b7 emit_conditional_move(rtx_def*, rtx_code, rtx_def*, rtx_def*,
machine_mode, rtx_def*, rtx_def*, machine_mode, int)
        /space/rguenther/src/svn/trunk2/gcc/optabs.c:4614
0x17f2c00 noce_emit_cmove
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:1498
0x17f31c1 noce_try_cmove
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:1578
0x17f5d73 noce_process_if_block
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:2754
0x17f6fa6 noce_find_if_block
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:3214
0x17f7651 find_if_header
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:3423
0x17fa187 if_convert
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:4572
0x17fa4bd execute
        /space/rguenther/src/svn/trunk2/gcc/ifcvt.c:4718
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug target/64338] [5 Regression] ICE in swap_condition, at jump.c:628

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |i?86-*-*
   Target Milestone|---                         |5.0

[Bug target/64338] [5 Regression] ICE in swap_condition, at jump.c:628

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-12-17
                 CC|                            |trippels at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(gdb) p code
$1 = UNKNOWN

markus@x4 tmp % cat KDChartCartesianAxis.ii
enum Orientation
{
};
class A
{
public:
  A ();
};
class B
{
public:
  int m_fn1 ();
};
class C
{
  class D;
  D *m_fn2 ();
  void m_fn3 (void *);
  int m_fn4 ();
};
class F
{
public:
  void m_fn5 (const int & = 0);
};
class G
{
public:
  F *m_fn6 ();
};
class H
{
public:
  int subStepWidth;
};
class C::D
{
  friend class C;
  G *m_fn7 ();
};
Orientation a;
void
C::m_fn3 (void *)
{
  int b = a;
  H c;
  if (b)
    m_fn2 ()->m_fn7 ()->m_fn6 ()->m_fn5 ();
  double d;
  if (m_fn4 ())
    d = c.subStepWidth > 0;
  A e (b ? A () : A ());
  B f;
  f.m_fn1 () && d && m_fn2 ();
}

markus@x4 tmp % g++ -c -mtune=generic -march=i586 -m32 -O2
KDChartCartesianAxis.ii
KDChartCartesianAxis.ii: In member function ‘void C::m_fn3(void*)’:
KDChartCartesianAxis.ii:55:1: internal compiler error: in swap_condition, at
jump.c:628
>From gcc-bugs-return-470989-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 17 13:48:37 2014
Return-Path: <gcc-bugs-return-470989-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3361 invoked by alias); 17 Dec 2014 13:48:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3301 invoked by uid 48); 17 Dec 2014 13:48:33 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64254] [5 Regression] FAIL: c-c++-common/torture/vshuf-(v4si|v8hi).c -O* (internal compiler error) between r218540 and r218566.
Date: Wed, 17 Dec 2014 13:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-64254-4-N4UnipFRV5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64254-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64254-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg01996.txt.bz2
Content-length: 758

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd254

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The failures for c-c++-common/torture/vshuf-(v4si|v8hi).c are gone at r218812
(they were still present at r218658), see

https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg02164.html

I have no interest in bisecting the range. The
gcc.target/i386/avx512bw-vpbroadcast[bw]-1.c failures are tracked in pr64311.
Closing as FIXED.

[Bug target/64338] [5 Regression] ICE in swap_condition, at jump.c:628

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Started with r217646.

[Bug target/64338] [5 Regression] ICE in swap_condition, at jump.c:628

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 34393
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34393&action=edit
gcc5-pr64338.patch

ix86_expand_int_movcc is called there with (ltgt (reg:CCFPU flags) (const_int
0)) condition, and I see several issues with that:
1) the code assumes that reverse_condition (whatever kind of that) always
succeeds, which is not always true; we shouldn't swap things if we can't
reverse condition
2) for CCFP/CCFPU modes, we should treat them like floating point modes, LTGT
is reversible
3) in the first hunk, there are dead assignments:
compare_code = reverse_condition_maybe_unordered (compare_code);
and
compare_code = reverse_condition (compare_code);
when only a few lines below that there is unconditional:
compare_code = UNKNOWN;
4) (not handled in the patch), diff uses HOST_WIDE_INT variable, signed, and
the
values can be arbitrary, so we can end up with undefined behavior in the
compiler if cf - ct overflows, or if diff is HWI minimum on diff = -diff etc.

[Bug target/64338] [5 Regression] ICE in swap_condition, at jump.c:628

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Jan  8 19:15:53 2015
New Revision: 219356

URL: https://gcc.gnu.org/viewcvs?rev=219356&root=gcc&view=rev
Log:
    PR target/64338
    * config/i386/i386.c (ix86_expand_int_movcc): Don't reverse
    compare_code when it is unconditionally overwritten afterwards.
    Use ix86_reverse_condition instead of reverse_condition.  Don't
    change code if *reverse_condition* returned UNKNOWN and don't
    swap ct/cf and negate diff in that case.

    * g++.dg/opt/pr64338.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/opt/pr64338.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog

[Bug target/64338] [5 Regression] ICE in swap_condition, at jump.c:628

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64338

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.