[Bug middle-end/64391] New: ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[Bug middle-end/64391] New: ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

            Bug ID: 64391
           Summary: ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with
                    -fgnu-tm and #pragma GCC ivdep
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz

Created attachment 34324
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34324&action=edit
reduced testcase

Compiler output:
$ gcc -fgnu-tm testcase.c -wrapper valgrind,-q
==19617== Invalid read of size 2
==19617==    at 0xC5B0A4: get_attrs_for(tree_node const*) (trans-mem.c:179)
==19617==    by 0xC5DE28: is_tm_may_cancel_outer(tree_node*) (trans-mem.c:320)
==19617==    by 0xC5E147: diagnose_tm_1(gimple_stmt_iterator*, bool*,
walk_stmt_info*) (trans-mem.c:668)
==19617==    by 0x9FC9CE: walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*) (gimple-walk.c:551)
==19617==    by 0x9FCC08: walk_gimple_seq_mod(gimple_statement_base**,
tree_node* (*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node*
(*)(tree_node**, int*, void*), walk_stmt_info*) (gimple-walk.c:66)
==19617==    by 0x9FCAB2: walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*) (gimple-walk.c:579)
==19617==    by 0x9FCC08: walk_gimple_seq_mod(gimple_statement_base**,
tree_node* (*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node*
(*)(tree_node**, int*, void*), walk_stmt_info*) (gimple-walk.c:66)
==19617==    by 0x9FCCA6: walk_gimple_seq(gimple_statement_base*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*) (gimple-walk.c:96)
==19617==    by 0xC5DEC2: diagnose_tm_blocks (trans-mem.c:862)
==19617==    by 0xC5DEC2: (anonymous
namespace)::pass_diagnose_tm_blocks::execute(function*) (trans-mem.c:891)
==19617==    by 0xB5E85E: execute_one_pass(opt_pass*) (passes.c:2311)
==19617==    by 0xB5ECD5: execute_pass_list_1(opt_pass*) [clone .constprop.73]
(passes.c:2363)
==19617==    by 0xB5ED28: execute_pass_list(function*, opt_pass*)
(passes.c:2374)
==19617==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==19617== 
testcase.c: In function 'foo':
testcase.c:2:1: internal compiler error: Segmentation fault
 foo (void)
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r219043 - ICE
4_9 r219040 - ICE
4_8 - ignoring #pragma GCC ivdep

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

--- Comment #1 from Zdenek Sojka <zsojka at seznam dot cz> ---
Many gfortran testcases fail with the same backtrace when -fgnu-tm is used.

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-01-13
                 CC|                            |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.9.3
     Ever confirmed|0                           |1

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

diagnose_tm_1 probably isn't prepared for internal functions.

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
So e.g.

diff --git a/gcc/trans-mem.c b/gcc/trans-mem.c
index b449760..21fa497 100644
--- a/gcc/trans-mem.c
+++ b/gcc/trans-mem.c
@@ -183,6 +183,9 @@ static void *expand_regions (struct tm_region *,
 static tree
 get_attrs_for (const_tree x)
 {
+  if (x == NULL_TREE)
+    return NULL_TREE;
+
   switch (TREE_CODE (x))
     {
     case FUNCTION_DECL:
@@ -191,16 +194,16 @@ get_attrs_for (const_tree x)

     default:
       if (TYPE_P (x))
-       return NULL;
+       return NULL_TREE;
       x = TREE_TYPE (x);
       if (TREE_CODE (x) != POINTER_TYPE)
-       return NULL;
+       return NULL_TREE;
       /* FALLTHRU */

     case POINTER_TYPE:
       x = TREE_TYPE (x);
       if (TREE_CODE (x) != FUNCTION_TYPE && TREE_CODE (x) != METHOD_TYPE)
-       return NULL;
+       return NULL_TREE;
       /* FALLTHRU */

     case FUNCTION_TYPE:

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Tue Jan 13 20:22:32 2015
New Revision: 219555

URL: https://gcc.gnu.org/viewcvs?rev=219555&root=gcc&view=rev
Log:
    PR middle-end/64391
    * trans-mem.c (get_attrs_for): Return NULL_TREE if X is NULL_TREE.

    * gcc.dg/tm/pr64391.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/tm/pr64391.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/trans-mem.c

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed on trunk so far.

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Jan 14 08:43:53 2015
New Revision: 219581

URL: https://gcc.gnu.org/viewcvs?rev=219581&root=gcc&view=rev
Log:
    PR middle-end/64391
    * trans-mem.c (get_attrs_for): Return NULL_TREE if X is NULL_TREE.

    * gcc.dg/tm/pr64391.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/tm/pr64391.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/trans-mem.c

[Bug middle-end/64391] ICE: SIGSEGV in get_attrs_for (trans-mem.c:179) with -fgnu-tm and #pragma GCC ivdep

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64391

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.