public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "chengniansun at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/64423] New: Incorrect column number of -Wchar-subscripts
Date: Sun, 28 Dec 2014 06:10:00 -0000	[thread overview]
Message-ID: <bug-64423-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64423

            Bug ID: 64423
           Summary: Incorrect column number of -Wchar-subscripts
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: chengniansun at gmail dot com

The column number of -Wchar-subscripts is not precise. It always starts at the
beginning of the statement. 

$: cat t.c
int a[100];

int f(char c) {
  return a[c] + a[c] + a[c];
}

$: 
$: gcc-trunk -Wchar-subscripts -c t.c
t.c: In function ‘f’:
t.c:4:3: warning: array subscript has type ‘char’ [-Wchar-subscripts]
   return a[c] + a[c] + a[c];
   ^
t.c:4:3: warning: array subscript has type ‘char’ [-Wchar-subscripts]
t.c:4:3: warning: array subscript has type ‘char’ [-Wchar-subscripts]

$: 
$: clang-trunk -Wchar-subscripts -c t.c
t.c:4:11: warning: array subscript is of type 'char' [-Wchar-subscripts]
  return a[c] + a[c] + a[c];
          ^~
t.c:4:18: warning: array subscript is of type 'char' [-Wchar-subscripts]
  return a[c] + a[c] + a[c];
                 ^~
t.c:4:25: warning: array subscript is of type 'char' [-Wchar-subscripts]
  return a[c] + a[c] + a[c];
                        ^~
3 warnings generated.
>From gcc-bugs-return-471794-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Dec 28 06:19:23 2014
Return-Path: <gcc-bugs-return-471794-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26514 invoked by alias); 28 Dec 2014 06:19:21 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26485 invoked by uid 48); 28 Dec 2014 06:19:16 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/64423] Incorrect column number of -Wchar-subscripts
Date: Sun, 28 Dec 2014 06:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-64423-4-4LpzX8ZP5g@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64423-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64423-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg02801.txt.bz2
Content-length: 611

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd423

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-12-28
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
That is because warn_array_subscript_with_type_char does not take a location
and does not use warningat but rather just warning.

Confirmed.


             reply	other threads:[~2014-12-28  6:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-28  6:10 chengniansun at gmail dot com [this message]
2014-12-29 20:52 ` [Bug c/64423] " mpolacek at gcc dot gnu.org
2015-01-05 12:04 ` mpolacek at gcc dot gnu.org
2015-01-05 12:05 ` mpolacek at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64423-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).