public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug sanitizer/64435] [5 Regression] Bootstrap failure in libsanitizer on AArch64 with Linux kernel <= 3.15
Date: Mon, 19 Jan 2015 18:33:00 -0000	[thread overview]
Message-ID: <bug-64435-4-Csdx2jxR2X@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64435-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64435

--- Comment #19 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So, with:
--- libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h.jj   
2014-11-14 00:10:33.000000000 +0100
+++ libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h   
2015-01-19 19:22:43.777780408 +0100
@@ -167,7 +167,7 @@ namespace __sanitizer {
     unsigned __seq;
     u64 __unused1;
     u64 __unused2;
-#elif defined(__mips__)
+#elif defined(__mips__) || defined(__aarch64__)
     unsigned int mode;
     unsigned short __seq;
     unsigned short __pad1;
--- libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc.jj   
2015-01-19 09:39:09.000000000 +0100
+++ libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc   
2015-01-19 19:21:57.608564325 +0100
@@ -1059,7 +1059,13 @@ CHECK_SIZE_AND_OFFSET(ipc_perm, uid);
 CHECK_SIZE_AND_OFFSET(ipc_perm, gid);
 CHECK_SIZE_AND_OFFSET(ipc_perm, cuid);
 CHECK_SIZE_AND_OFFSET(ipc_perm, cgid);
+#ifndef __GLIBC_PREREQ
+#define __GLIBC_PREREQ(x, y) 0
+#endif
+#if !defined(__aarch64__) || !SANITIZER_LINUX || __GLIBC_PREREQ (2, 21)
+/* On aarch64 glibc 2.20 and earlier provided incorrect mode field.  */
 CHECK_SIZE_AND_OFFSET(ipc_perm, mode);
+#endif

 CHECK_TYPE_SIZE(shmid_ds);
 CHECK_SIZE_AND_OFFSET(shmid_ds, shm_perm);
--- libsanitizer/sanitizer_common/sanitizer_posix.cc.jj    2014-11-14
00:10:33.000000000 +0100
+++ libsanitizer/sanitizer_common/sanitizer_posix.cc    2015-01-19
19:24:14.636237703 +0100
@@ -76,16 +76,15 @@ static uptr GetKernelAreaSize() {

 uptr GetMaxVirtualAddress() {
 #if SANITIZER_WORDSIZE == 64
-# if defined(__powerpc64__)
+# if defined(__powerpc64__) || defined(__aarch64__)
   // On PowerPC64 we have two different address space layouts: 44- and 46-bit.
   // We somehow need to figure out which one we are using now and choose
   // one of 0x00000fffffffffffUL and 0x00003fffffffffffUL.
   // Note that with 'ulimit -s unlimited' the stack is moved away from the top
   // of the address space, so simply checking the stack address is not enough.
   // This should (does) work for both PowerPC64 Endian modes.
+  // Similarly, aarch64 has multiple address space layouts: 39, 42 and 48-bit.
   return (1ULL << (MostSignificantSetBitIndex(GET_CURRENT_FRAME()) + 1)) - 1;
-# elif defined(__aarch64__)
-  return (1ULL << 39) - 1;
 # elif defined(__mips64)
   return (1ULL << 40) - 1;
 # else

the layout looks reasonable:
|| `[0x009000000000, 0x03ffffffffff]` || HighMem    ||
|| `[0x002200000000, 0x008fffffffff]` || HighShadow ||
|| `[0x001200000000, 0x0021ffffffff]` || ShadowGap  ||
|| `[0x001000000000, 0x0011ffffffff]` || LowShadow  ||
|| `[0x000000000000, 0x000fffffffff]` || LowMem     ||
MemToShadow(shadow): 0x001200000000 0x00123fffffff 0x001440000000
0x0021ffffffff
and should accomodate the different addresses I saw for 42-bit address space so
far: <4GB, 0x10000000000 (place where libraries are mapped with ulimit -s
unlimited), 0x2aaXXXXXXXX (PIEs), 0x3ffXXXXXXXX (stack, normal mmap area for
limited ulimit -s).
But it still doesn't work:
==4746==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000028 (pc
0x0000004008f8 bp 0x03fff8078fc0 sp 0x03fff8078fc0 T0)
==4746==AddressSanitizer CHECK failed:
../../../../libsanitizer/sanitizer_common/sanitizer_allocator.h:835 "((res)) <
((kNumPossibleRegions))" (0x3ffa33, 0x80000)

I've tried to change
#if SANITIZER_CAN_USE_ALLOCATOR64
# if defined(__powerpc64__)
const uptr kAllocatorSpace =  0xa0000000000ULL;
const uptr kAllocatorSize  =  0x20000000000ULL;  // 2T.
# else
const uptr kAllocatorSpace = 0x600000000000ULL;
const uptr kAllocatorSize  =  0x40000000000ULL;  // 4T.
# endif
from the non-ppc64 values to the ppc64 values (i.e. added " ||
defined(__aarch64__)"), but strangely that didn't change anything.  So I'm out
of ideas on what else needs to be tweaked.  Kostya?


  parent reply	other threads:[~2015-01-19 18:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-29 15:41 [Bug sanitizer/64435] New: [5.0.0 " david.abdurachmanov at gmail dot com
2014-12-29 18:21 ` [Bug sanitizer/64435] " david.abdurachmanov at gmail dot com
2014-12-29 18:25 ` david.abdurachmanov at gmail dot com
2015-01-09 11:20 ` rguenth at gcc dot gnu.org
2015-01-09 11:54 ` david.abdurachmanov at gmail dot com
2015-01-13 11:24 ` [Bug sanitizer/64435] [5 " rguenth at gcc dot gnu.org
2015-01-13 15:45 ` jakub at gcc dot gnu.org
2015-01-13 21:17 ` clyon at gcc dot gnu.org
2015-01-18 12:38 ` jakub at gcc dot gnu.org
2015-01-18 19:07 ` david.abdurachmanov at gmail dot com
2015-01-18 19:11 ` jakub at gcc dot gnu.org
2015-01-18 19:37 ` pinskia at gcc dot gnu.org
2015-01-18 19:51 ` clyon at gcc dot gnu.org
2015-01-19  8:40 ` jakub at gcc dot gnu.org
2015-01-19 16:53 ` jakub at gcc dot gnu.org
2015-01-19 17:29 ` jakub at gcc dot gnu.org
2015-01-19 17:55 ` pinskia at gcc dot gnu.org
2015-01-19 17:56 ` jakub at gcc dot gnu.org
2015-01-19 18:01 ` jakub at gcc dot gnu.org
2015-01-19 18:33 ` jakub at gcc dot gnu.org [this message]
2015-01-19 20:13 ` clyon at gcc dot gnu.org
2015-01-19 21:49 ` jakub at gcc dot gnu.org
2015-01-20  8:10 ` jakub at gcc dot gnu.org
2015-01-20 16:53 ` kcc at gcc dot gnu.org
2015-01-21 21:22 ` jakub at gcc dot gnu.org
2015-01-21 22:09 ` jakub at gcc dot gnu.org
2015-01-26 15:18 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64435-4-Csdx2jxR2X@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).