public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/64465] [5 Regression] internal compiler error: verify_flow_info failed
Date: Mon, 05 Jan 2015 15:57:00 -0000	[thread overview]
Message-ID: <bug-64465-4-ePp31GbFZu@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64465-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64465

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #6)
> > Updated patch that works on this testcase.  From the cgraph.c comments, it
> > looks
> > like e.g. during function versioning we rely on fixup_cfg to fix it up, but
> > during inlining I think we need to do it immediately.  TODO_cleanup_cfg is on
> > during inlining.
> 
> execute_fixup_cfg is called from inline_transform, I wonder why it does not
> catch
> this case?  Anyway updating things immediately after redirection seems like
> right
> thing to do.  Any reason why this is not part of redirect_stmt_to_callee?

Because the early inliner does not call it.

And the reason why I haven't changed cgraph.c is:
      /* We need to defer cleaning EH info on the new statement to
         fixup-cfg.  We may not have dominator information at this point
         and thus would end up with unreachable blocks and have no way
         to communicate that we need to run CFG cleanup then.  */
comment, I initially had there the maybe_clean_or_replace_eh_stmt
(e->call_stmt, new_stmt); but that comment made me to reconsider.  Which is why
I've limited it in the patch to the inliner (id->call_stmt test), and don't do
this when versioning functions.


  parent reply	other threads:[~2015-01-05 15:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01 15:48 [Bug middle-end/64465] New: " hjl.tools at gmail dot com
2015-01-01 18:11 ` [Bug middle-end/64465] " hjl.tools at gmail dot com
2015-01-01 19:09 ` hubicka at gcc dot gnu.org
2015-01-02 14:59 ` jakub at gcc dot gnu.org
2015-01-05 14:35 ` jakub at gcc dot gnu.org
2015-01-05 15:48 ` hubicka at ucw dot cz
2015-01-05 15:57 ` jakub at gcc dot gnu.org [this message]
2015-01-05 16:45 ` hubicka at ucw dot cz
2015-01-05 17:11 ` jakub at gcc dot gnu.org
2015-01-05 21:45 ` jakub at gcc dot gnu.org
2015-01-05 22:06 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64465-4-ePp31GbFZu@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).