public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bernd.edlinger at hotmail dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ada/64478] Ada Exception handlers call signal-unsafe malloc/free
Date: Sat, 03 Jan 2015 08:20:00 -0000 [thread overview]
Message-ID: <bug-64478-4-U060jLWjUM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64478-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64478
Bernd Edlinger <bernd.edlinger at hotmail dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |UNCONFIRMED
Resolution|INVALID |---
--- Comment #7 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
(In reply to Andrew Pinski from comment #6)
> Actually here is what glibc says about malloc:
> Function: void * malloc (size_t size)
> Preliminary: | MT-Safe | AS-Unsafe lock | AC-Unsafe lock fd mem | See POSIX
> Safety Concepts.
>
> But this is a non-Async-Signal here we are talking about so this is safe and
> a bug in tsan for not realizing that.
Well, in this example the signal is synchonous,
but I see the same problem also when the stack overflows.
Ada installs a separate signal handler stack. So it is supposed to handle
that signal and do something about it, for instance re-boot the system or
something really security relevant.
That will not happen if the stack overflows inside malloc.
For instance this test case:
ulimit -s 1000
./c380004
,.,. C380004 ACATS 2.5 15-01-03 09:13:13
---- C380004 Check evaluation of discriminant expressions when the
constraint depends on a discriminant, and the
discriminants have defaults -
discriminant-dependententry families and protected
components.
- C380004 Discriminant-dependent entry families for task types.
- C380004 Discriminant-dependent entry families for protected types.
==================
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=19947)
#0 malloc ../../../../gcc-trunk/libsanitizer/tsan/tsan_interceptors.cc:491
(libtsan.so.0+0x000000025c33)
#1 __gnat_malloc /home/ed/gnu/gcc-build/gcc/ada/rts/s-memory.adb:92
(c380004+0x0000004330c0)
#2 _ada_c380004 /home/ed/gnu/gcc-test/c380004.adb:341
(c380004+0x000000406700)
#3 main /home/ed/gnu/gcc-test/b~c380004.adb:301 (c380004+0x0000004040be)
SUMMARY: ThreadSanitizer: signal-unsafe call inside of a signal
/home/ed/gnu/gcc-build/gcc/ada/rts/s-memory.adb:92 __gnat_malloc
==================
==================
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=19947)
#0 malloc ../../../../gcc-trunk/libsanitizer/tsan/tsan_interceptors.cc:491
(libtsan.so.0+0x000000025c33)
#1 __gnat_malloc /home/ed/gnu/gcc-build/gcc/ada/rts/s-memory.adb:92
(c380004+0x0000004330c0)
#2 _ada_c380004 /home/ed/gnu/gcc-test/c380004.adb:341
(c380004+0x000000406700)
#3 main /home/ed/gnu/gcc-test/b~c380004.adb:301 (c380004+0x0000004040be)
SUMMARY: ThreadSanitizer: signal-unsafe call inside of a signal
/home/ed/gnu/gcc-build/gcc/ada/rts/s-memory.adb:92 __gnat_malloc
==================
* C380004 Unexpected exception.
**** C380004 FAILED ****************************.
==================
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=19947)
#0 free ../../../../gcc-trunk/libsanitizer/tsan/tsan_interceptors.cc:538
(libtsan.so.0+0x000000025f29)
#1 __gnat_free /home/ed/gnu/gcc-build/gcc/ada/rts/s-memory.adb:113
(c380004+0x000000433111)
#2 _ada_c380004 /home/ed/gnu/gcc-test/c380004.adb:341
(c380004+0x000000406700)
#3 main /home/ed/gnu/gcc-test/b~c380004.adb:301 (c380004+0x0000004040be)
SUMMARY: ThreadSanitizer: signal-unsafe call inside of a signal
/home/ed/gnu/gcc-build/gcc/ada/rts/s-memory.adb:113 __gnat_free
==================
ThreadSanitizer: reported 3 warnings
see: the signal handler calls malloc and free, and apparently
evenreturns and prints "* C380004 Unexpected exception."
next prev parent reply other threads:[~2015-01-03 8:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 3:45 [Bug ada/64478] New: " bernd.edlinger at hotmail dot de
2015-01-03 3:46 ` [Bug ada/64478] " bernd.edlinger at hotmail dot de
2015-01-03 3:57 ` pinskia at gcc dot gnu.org
2015-01-03 7:34 ` bernd.edlinger at hotmail dot de
2015-01-03 7:36 ` pinskia at gcc dot gnu.org
2015-01-03 7:42 ` bernd.edlinger at hotmail dot de
2015-01-03 7:51 ` pinskia at gcc dot gnu.org
2015-01-03 8:20 ` bernd.edlinger at hotmail dot de [this message]
2015-01-03 8:37 ` pinskia at gcc dot gnu.org
2015-01-03 8:47 ` bernd.edlinger at hotmail dot de
2015-01-03 8:53 ` pinskia at gcc dot gnu.org
2015-01-03 9:20 ` bernd.edlinger at hotmail dot de
2015-01-03 11:11 ` bernd.edlinger at hotmail dot de
2015-01-04 10:03 ` ebotcazou at gcc dot gnu.org
2015-01-04 11:59 ` bernd.edlinger at hotmail dot de
2015-01-04 12:44 ` bernd.edlinger at hotmail dot de
2015-01-04 15:00 ` ebotcazou at gcc dot gnu.org
2015-01-04 15:26 ` bernd.edlinger at hotmail dot de
2015-01-13 8:58 ` bernd.edlinger at hotmail dot de
2015-01-13 9:31 ` ebotcazou at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-64478-4-U060jLWjUM@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).